Handheld radio now lights up when on. (#45984)

* walkie talkie feedback

* update copyright

the fewer pixels the more legitimate the copyright claim

* simpler walkietalkie visuals, no walkietalkie-off

* per-RSI states

* active/on order in json, remove radio off inhands

* Remove unused states from meta.json

whoops

* muh seccie copyright

Resources/Prototypes/Entities/Objects/Devices/radio.yml

@@ -1,8 +1,8 @@
 - type: entity
-  name: handheld radio
-  description: A handy handheld radio.
   parent: BaseItem
   id: RadioHandheld
+  name: handheld radio
+  description: A handy handheld radio.
   components:
   - type: TelecomExempt
   - type: RadioMicrophone
@@ -16,8 +16,25 @@
     sprite: Objects/Devices/communication.rsi
     layers:
     - state: walkietalkie
-    - state: walkietalkie-on
-    state: walkietalkie
+    - map: [enum.RadioDeviceVisualLayers.Broadcasting]
+      state: walkietalkie-on
+      shader: unshaded
+      visible: false
+    - map: [enum.RadioDeviceVisualLayers.Speaker]
+      state: walkietalkie-active
+      shader: unshaded
+      visible: false
+  - type: Appearance
+  - type: GenericVisualizer
+    visuals:
+      enum.RadioDeviceVisuals.Broadcasting:
+        enum.RadioDeviceVisualLayers.Broadcasting:
+          True: { visible: true }
+          False: { visible: false }
+      enum.RadioDeviceVisuals.Speaker:
+        enum.RadioDeviceVisualLayers.Speaker:
+          True: { visible: true }
+          False: { visible: false }
   - type: Item
     sprite: Objects/Devices/communication.rsi
     heldPrefix: walkietalkie
@@ -26,10 +43,10 @@
     - Radio
 
 - type: entity
-  name: security radio
-  description: A handy security radio.
   parent: [ RadioHandheld, BaseSecurityContraband ]
   id: RadioHandheldSecurity
+  name: security radio
+  description: A handy security radio.
   components:
   - type: RadioMicrophone
     broadcastChannel: Security
@@ -41,4 +58,3 @@
     sprite: Objects/Devices/securityhandy.rsi
   - type: Item
     sprite: Objects/Devices/securityhandy.rsi
-    heldPrefix: walkietalkie

Resources/Textures/Objects/Devices/communication.rsi/meta.json

@@ -1,7 +1,7 @@
 {
     "version": 1,
     "license": "CC-BY-SA-3.0",
-    "copyright": "Taken from cev-eris and modified by Swept at https://github.com/discordia-space/CEV-Eris/commit/efce5b6c3be75458ce238dcc01510e8f8a653ca6. Uplink radio sprites by Vermidia, derivative of other lisenced sprites in the repo",
+    "copyright": "Taken from cev-eris and modified by Swept at https://github.com/discordia-space/CEV-Eris/commit/efce5b6c3be75458ce238dcc01510e8f8a653ca6. Uplink radio sprites by Vermidia, derivative of other licensed sprites in the repo. walkietalkie/-on/-active edited by whatston3.",
     "size": {
         "x": 32,
         "y": 32
@@ -33,9 +33,6 @@
         {
             "name": "walkietalkie-on"
         },
-        {
-            "name": "walkietalkie-off"
-        },
         {
             "name": "walkietalkie-active"
         },
@@ -47,14 +44,6 @@
             "name": "walkietalkie-inhand-left",
             "directions": 4
         },
-        {
-            "name": "off-walkietalkie-inhand-right",
-            "directions": 4
-        },
-        {
-            "name": "off-walkietalkie-inhand-left",
-            "directions": 4
-        },
         {
             "name": "old-radio"
         },

Resources/Textures/Objects/Devices/securityhandy.rsi/meta.json

@@ -1,28 +1,28 @@
 {
-  "version": 1,
-  "license": "CC-BY-SA-3.0",
-  "copyright": "Taken from cev-eris and modified by Swept at https://github.com/discordia-space/CEV-Eris/commit/efce5b6c3be75458ce238dcc01510e8f8a653ca6",
-  "size": {
-    "x": 32,
-    "y": 32
-  },
-  "states": [
-    {
-      "name": "walkietalkie"
+    "version": 1,
+    "license": "CC-BY-SA-3.0",
+    "copyright": "Taken from cev-eris and modified by Swept at https://github.com/discordia-space/CEV-Eris/commit/efce5b6c3be75458ce238dcc01510e8f8a653ca6. Minor edits, unshaded separation by whatston3.",
+    "size": {
+        "x": 32,
+        "y": 32
     },
-    {
-      "name": "walkietalkie-inhand-left",
-      "directions": 4
-    },
-    {
-      "name": "walkietalkie-inhand-right",
-      "directions": 4
-    },
-    {
-      "name": "walkietalkie-off"
-    },
-    {
-      "name": "walkietalkie-on"
-    }
-  ]
+    "states": [
+        {
+            "name": "walkietalkie"
+        },
+        {
+            "name": "walkietalkie-on"
+        },
+        {
+            "name": "walkietalkie-active"
+        },
+        {
+            "name": "walkietalkie-inhand-left",
+            "directions": 4
+        },
+        {
+            "name": "walkietalkie-inhand-right",
+            "directions": 4
+        }
+    ]
 }