* Scope creep my ass
* why was this shit not pushed????
* gone...
* fix that
* review plus buildd
* asfsafsafsafsafas
* grug
* burber
* I'll fix this later
* shrimply die
* also this
* it's snerf or snuthin
* assaads
* round snend
* aaaa
* fix this shit for real
* actually, don't start GameRules until MapInit now that I think aboot it.
* forgot u
* don't actually need this part nullable
* Deffer comp removal
* one liner
* do that too
* chungus
* Honestly makes more sense here, plus WHY are we doing all that shit on "GameRuleAdded" rather than GameRuleStarted(?)
* deferred removal :V
* aaaaaaaaaaaaaaa
* whhop
* Whoop
* better
* landmine that I placed for myself then forgot about lmao
* cleanup
* FUCKING `!`
* gotovo
* amogus
* please don't check by metadata I beg
* waawsasfdfsasfa
* sfafsasfafsas
* fdsaasffsasfa
* code
* fix
* fasasffasfasfsad
* chungaas
* I may be stupid
* gra
* graaaaaaaaaaaaaaaaa
* comment
* gra
* clearing is not predicted and would require major refactors, so don't cache on client.
* lame shit :P
* last holes
* nukeopsfsafsasafsfafsa
* why was that shit public bruh
* bubrbgwahrghfaka
* dynamic
* revert change that did nothing lmao
* Axes the easy IMapManager references
* Axes the references to unported (obsolete) IMapManager methods
* Converts salvageruler command to a LocalizedEntityCommand so it can use SharedMapSystem
* Removes IMapManager from GameTicker
This required axing the map nuke during restart, but that should be fine?
Maps are entities so EntityManager.FlushEntities should delete them all and that's the preceding line
* submodule update(?)
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Pass 1.
* i'm FREE
* Prevent hangups.
* okay fine here's an attribute for settings, will polish later and prolly remove the overridable thing.
* sigh.
* fix singular trigger bug so LatheTest doesn't flake.
* Remove SystemAttribute usage.
* Poke
* I used the shotgun. You know why? Cause the shot gun doesn’t miss, and unlike the shitty hybrid taser it stops a criminal in their tracks in two hits. Bang, bang, and they’re fucking done. I use four shots just to make damn sure. Because, once again, I’m not there to coddle a buncha criminal scum sucking f------, I’m there to 1) Survive the fucking round. 2) Guard the armory. So you can absolutely get fucked. If I get unbanned, which I won’t, you can guarantee I will continue to use the shotgun to apprehend criminals. Because it’s quick, clean and effective as fuck. Why in the seven hells would I fuck around with the disabler shots, which take half a clip just to bring someone down, or with the tazer bolts which are slow as balls, impossible to aim and do about next to jack shit, fuck all. The shotgun is the superior law enforcement weapon. Because it stops crime. And it stops crime by reducing the number of criminals roaming the fucking halls.
* Change the faulty store test into two tests, one of which is ignored for failing.
* Make map tests more fine-grained.
* ..typo.
* fix example
* exclude Empty.
* Adjust a scrounger test & fix it.
* It does respect ignored prototypes, after I realized making it do so was really easy.
* Fix it for real this time.
* General scrounger enhancements for a GameRules test set.
* Fix linter for real.
* Address reviews.
* Added Snowball station
* updated snowball
* added AI restoration console and lowered pop req
* updated med
* added a paramed spawn
* fixed minor issues
* christmas + amber removal
* fixed tests failing
* test pass 2: for sure this time
* update
* update again
* final fix
* Enable whitelisting specific DNM prototypes per map
* Enable whitelisting directories
* Rename fields
* Use a HashSet instead of an array
* Add check for unused whitelist entries
* Remove whitelisting for meta (warden's rubber stamp was removed)
* Add glob support courtesy of @IProduceWidgets
* Update xmldoc
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Convert string literals to protoids in Content.Tests
* Convert string literals to protoids or consts in Content.IntegrationTests
* Fix linter failures
Tricksy static using misled me
* added plastitanium walls and windows
* Added DM01 Entryway to pool of deathmatch arenas
* replaced non-occluding walls with occluding ones
* added more details and fluff to empty rooms and hallways; added floor drains around the map
* Fixed failing integration test
* fixed YML syntax error causing test failures. What kind of retard thought that using whitespace as structural syntax is a good idea?
* minor map changes
---------
Co-authored-by: Unisol <pavelyakushevich@gmail.com>
* General structure mostly complete.
* I thiiiiiink I am done with air alarms. And pipes. Maybe.
* Decals, shuttle, rust.
* Small fixes.
* Shuttle more or less where I want it.
* Security is prettier, spawns are more fun.
* Shuttle done. Almost done with one checklist.
* Map renders now.
* Checklists done.
* Adjusted min player count.
* Should pass the Build & Test Debug check now.
* start ig
* command work +AI
* finished bridge, added signs to departments
* engi partly done
* finish engi + atmos except for cams
* added med yippie
* carGODO
* nerd department finished
* se(x)c finish
* courtroom + service power
* man im tweaking out
* service propa done
* hallways
* added cams everywhere and named all the doors :pain:
* arrivals maints + exterior catwalk
* more maints
* voxob
* draft done
* holopadpilled + gaspipesensor based
* added convex name everywhere it needed to be
* nvm i guess we dont do oxford comma
* redid ALL THE HGOLOPADS FAAAAAAAAAAAAAAAAAAAAA
* Fix conflicts?
* ok let me try something
* this works right?
* atmos updated + jani lights
* uniform hallway tiles +roundstart TEG
* fixed some hidden atmos stuff
* Update map_attributions.txt
* :finnadie: no map review ...
* the fog is coming
* maints theater redone
* light dirt and the murder of most trims
* 💔
* decal based and tileoverlay pilled
* updated arrivals/library
* bungus
* yvgh
* 6 hours later...
* finished for real?
* Plasma Station initial commit
* Map fixes 1
Expanded science's SMES array
Added advanced SMES
Redone stamped documents with custom stamps
Expanded atmospherics with more storage tanks
Added status displays
Add missing beacons to solars
Replaced the passive gates in science with valves
Removed protolathe in engineering
Added guitar to CE office
Replaced throngler plushie with weh cloak
Add a lattice tile outside the atmos burn chamber and storange tanks
Added atmos network monitor in bridge
* Add cargo and emergency shuttle
* Updated maps
* Add plasma to map testing list
* Map fixes 2
Reworked pipenets to not go under walls
Redid salvage and disposals
Reworked the bar to include a new bar extension facing the pool
Replaced arrivals cryo with an arcade
Replaced the toilets in the service plaza with cryo
Removed the cryo in dorms
Added more details to hallways
Redid tools room to include a front desk for the janitor closet
Reconnected sci to power roundstart
Removed some unideal spawns
Expanded the TEG airlock to be 2x3 instead of 1x3
Reduced the size of the SMES bank from 10 to 6
Disabled the plasma miners (downstreams or admins can re-enable them)
Replaced illegal maint items
* Fixes a 6 pack destroying the universe
Ok maybe cracking a cold one with the boys wasn't a great idea.
* Map fixes 3
* Quick research assistant fix
* Map fixes 4
* Map fixes 5
* webedit go brrrt
* Map fixes 6
* Map fixes 7
* Map fixes 8
* Fixes non-existent object
It's amazing this game runs at all
* Map fixes 9
* update pools
* Map fixes 10
* forgot to clear my multitool
I love mapping I love mapping I love mapping I love mapping I love mapping
---------
Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com>
* named apcs, doors, air alarms, cameras, fire alarms, substations, SMESs
* updated PostMapInitTest.cs to include Cell
* added psychologist spawn
* fixed scanner console link, fixed disposals conveyors, and more
* added janitor service lights, maints firelocks, and more
* added more fun maint rooms
* improved head offices, kitchen, psych. added maints between science and arrivals
* fixed spawners placed over solid objects
* added unique evac shuttle, the Cilium
* evac shuttle is now orientated correctly
* added unique cargo shuttle
* updated kitchen area
* renamed Cell Station to Elkridge Depot, removed most main hall airlocks for smoother travel
* general last-minute touch-ups around the bridge and sec
* changed station name in PostMapInitTest.cs
* Initial Commit with two departments done
* Checkpointing work
* Added most of service and science
* Started work on medbay
* Modified TEG setup and set up atmos pipes for engineering
* Re-added medbay, added chapel and janitorial, started routing disposals and generally the final layout of the map is coming together
* Plenty of additions, too many to list in a commit message
* Major update
* Nearly done with the map, just have to do decals and emergency lights
* Added all decals, only thing missing is department signs
* Toned back the dirt decals a bunch, added hallway signs and other decorations
* Finishing touches on the map before testing.
* Fixed invalids
* Renamed the station to Amber, and made a couple adjustments
* Completely redid cargo, added maints around sec
* Added Amber to the map post init integration test
* Many small updates addressing issues.
* Ran a script to update all the camera names, also ran fixgridatmos, fixrotations, tilewalls, and variantize
* Started addressing some of the issues brough up by Emisse and others
* Addressed all issues mentioned by reviewers. Added mail system.
* Wrapped up meeting all the issues raised by reviewers, also did a bunch of testing and resolved issues found during those tests
* Addressed additional requested changes, and nabbed some ship designs from Frontier. Redesigned south east maints and surrounding meteor nets based off of those designs
* Making a couple more requested changes
* Reduced the amount of Nitrogen Closets, made several small adjustments. Ready for review again!
* Removed invalids!
* web edit lmao
---------
Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com>
