* fix ancient 2022 ghost test failures
* remove my logs
* update the comment to be accurate
* remove braces
* better loggeewafsafasafsafsfasfasfasafs
* What does bro even do?
* Scope creep my ass
* why was this shit not pushed????
* gone...
* fix that
* review plus buildd
* asfsafsafsafsafas
* grug
* burber
* I'll fix this later
* shrimply die
* also this
* it's snerf or snuthin
* assaads
* round snend
* aaaa
* fix this shit for real
* actually, don't start GameRules until MapInit now that I think aboot it.
* forgot u
* don't actually need this part nullable
* Deffer comp removal
* one liner
* do that too
* chungus
* Honestly makes more sense here, plus WHY are we doing all that shit on "GameRuleAdded" rather than GameRuleStarted(?)
* deferred removal :V
* aaaaaaaaaaaaaaa
* whhop
* Whoop
* better
* landmine that I placed for myself then forgot about lmao
* cleanup
* FUCKING `!`
* gotovo
* amogus
* please don't check by metadata I beg
* waawsasfdfsasfa
* sfafsasfafsas
* fdsaasffsasfa
* code
* fix
* fasasffasfasfsad
* chungaas
* I may be stupid
* gra
* graaaaaaaaaaaaaaaaa
* comment
* gra
* clearing is not predicted and would require major refactors, so don't cache on client.
* lame shit :P
* last holes
* nukeopsfsafsasafsfafsa
* why was that shit public bruh
* bubrbgwahrghfaka
* dynamic
* revert change that did nothing lmao
* ports chat follow function from AL and removes PJB implementation
forgor to commit earlier so it's just one chunk
* fixes accidental MiscTab.xaml restructuring
* fix name color
* remove unused function
* cvar summary
* typo
* accidental doc removal
* fix test fail
* fix test fail
* like i said first pr :|
* inject in constructor
* adds chat links to Local, Whisper, LOOC and Dead Chat respects Admin ghost privacy
* i hate chat code
* remove cvar
* single events file
* adds CanGhostWarp back
* filter for admin ghosts
* move tag
* remove ChatLinkTag.cs
* fix speechbubble rendering
* i want to bash my brain in
* kill chatcode
* formatting
* testfail
* still not working
* atleast deadchat works now
* even prettier TextLinkTag.cs
* fix speechbubble rendering for looc
* docs
* renaming and better docs
* Revert "remove cvar"
This reverts commit 1acb168f
* final changes (hopefully)
* requested changes
* can't parse -
* change TextLinkTag again
* formatting and typo
Co-authored-by: Connor Huffine <chuffine@gmail.com>
* quickfix
* no logging for now actually
* i will work on this in the morning
* restructuring
* wip
* final restructuring and docs
* still not done btw
* review
* docfix
* actually we can filter for admin ghosts
* doc
* fix color
* fix fix color
* review
* all I care to clean up
* bold names
* doc
* admin warp
* fixed
* fsaasffsa
* GOD ONCE SAID: GOOD ENOUGH
* they call me the shuffler
* admin chat links
* forgor newline
* fix?
* actual fix
* dumb stuff
* chungus
---------
Co-authored-by: Connor Huffine <chuffine@gmail.com>
Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
* init
* fixes, ghosting
* i dont know man
* popups, slight rework, actually works now
* review
* failn't
* partial review
* new sprites
* cleanup
* fix
* fix multiple gasps, allow stasis when dead
* typo
* yeah
* yeah
* wuh
* merge master part 2
* sub attribute
* first try?
* renames
* network
* identity
* fix ts
* fix imports
* applying state check
* temp
* may god have mercy upon my soul
* stuff
* Revert "stuff"
This reverts commit de7ec9cb9f761f5cd954921a0efa495388634d30.
* Revert "may god have mercy upon my soul"
This reverts commit 3e1aa567d47e0576daa6ed420dad29b80c112a31.
* Revert "temp"
This reverts commit 501dd6d4f6fd22c466e4abb2a284212636123c4a.
* Revert "applying state check"
This reverts commit 3c211f0a54812797987c7ab93a9b140f66a9088d.
* fix
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* SpookyExtinguish, oooooo
* comments, intensity
* Use allowedIntensity in GhostSystem
* commento-stuffed
* GhostComponent: return to BooCount for sanity
* unindento
* fix ghost component, dependency order (holy shit)
* More cleanup than feature at this point
* Add partial to PoweredLightSystem
* event field order, ghost system comments
* Separate spooky, consistency w.r.t. DoGhostEvent
* BooActionEvent handler to GhostSystem.Boo, fix ext
* featuring kenny blankenship and vic romano
* fix maximum value
* Fix BooIntensity comment
* remove whitespace
* comments, RevenantSystem: set handled
* "for a typical ghost"
* Address PR suggestions
* Use Handled, SpookyLight: BooIntensity->Intensity
* Use Handled in BooActionEvent handler, update name
* remove query
* address beck-thompson's requested changes + Handled
* ResponseIntensity setter, private Handled setter
* Check Handled, not !Handled
* there is a third
* the hell was this using placement
* Obsolete Extinguish, Try with Entity<T>
* why wasn't this using TimeOffsetSerializer
---------
Co-authored-by: iaada <iaada@users.noreply.github.com>
* Remove all IPrototypeManager instances
* Remove redundant IComponentFactory instances too
* Found some stragglers
* DestructibleSystem.PrototypeManager: no dependency
* not based
* Empty commit
* yeah thingi
* added a GetHighestDamageTypes thingi to the DamageableSystem
* no idea why those files names are different only in github so just in case readding them
* yeah doing that
* first steps of moving the logic somewhere nicer
* still plenty to do
* gosh such a mess but getting progress done
* small fixie push
* big mess of bunch of stuff
* dealing with a conflict and fixing the random numbers
* testing if github will update now
* dealing with the other conflict
* github please update i beg you
* dealing with more conflicts
* hopefully this fixes it
* fixing conflicts again
* cleaning up stuffies
* sprite fixie
* general cleanup
* doing the small fixies first
* getting rid of the new event, gotta handle ashing next
* adding spaces to comments before i forget
* handling ashing
* think that did it?
* small fixies
* more small fixies
* last batch of quickie fixies before i gotta handle the bigger stuff
* last bunch of fixies i do understand
* small bit of progress yknow may as well yeah
* renaming and moving stuff to shared
* comment fixiees
* saving damage in a new component instead of in MindComponent
* protoid's and dict usage instead of the previously ickier methods
* small fixie before biggie fixie
* more fixies im slepy gosh
* thinkie that should fixie it
* smoothed the damage storage systeem so its less repetitive and icki and now itss cooler and i can go eepy
* lots of stuffies x3
* first step of getting git to detect my file name changes
* thinkie that should fixie it
* fixies
* just getting rid of the merge conflict, will check damageable later
* small thingies first
* more small stuffiees
* now all of the sprites have at leeast a 0
* dirtying the lastbody comp
* more fixies
* small thingi first
* another small fixie and a minor sprite fixie
* rng fixie
* moving the damage storage system to shared
* smoothing out code thats likely to be replaced soon but its good to do for now
* just showing progress bcus yis
* general progress stuffies mhm
* pushie
* small cleanup
* general progress :3
* in progress push for helpie
* proper pushie with progress and workies
* removed unnecessary usage of the storedamage component
* minor fixiees
* extra comments
* replaced a couple strings for ProtoId's
* gibbing related fixies :3
* Update DamageableSystem to modern standards
* DamageContainerId -> DamageContainerID with lint flag
* Replace strings with protoids
* Make CVar subscription declarations all consistently whitespaced
* ChangeDamage -> TryChangeDamage, cope with C# jank
* Revert event signature changes
* Restore a comment
* Re-add two queries
* Init the queries
* Use appearanceQuery in DamageChanged
* Use damageableQuery in TryChangeDamage
* Use damageableQuery in SetDamageModifierSetId
* Final cleanup, fix sandboxing
* Rectify ExplosionSystem:::ProcessEntity's call to TryChangeDamage
* Re-organize DamageableSystem
* first big fuck you breaking change.
* THATS A LOT OF DAMAGE!!!
* Fix test fails
* test fixes 2
* push it
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Move CanReturnToBody to system
* Move CanGhostInteract to system
* Cleanup redundant datafields and viewvariables
* Document datafields
* Document component
* Add SetTimeOfDeath Entity<T> overload, obsolete old version
* Document public methods
* Cleanup obsoleted method calls
* Extracts magic strings from Tag calls
When #36281 gets merged, the `TagSystem` methods will all give warnings. Let's fix those warnings before they even happen!
* Adds missing libraries
* Remove not yet implemented TagSystem changes
* Fix tag spelling error
Genuinely surprised there was only 1!
* Styling and proper type changes
* Styling
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Prevents admin ghosts from being shown with ghost event
* Changes summon ghost tooltip to permanently visible
* Adds AllowGhostShownByEvent tag, adds it to regular observers, removes ghost hands check & revenant check and replaces it with a tag check.
* Update MoverController.cs
* Update a bunch of movement code to use Entity<T>
* Last errors
* wow, there were more errors
---------
Co-authored-by: plykiya <plykiya@protonmail.com>
* Brings over changes from the original magic refactor PR
* Adds Master Spellbook, spellbook categories, WizCoin currency, and locale
* Wiz€oin™
* Adds currency whitelist to Spellbook preset, grants contained actions on action added.
* Adds grant contained action and remove provided action.
* adds a way for actions to be upgraded to the store
* Adds Fireball 3 and fixes action upgrade logic so that it checks if the action can level or if the action can upgrade separately
* Fixes upgrade logic in ActionUpgradeSystem to allow for level ups without an actual upgrade. Fixed action upgrade logic in store system as well
* Removes current action entity from the bought entities list and adds new or old action entity
* Removes Current Entity
* Removes old comments, fixes TransferAllActionsWithNewAttached
* Removes TODO
* Removes Product Action Upgrade Event
* reverts changes to immovablerodrule
* Removes stale event reference
* fixes mind action grant logic
* reverts shared gun system change to projectile anomaly system
* forgor to remove the using
* Reverts unintended changes to action container
* Adds refund button to the store
* Refreshes store back to origin.
* Refund with correct currency
* Init refund
* Check for terminating and update interface
* Disables refund button
* Removes preset allow refund
* dont refund if map changed
* adds refunds to stores
* Adds method to check for starting map
* comments, datafields, some requested changes
* turns event into ref event
* Adds datafields
* Switches to entity terminating event
* Changes store entity to be nullable and checks if store is terminating to remove reference.
* Tryadd instead of containskey
* Adds a refund disable method, disables refund on bought ent container changes if not an action
* Removes duplicate refundcomp
* Removes unintended merges
* Removed another unintended change from merge
* removes extra using statement
* readds using statement
* might as well just remove both usings since it won't leave the PR
* Fixes Action upgrades from stores
* Changes to non obsolete method uses
* Shares spawn code between instant and world
* Adds action entity to action event, adds beforecastspellevent, adds spell requirements to magic component
* puts prereq check in spell methods, sets up template code for before cast event
* checks for required wizard clothes
* Networks Magic Comp and Wizard Clothes Comp. Renames MagicSpawnData to MagicInstantSpawnData.
* Removes posdata from projectiles
* Speech > RequiresSpeech
* Fixes ActionOnInteract
* checks for muted
* popup for missing reqs
* Validate click loc for blink spell
* Checks if doors are in range and not obstructed before opening
* Check ents by map coords
* Adds speak event
* Comments spellbooks
* Removes comments
* Unobsoletes smite spell
* Invert if
* Requirements loc
* Fixes spell reqs
* Inverts an if
* Comment updates
* Starts doafter work
* Removes doafter references
* Balances fireball upgrades to be more reasonable
* Enables refund on master spellbooks
* Spells to do
* update spellbook doafter
* knock toggles bolts
* Touch Spell comments
* Comments for pending spells
* more comments
* adds spider polymorph to spellbook
* TODOs for spells
* reorganizes spellbook categories and adds wands
* fixes spacing and adds limited conditions
* commented owner only for future store PR
* reenables owner only for the grimoire
* fixes grimoire sprite
* Adds wizard rod polymorph
* summon ghosts event
* Moves rod form to offensive category
* Adds charge spell and loc for rod polymorph
* Oops forgor the actual chages
* Item Recall comment
* Fixes UI
* removes extra field for wizard rod
* Cleanup
* New Condition (INCOMPLETE)
* Fix linter
* Fix linter (for real)
* fixed some descriptions
* adds regions to magic
* Adds a non-refund wizard grimoire, fixes blink to deselect after teleporting, reduces force wall despawn time to 12 seconds
* removes limited upgrade condition
---------
Co-authored-by: AJCM <AJCM@tutanota.com>
* Add tests for ghost spawn position
* Make ghosts spawn immediately
* Format mind system
* Move ghost spawning to GhostSystem
* Spawn ghost on grid or map
This fixes the ghosts being attached the parent entity instead of the grid.
* Move logging out of the ghost system
* Make round start observer spawn using GhostSystem
* Move GameTicker ghost spawning to GhostSystem
Moved the more robust character name selection code over.
Moved the TimeOfDeath code over.
Added canReturn logic.
* Add overrides and default for ghost spawn coordinates
* Add warning log to ghost spawn fail
* Clean up test
* Dont spawn ghost on map delete
* Minor changes to the role test
* Fix role test failing to spawn ghost
It was failing the map check due to using Nullspace
* Fix ghost tests when running in parallel
Not sure what happened, but it seems to be because they were running simultaneously and overwriting values.
* Clean up ghost tests
* Test that map deletion does not spawn ghosts
* Spawn ghost on the next available map
* Disallow spawning on deleted maps
* Fix map deletion ghost test
* Cleanup
