Голубь
c86c92c5cf
update namespace for shared ghost folder ( #45095 )
...
a
2026-08-03 07:16:25 +00:00
Winkarst-cpu
c58331c4f3
Prediction + Refactor: BibleSytem ( #44800 )
...
* Prediction
* Update
* Update
* Fix
* Rename file
* Fix
* Update
* Fix
* cleanup
* EntityUid? Source
* Revert "EntityUid? Source"
This reverts commit c169e1f030b1fced6951b8026dda8f4e01571424.
* ftl and fix PVS
* Update
* review
* Update
---------
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
2026-07-22 21:03:36 +00:00
ShadowCommander
2cfc6f1988
Replace usages of AttachToGridOrMap with TryGetGridOrMapCoordinates ( #27951 )
...
* Rename TryGetMapOrGridCoordinates to make it clearer it gets grid first
* Replace AttachToGridOrMap with spawning directly to map or grid
* Fix a typo
Signed-off-by: Connor Huffine <chuffine@gmail.com>
* Remove uneccessary attachment
Signed-off-by: Connor Huffine <chuffine@gmail.com>
* Force full test refresh
---------
Signed-off-by: Connor Huffine <chuffine@gmail.com>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
Co-authored-by: Connor Huffine <chuffine@gmail.com>
2026-07-19 22:18:50 +00:00
Whatstone
9b29477f87
Cleanup: remove more redundantly defined EntitySystem members ( #44470 )
...
* redundant members
* catch IonLawSystem instances
* return the ion law sawmill, fix LogMan instances
* SalvageSystem LogManager inst
* IonLawSystem: public Sawmill
* what even is initialization order?
2026-07-02 19:12:23 +00:00
Whatstone
f42f8df6d1
Cleanup: ProtoMan Part 2 - remove Client and Server EntitySystem IPrototypeManager instances ( #44416 )
...
* Remove all IPrototypeManager instances
* Remove redundant IComponentFactory instances too
* Found some stragglers
* DestructibleSystem.PrototypeManager: no dependency
* not based
2026-06-29 21:33:56 +00:00
Eveloop
22a547c7c8
Use dependency injection for EntityQuery<T>s in Content.Server ( #43566 )
...
* Replace usages of EntityQuery with dependency injected ones in Content.Server
* Remove unused EntityQuery dependencies
* Restore CheckPressureAndFire override method
* Revert EntityQuery refactor changes to DisposalTubeSystem.cs & DisposableSystem.cs
* Infer Transform/Metadata directly instead of passing (#43479 )
* Resolve RA0049, RA0051 errors (#43479 )
* Resolve RA0049, RA0051 errors (#43479 )
* Apply suggestions from code review
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-05-17 15:59:37 +00:00
Pieter-Jan Briers
5168b5f3d4
IoC source gen compatibility ( #43863 )
...
* IoC source gen compatibility
Can be merged before or after https://github.com/space-wizards/RobustToolbox/pull/6549 doesn't really matter.
* Missed a spot
2026-05-09 03:29:58 +00:00
Errant
b692b6e33e
Antag Rolebans ( #35966 )
...
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com>
2025-09-17 23:59:07 +02:00
Pieter-Jan Briers
0c97520276
Fix usages of TryIndex() ( #39124 )
...
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115 )
This then resulted in TryIndex() getting modified to log errors (94f98073b0#39098 )
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-09-09 18:17:56 +02:00
slarticodefast
2743dcf67f
Move mind role components to shared ( #39606 )
2025-08-13 12:51:46 +02:00
Kyle Tyo
83b3e9e15a
Localize makesentient command. Move makesentient method to mind system. ( #38565 )
...
* praying pjb doesn't smite me for this 🙏
* requested changes
* Update makesentient-command.ftl
* verin commith and verin taketh away
2025-07-23 14:29:46 +02:00
Quantum-cross
989338cb08
Fix lingering ghost roles (and expand tests to catch it) ( #38788 )
...
* Improve and expand `TakeRoleAndReturn` to fail on bug #38292
* fix #38292 and expanded test cases
* use validated EntProtoIds for tests
remove unusued using declarations
* use const strings that match the TestPrototypes
2025-07-09 13:07:41 +02:00
Tayrtahn
75db49f9c0
Clean up all missing EntitySystem proxy method uses ( #38353 )
2025-06-26 16:50:49 -07:00
Errant
46d58bf22a
Role Types ( #33420 )
...
* mindcomponent namespace
* wip MindRole stuff
* admin player tab
* mindroletype comment
* mindRolePrototype redesign
* broken param
* wip RoleType implementation
* basic role type switching for antags
* traitor fix
* fix AdminPanel update
* the renameningTM
* cleanup
* feature uncreeping
* roletypes on mind roles
* update MindComponent.RoleType when MindRoles change
* ghostrole configuration
* ghostrole config improvements
* live update of roleType on the character window
* logging stuff and notes
* remove thing no one asked for
* weh
* Mind Role Entities wip
* headrev count fix
* silicon stuff, cleanup
* exclusive antag config, cleanup
* jobroleadd overwerite
* logging stuff
* MindHasRole cleanup, admin log stuff
* last second cleanup
* ocd
* move roletypeprototype to its own file, minor note stuff
* remove Roletype.Created
* log stuff
* roletype setup for ghostroles and autotraitor reinforcements
* ghostrole type configs
* adjustable admin overlay
* cleanup
* fix this in its own PR
* silicon antagonist
* borg stuff
* mmi roletype handling
* spawnable borg roletype handling
* weh
* ghost role cleanup
* weh
* RoleEvent update
* polish
* log stuff
* admin overlay config
* ghostrolecomponent cleanup
* weh
* admin overlay code cleanup
* minor cleanup
* Obsolete MindRoleAddedEvent
* comment
* minor code cleanup
* MindOnDoGreeting fix
* Role update message
* fix duplicate job greeting for cyborgs
* fix emag job message dupe
* nicer-looking role type update
* crew aligned
* syndicate assault borg role fix
* fix test fail
* fix a merge mistake
* fix LoneOp role type
* Update Content.Client/Administration/AdminNameOverlay.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/Roles/SharedRoleSystem.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* comment formatting
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* change logging category
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* fix a space
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* use MindAddRoles
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* get MindComponent from TryGetMind
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* move var declaration outside loop
* remove TryComp
* take RoleEnum behind the barn
* don't use ensurecomp unnecessarily
* cvar comments
* toggleableghostrolecomponent documentation
* skrek
* use EntProtoId
* mindrole config
* merge baserolecomponent into basemindrolecomponent
* ai and borg silicon role tweaks
* formatting
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* I will end you (the color)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* use LocId type for a locale id
* update RoleEvent documentation
* update RoleEvent documentation
* remove obsolete MindRoleAddedEvent
* refine MindRolesUpdate()
* use dependency
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* inject dependency
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* roleType.Name no longer required
* reformatted draw code logic
* GhostRoleMarkerRoleComponent comment
* minor SharedRoleSystem cleanup
* StartingMindRoleComponent, unhardcode roundstart silicon
* Update Content.Shared/Roles/SharedRoleSystem.cs
* remove a whitespace
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-01-11 22:17:26 +01:00
Leon Friedrich
4e0018697f
Add role prototype validation tests ( #32801 )
...
* Add role prototype validation test
* Rejig GetPrototypesWithComponent
* More tests n stuff
2024-10-14 14:05:25 +11:00
Errant
93c7bdc134
Mind Role Entities ( #31318 )
...
* Mind Role Entities wip
* headrev count fix
* silicon stuff, cleanup
* exclusive antag config, cleanup
* jobroleadd overwerite
* logging stuff
* MindHasRole cleanup, admin log stuff
* last second cleanup
* ocd
* minor cleanup
* remove createdTime datafield
* now actually using the event replacement I made for role time tracking
* weh
2024-10-10 10:48:56 +02:00
poeMota
9a51d37d02
Add ERT time stats ( #31629 )
...
* add jobs for ghost roles
* add job to ToggleableGhostRole
* typo
---------
Co-authored-by: Mota <belochuc@gmail.com>
2024-09-02 10:32:49 +05:00
Errant
40b9fd4ea3
Namespace cleanup around Mind Roles ( #30965 )
...
* namespaces
* Comment does not need a semicolon
---------
Co-authored-by: Vasilis <vascreeper@yahoo.com>
2024-08-15 20:26:57 +02:00
Errant
9de922adba
development build ghostrole lottery changes ( #30980 )
...
debug ghostrole lottery changes
2024-08-14 11:57:09 +10:00
Plykiya
aded74a88a
Syndicate Reinforcement Specializations: Medic, Spy, Thief ( #29853 )
...
* Syndicate thief, spy, medic
* Fixes description for nukies
* update description for uplink
* Implement the radial menu
* forgot these were necessary to push lol
---------
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-21 20:32:25 +10:00
metalgearsloth
03f0257ae9
Revert "Picking a ghostrole as an admin will now deadmin you. ( #29790 )" ( #29901 )
...
This reverts commit 1a50760e67
2024-07-11 17:04:10 +10:00
MFMessage
1a50760e67
Picking a ghostrole as an admin will now deadmin you. ( #29790 )
...
* @forcibly deadmins you
* Added checks for AdminDeadminOnJoin
2024-07-11 15:53:14 +10:00
Kara
993eef1e7c
Resolve 'EntitySystem.Get<T>()' is obsolete in content ( #27936 )
...
* PROJECT 0 WARNINGS: Resolve `'EntitySystem.Get<T>()' is obsolete` in content
* pass entman
* dog ass test
* webeditor
2024-05-12 20:34:52 -04:00
Kara
1596e04d0f
Resolve all non-obsoleting warnings in content ( #27934 )
...
* Resolve all non-obsoleting warnings in content
* Update ClientGameTicker.cs
* Update SkeletonAccentSystem.cs
* Update BwoinkSystem.cs
2024-05-11 20:13:58 -07:00
no
630a7a78ed
Add ghost role raffles ( #26629 )
...
* Add ghost role raffles
* GRR: Fix dialogue sizing, fix merge
* GRR: Add raffle deciders (winner picker)
* GRR: Make settings prototype based with option to override
* GRR: Use Raffles folder and namespace
* GRR: DataFieldify and TimeSpanify
* GRR: Don't actually DataFieldify HashSet<ICommonSession>s
* GRR: add GetGhostRoleCount() + docs
* update engine on branch
* Ghost role raffles: docs, fix window size, cleanup, etc
* GRR: Admin UI
* GRR: Admin UI: Display initial/max/ext of selected raffle settings proto
* GRR: Make a ton of roles raffled
2024-05-06 18:48:16 -07:00
Mr. 27
50fb91bd18
monkey reinforcement teleporters can now select between kobold or monkey with a verb ( #25982 )
...
* inital
* Update animals.yml
* Update animals.yml
* Update Content.Server/Ghost/Roles/Components/GhostRoleMobSpawnerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/Ghost/Roles/Components/GhostRoleMobSpawnerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/Ghost/Roles/Components/GhostRoleMobSpawnerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/Ghost/Roles/Components/GhostRoleMobSpawnerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/Ghost/Roles/Components/GhostRoleMobSpawnerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* selecting different role will change the description and name
* fix name
* gargh
* the review
Hello
* e
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-04-26 15:06:43 +02:00
Leon Friedrich
cb8f145975
Fix GhostRoleComponent performing randomization on ComponentInit ( #26466 )
...
* Fix ghostrole ComponentInit
* A
* a
2024-03-27 00:31:26 -04:00
LordCarve
05a2e6b3a2
Obsolete refactor - ConnectedClient to Channel ( #24409 )
2024-01-23 09:14:13 +11:00
Leon Friedrich
e685cb626b
Un-revert IPlayerManager refactor ( #21244 )
2023-10-28 09:59:53 +11:00
metalgearsloth
a2bbda43cc
Revert "Update submodule to 172.0.0 ( #21222 )" ( #21225 )
2023-10-24 21:55:20 +11:00
Leon Friedrich
7ba0ea2926
IPlayerManager refactor ( #21215 )
2023-10-24 20:19:08 +11:00
DrSmugleaf
f560f88eb5
Remove 700 usages of Component.Owner ( #21100 )
2023-10-19 12:34:31 -07:00
Kara
7dd20f7af1
Kill ComponentExt ( #20907 )
2023-10-11 20:19:46 +11:00
deltanedas
4fbebb6917
Roundstart antag role restrictions revival ( #20108 )
...
Co-authored-by: Ray <vigersray@gmail.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2023-09-20 17:54:53 +10:00
metalgearsloth
3c0439167a
Fix makeghostrole eui ( #19998 )
2023-09-11 14:31:45 +10:00
DrSmugleaf
3f3ba6ac62
Move minds, roles, jobs and objectives to shared ( #19679 )
2023-08-30 21:46:11 -07:00
DrSmugleaf
15c0211fb2
Refactor minds to be entities with components, make roles components ( #19591 )
...
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
2023-08-28 16:53:24 -07:00
metalgearsloth
0b542098db
Remove ghost compref ( #19478 )
2023-08-25 18:50:46 +10:00
Leon Friedrich
9fc4fc6ac2
Fix some Mind ECS bugs ( #17480 )
2023-06-20 14:29:26 +10:00
ShadowCommander
dd7032a860
Mind ECS ( #16826 )
2023-06-19 04:33:19 +10:00
metalgearsloth
56c10b503c
Don't show paused ghosts in window ( #17188 )
2023-06-10 22:24:34 +10:00
DrSmugleaf
9146374e39
Remove ghost role component references ( #15262 )
2023-04-12 23:32:14 +10:00
Leon Friedrich
4d71b1b81e
Revert "Mind ecs" ( #14881 )
2023-03-27 08:24:00 +11:00
ShadowCommander
bfc4da9377
Mind ecs ( #14412 )
2023-03-26 14:31:13 -04:00
Jezithyr
eeb5b17b34
Mobstate Refactor ( #13389 )
...
Refactors mobstate and moves mob health thresholds to their own component
Co-authored-by: DrSmugleaf <drsmugleaf@gmail.com>
2023-01-13 16:57:10 -08:00
Kara
c9d9d09e19
Ghost role probability ( #9752 )
...
* Ghost role probability
* give it to regular ticks/bears too
2022-07-15 15:20:37 +10:00
metalgearsloth
a2a5df1990
Damage masks ( #9402 )
2022-07-06 17:58:14 +10:00
wrexbe
1e0babbd50
Make AdminLogsSystem an IoC manager ( #8492 )
...
* Make log not entity system
* Fixes
2022-05-28 23:41:17 -07:00
wrexbe
bc68ac96dd
Cleanup the namespaces ( #8132 )
2022-05-13 17:59:03 +10:00
ike709
a9c18acd35
Remove misc Startup/Shutdown overrides ( #8113 )
...
Co-authored-by: ike709 <ike709@github.com>
2022-05-12 21:11:50 +10:00
