* ports chat follow function from AL and removes PJB implementation
forgor to commit earlier so it's just one chunk
* fixes accidental MiscTab.xaml restructuring
* fix name color
* remove unused function
* cvar summary
* typo
* accidental doc removal
* fix test fail
* fix test fail
* like i said first pr :|
* inject in constructor
* adds chat links to Local, Whisper, LOOC and Dead Chat respects Admin ghost privacy
* i hate chat code
* remove cvar
* single events file
* adds CanGhostWarp back
* filter for admin ghosts
* move tag
* remove ChatLinkTag.cs
* fix speechbubble rendering
* i want to bash my brain in
* kill chatcode
* formatting
* testfail
* still not working
* atleast deadchat works now
* even prettier TextLinkTag.cs
* fix speechbubble rendering for looc
* docs
* renaming and better docs
* Revert "remove cvar"
This reverts commit 1acb168f
* final changes (hopefully)
* requested changes
* can't parse -
* change TextLinkTag again
* formatting and typo
Co-authored-by: Connor Huffine <chuffine@gmail.com>
* quickfix
* no logging for now actually
* i will work on this in the morning
* restructuring
* wip
* final restructuring and docs
* still not done btw
* review
* docfix
* actually we can filter for admin ghosts
* doc
* fix color
* fix fix color
* review
* all I care to clean up
* bold names
* doc
* admin warp
* fixed
* fsaasffsa
* GOD ONCE SAID: GOOD ENOUGH
* they call me the shuffler
* admin chat links
* forgor newline
* fix?
* actual fix
* dumb stuff
* chungus
---------
Co-authored-by: Connor Huffine <chuffine@gmail.com>
Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
* refactor: extracted notify-on-non-functioning feature from emitter component
* refactor: revert server side PowerStateSystem usage of SubscribeLocalEvent - it is not calling base Initialize, skip SetWorkingState raising event on init
* refactor: ensureAPC is now conditional for powerstate
* refactor: fix double notifiation on destruction and on un-powering for emitter
* refactor: added LocTurnedOff for NotifyOnNonFunctioningComponent, fix double alert on destruction, removed emitter-deconstructed-broadcast as it is unused (cannot deconstruct withou unanchor)
* refactor: modernize server PowerStateSystem subscription
* refactor: update and modernize PowerStatePrototypeTest
* refactor: give APE specific radio message upon unlocking
* refactor: extracted PowerStateSystem.SetPowerLoad to split init from triggering is-working change event
* Update Content.Server/Power/EntitySystems/PowerStateSystem.cs
---------
Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com>
* radiosystem is funny
* review
Co-authored-by: slarticodefast <slarticodefast@users.noreply.github.com>
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
* dont forget your tests
* dont forget your loc
* networking
Co-authored-by: Tayrtahn <Tayrtahn@users.noreply.github.com>
* dont return because its breaks
* uh
* review
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
* more predictions and cleanup
* refactor: just me, being picky about whitespaces and commetns formatting
---------
Co-authored-by: slarticodefast <slarticodefast@users.noreply.github.com>
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
Co-authored-by: Tayrtahn <Tayrtahn@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
Co-authored-by: Fildrance <fildrance@gmail.com>
* Remove all IPrototypeManager instances
* Remove redundant IComponentFactory instances too
* Found some stragglers
* DestructibleSystem.PrototypeManager: no dependency
* not based
* jaws of death
* I hate YAML
* open the gate
* I forgot about this one
* I forgor
* Fix croissant
* this didn't work actually rip
* made lights look better and undo on the boxing gloves
* small change
* Update Resources/Prototypes/Entities/Clothing/Hands/gloves.yml
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
* baguette contraband, eat your evidence.
* suffix
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
* cleanup
* fix fixtures
* this belongs into the next PR
* review
* misc
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* stop jammer from jamming radio of certain frequency
* xenoborg jammer no longer jamms xenoborg radio
* stop jammer from jamming device network signals from certain frequency
* xenoborg jammer no longer jamms xenoborg camera signal
* the old tale of the missing ;
* backwards
* fix issue with readonly
* comments to the frequencies excluded
* triple typo
* clearer summary
* add summary
* fixed 4th hidden typo
* move all the radio components and system to Shared.
* duh split impl
* address reviews
* cleanup
---------
Co-authored-by: walksanatora <walkerffo22@gmail.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* parrots have ears. add poly
* high tech parrot functionality
* adjust times
* add accent to radio message
* don't spam everything all at once probably
* learn about the existence of prob(float)
* actually use Prob(float) correctly
* newline
* add pet spawner for poly
* move chance to talk on radio to component
* missing comment
* minor edits and doc additions
* the reviewerrrrrrr
* parrot can't learn when crit or dead
* increase default memory
* rename poly to polly
* crude way to ignore whispers. chatcode please
* This is Polly. It is set to broadcast over the engineering frequency
* add missing initialize
* add displacement map for parrot ears
* review comments - Errant
* minor things
* large rework
* fix attempting to talk when entity has no channels
* use list of active radios again to track channels
* fix bad return, some comments
* fix long learn cooldown
* minor adjustments
* use FromMinutes
* the voices told me to make these changes
* remove default reassignment
* Review changes
* remove polly's accent
* decouple radio stuff from parrotsystem
* minor stuff
* split vocalization and parroting
* minor review work
* re-add missing check
* add admin verb for clearing parrot messages
* minor action icon update
* oops
* increase icon number text size
* Admin erase parrot messages associated with players
* part 1 beck review
* add whitelist and blacklist for parrots
* Downgrade missing component error to warning
* Add comment
* add some missing comments
* Remove active radio entity tracking, use all inventory slots
* Minor changes
* small review stuff
* review radio stuff
* swap ears displacement to invisible death displacement
* remove syncsprite
* vscode why do yo have to hurt my feelings
* review changes
* use checkboth
* Predict dumping
- This got soaped really fucking hard.
- Dumping is predicted, this required disposals to be predicte.d
- Disposals required mailing (because it's tightly coupled), and a smidge of other content systems.
- I also had to fix a compnetworkgenerator issue at the same time so it wouldn't mispredict.
* Fix a bunch of stuff
* nasty merge
* Some reviews
* Some more reviews while I stash
* Fix merge
* Fix merge
* Half of review
* Review
* re(h)f
* lizards
* feexes
* feex
* Power stuff
- Add shared IsPowered
- Add shared ResolveApc
- Move PowerChangedEvent to shared for now
- Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it.
* big update
* boing
* Added selectable power level to radio jammer
* Cleaned up OnGetVerb
* Settings are now stored in the .yml file. Simplified stuff a lot!
* Minor fixes!
* Small little baby fix :)
* Added the power level switch to the examine menu and also removed the ftl file as it was in the incorrect location.
* Minor code cleanup
* Changed byte -> int
* Update sprite
* Fixed licence
* Added power LED that changes if the jammer is on low power.
* Removed tabs
* Changed github link to the commit
* Changed all the RemComp to RemComDeferred
* Moved NetworkedComponent to shared
* Changed radio jammer textures back with minor edits
* Added a space because it was annoying me
* Jammer now updates range for suit sensors properly! Thanks nikthechampiongr :)
* Removed useless comment
* Cleaned up code that updates the range of tracking devices.
* Fixed client namespace and removed newline
* Cleaned up ChangeLEDState and ChangeChargeLevel.
* Added comments
* Read only
* Fixed another comment
* Locked in
* Made server inherit shared
* Update Content.Shared/Radio/EntitySystems/SharedJammerSystem.cs
* Update Content.Shared/Radio/EntitySystems/SharedJammerSystem.cs
* review fixes
---------
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
As it turns out, they are not in fact on their own netid. They are
actually just on wireless. The way I had tested my previous pr led to
this mistake being made. I originally had the radio jammer block
wireless as well, but decided to take out under the flase assumption
that it suit sensors were actually on their own netid and did not
require the ability to block all wireless packets at the last moment.
* Add DeviceNetworkJammerComponent & System
Allows for entities to "jam" DeviceNetwork packets.
Whenever a device attempts to send a packet, the
DeviceNetworkJammerSystem listens for the BeforePacketSentEvent.
From there if any entity with the jammer component is within range of
either the sender or receiver of the packet the event will be cancelled.
Additionally jammers can only block packets in certain networks. If a
packet is not being transmitted in one of the networks it can block then
even if the jammer is in range the event will not be cancelled.
The range is stored in the jammer component along with the networks it
can jam.
Jammable network ids are stored as strings which seems to be how custom
networks are stored (E.g. network ids for suit sensors).
To allow for all of this, the BeforePacketSentEvent was modified to
provide the NetworkId.
* Make JammerSystem for the radio jammer use the DeviceNetworkJammer. Remove redundant event.
* Replace calls to TryDistance with InRange
* Make radio jammer block suit sensors
* Fix stupid
Use CancellableEventArgs instead of doing what the hell I was doing before.
* Address Reviews.
Change the event from a CancellableEntityEventArgs to a ByRefEvent.
* Implemented electricity speech verb masking
* Handle speech verb override elsewhere in the system, even though we're not using it
* Fix that protoId business
* No nullable component fields
* Use ProtoId, and try going back to a nullable.
Specifiy DataFields on VoiceMaskComponent.
* Initial prediction
* new group handling
* groups for all examines that use multiple rn
* compile
* why was it doing this??
* handle newlines with sorting properly
