Commit graph

175 commits

Author SHA1 Message Date
Whatstone
07f97fffa6
Cleanup: Resolve/suppress many obsolete warnings, delete EntityPrototypeHelpers. (#46141)
* Resolve warnings, mostly obsolete

* resolve via the entitymanager directly, not wref

* Ent<T>, why not

* minimize test diff

* StorageTest: consistent print order

* ChameleonProj: use Disguised value consistently

* GasArrayTest: TryComp

* OrganPickingMarker: cache ILocalizationManager

avoids warning from Loc.TryGetString, and avoids multiple IoCManager hits

* FormattedMessage.FromMarkup to FromMarkupOrThrow

* rerun tests 🙏
2026-10-05 01:58:03 +00:00
TheShuEd
6a93e3150b
ActionContainer null exception fix (#46195)
Update ActionContainerSystem.cs
2026-09-27 03:04:24 +00:00
ScarKy0
eefa7073c7
Changeling Fleshtomb (#45851)
* init

* make it proper

* listing, random humanoid appearance to shared

* oops

* moar

* pre-pr cleanup

* examine change

* partial review

* ye

* comment

* examinable

* sounds

* TrapInContainer >>>>>

* textures

* ambience

* fix

* Change collection to use leftclicking

* last minute balance change fuck everything

---------

Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2026-09-24 12:31:06 +00:00
ScarKy0
040d28fb9d
Start slug stasis after taking a corpse (#46138)
yay
2026-09-23 13:19:14 +00:00
Whatstone
a023e5784c
Cleanup: Remove byte order markers from most files (#45796) 2026-09-17 23:23:54 +10:00
ScarKy0
5e5388c9b3
Small ActionRequirements Fix (#46048)
john peak
2026-09-16 14:45:15 +00:00
ScarKy0
1cdf296bb6
Action Requirements (#46029)
* FAILURE

* oh it was that easy

* actually this is how its supposed to be yeah

* remove mobstate and satiation

* replacements

* cleaner

* discord remarks

* refactor: extract ActionRequirementsSystem.DoCancel method, fix typo in ActionRequirementsComponent

* review

---------

Co-authored-by: Fildrance <fildrance@gmail.com>
2026-09-16 12:08:40 +00:00
Jessica M
6a9421f18a
remove all instances of  (ZERO WIDTH NO-BREAK SPACE) (#46040)
remove all instances of 
2026-09-15 20:48:08 +00:00
ScarKy0
91f73d94c4
Mark invalid actions as invalid (#45838)
* crazy

* another check
2026-09-06 18:09:02 +00:00
Whatstone
7dd382c492
Add a confirmation message to the regenerative stasis action (#45506)
* add a confirmation message to the stasis action

* ConfirmableAction: toggled/untoggled bools

* move string

* network fields

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
2026-08-21 06:21:03 +00:00
ScarKy0
091180655d
Changeling Chemicals (#45239)
* initially works i think

* yeah

* pulled these numbers outta my ass

* text

* silly

* fixy fix

* fix

* This sure is a videogame

* init test fuck everything

* sprites

* fix dirty

* query

* another query

* craftable changeling sting

* remove todo

* \n

* doc
2026-08-19 19:25:16 +00:00
KeTuFaisPiKiNut
e925a86dcd
EntityEffectActions can target the user. (#44245)
* epinephrine overdose !!!!! fleshmend!!!!

* antazine

* antazine yaml fail

* woops

* address things (build plz)

* REMOVE THE FUN!!!! KILL THE WHISMY!!!!

* i am stoopid i am stoopid

* modernized

* THIS IS ALL BS RAAAAAH

---------

Co-authored-by: nomdéraisonnablementlong <you@example.com>
2026-08-18 15:28:46 +00:00
AndrewFenriz
6dc1aae3f2
Refactor animal reagent/entity production (#45019)
* port 35190

* HungerProduction

* SolutionProducer

* update

* move to server

* small tweak for Shearable

* fix

* ProductionAttemptEvent

* EntityProducer

* update EggLayer

* EntityTable

* no more actions on EggLayer

* move popups to comp

* kill EggLayer

* new locale

* rename field

* upd

* SatiationType

* rename to SatiationProduction and lil docs

* EntityQuery

* more docs for god of docs

* small fix

* more queries
2026-08-16 19:15:52 +00:00
ScarKy0
00acae3b62
Changeling Regen Stasis (#45104)
* init

* fixes, ghosting

* i dont know man

* popups, slight rework, actually works now

* review

* failn't

* partial review

* new sprites

* cleanup

* fix

* fix multiple gasps, allow stasis when dead

* typo

* yeah

* yeah

* wuh

* merge master part 2

* sub attribute

* first try?

* renames

* network

* identity

* fix ts

* fix imports

* applying state check

* temp

* may god have mercy upon my soul

* stuff

* Revert "stuff"

This reverts commit de7ec9cb9f761f5cd954921a0efa495388634d30.

* Revert "may god have mercy upon my soul"

This reverts commit 3e1aa567d47e0576daa6ed420dad29b80c112a31.

* Revert "temp"

This reverts commit 501dd6d4f6fd22c466e4abb2a284212636123c4a.

* Revert "applying state check"

This reverts commit 3c211f0a54812797987c7ab93a9b140f66a9088d.

* fix

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-08-10 12:43:59 +00:00
AndrewFenriz
dd46064672
Unify blink and katana dash teleportation (also removed EnergyKatana system/component) (#45041)
* ActionRestrictions

* katana use ActionGrant/ItemActionGrant

* TeleportAction

* no more DashAbility

* no more TeleportSpell

* no more EnergyKatana

* cleanup

* fix whitelist and popup

* docs

* display recharge cooldown

* refactor: whitespace consistency!111

* Revert "display recharge cooldown"

This reverts commit 3b93b179

* popup for limited charges

* maybe fix

* no more CanUseCharge

* upd

* better?

* refactor: using _SharedPhysicsSystem for TeleportActionSystem collision detection + small refactoring

* refactor: xml-doc

---------

Co-authored-by: Fildrance <fildrance@gmail.com>
2026-08-09 12:27:08 +00:00
Голубь
c86c92c5cf
update namespace for shared ghost folder (#45095)
a
2026-08-03 07:16:25 +00:00
TheShuEd
07919e1ae2
Actions icons refactor (#44681)
* basic code porting

* prototypes port

* rendering update

* charge state

* helper

* fix

* forgotten one
2026-07-25 16:35:53 +00:00
beck-thompson
cb8cee5ea3
Cleanup DangerousAction (#44825)
cleanup
2026-07-21 07:37:37 +00:00
Whatstone
a88d2c5164
Cleanup: Resolve remaining PopupSystem warnings in Content.Shared (#44685)
* PopupClient to PopupEntity/Coordinates

* PopupPredictedX to PopupEntity/Cursor/Coordinates

* The rest of the damn owl

* nullability fixes

* Buckle cleanup

* cleanup, address PR comments

* ExecutionSystem: one popup method

* correct my filthy lies

* Apply most of ajcm's suggestions

* return user to SharedItemRecallSystem.cs

* Fix lingering Ensnarable broadcast popups

* targeted drain popups

* fix lingering untargeted Guardian popups

I read the comment on GuardianHostRecall.  Oops.

* target stethoscope popups

* fix the PDA vibration popup

* Fix target for encryption key removal popup

* anomaly scanner: args.User, not uid

* disposal unit comment, bcast pda vibration popup
2026-07-16 21:54:33 +00:00
Ewanderer
d2f4a5ec5a
Prevent a Microbomb Implant Action while pacified. (#44198)
* adding a dangerous action system to allow pacified to interject with harmful action. making the microbomb explosion a dangerous action, to stop pacified syndicats from being able to blow up themselves.

* simplified code.

* cleaning  up comments, making some slight adjustments based on feedback to performance.
2026-07-11 21:54:48 +00:00
Pok
61f98c14d3
Changeling reagent stings (#43805)
* Changeling-Stings

* update yml

* attempt failed dead

* sprite and ChangelingNeurodepressantSting

* Update changeling_catalog.yml

* merge

* update

* review

* review 2

* clean up, remove non-blind stings

* fix stuff

* lethal, cryogenic, hallucination + armblade  nerf

* validate deez

* a

* review

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-06-04 19:29:21 +00:00
Pieter-Jan Briers
5168b5f3d4
IoC source gen compatibility (#43863)
* IoC source gen compatibility

Can be merged before or after https://github.com/space-wizards/RobustToolbox/pull/6549 doesn't really matter.

* Missed a spot
2026-05-09 03:29:58 +00:00
slarticodefast
e7807e1126
Add FleetingClothingComponent (#43444)
* fleeting clothing

* empty containers
2026-04-12 13:15:38 +00:00
ArtisticRoomba
376f16504c
Content.Shared EntityQuery<T> dependency injection refactor (#43498)
* part 1

* second pass

* final fix

* last fix i swear

* an even bigger genius

* regex missed this

* should be all of em?

* oops

* yeah

* Revert "should be all of em?"

This reverts commit 4dd54d1b9a76977b4cf8d6008358e4dacdee6eb1.

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-04-11 21:30:36 +00:00
Pieter-Jan Briers
787330f5c6
v269.0.0 RT update - .NET 10 (#41855)
* Make ServerPackaging automatically get extra server assemblies

* Make the switch

* Use Content.Server.deps.json instead

* Remove debug

* Rewrite

Now recursively fetches dependencies from Content.Server

Only copies dependencies not covered by Robust

This removes the need to manually specify most of the dependencies, even the content ones!

Also look at runtime key properly to figure out the proper dll name.

This actually removes some assemblies that were duplicated between the main directory and assemblies (various Microsoft.Extensions stuff)

* Fix test compile errors when updating dependencies

Ran across this while updating dependencies on the RT .NET 10 update. Should be fine to merge immediately.

* More .NET 10 prep

* Convert to SLNX

Hell yeah

* slnx now has size-2 indents

* Update SLNX with new RT system

* Remove reference to RT test in toolshed test

* Remove accidental usage of transitive RT dependencies

* Move Robust project references to RobustApi

* Update solution file

* Fix warnings in pow3r

* Fix nullable warnings in integration tests

idk where these came from

* gitignore binlog files

* Fix transitive dependency warnings in Content.Benchmarks

* Update slnx

* Okay, the Robust API thing didn't pan out. New plan.

It apparently broke clean builds, as the dependencies aren't in the project asset list or something anymore. I tried to fix this, but it seems impossible to do without relying on .NET SDK internals, as there's no point in the NuGet graph walk process that seems cleanly extensible.

Instead let's just do the much dumber thing: a bunch of .props files for content to import. Hooray!

This also means that I have to go through and *explicitly* disable transitive dependencies everywhere in RT. This thankfully isn't too hard.

* Update RT to 269.0.0

* One last solution update

* Fix more data definition issues

* Update RT to 269.0.1

* Fix it again

---------

Co-authored-by: DrSmugleaf <drsmugleaf@gmail.com>
2025-12-22 01:24:24 +00:00
slarticodefast
a428130d45
Remove blacklist methods in EntityWhitelistSystem (#40932)
* replace blacklist methods

* VS is trolling me
2025-11-24 00:38:08 +00:00
B_Kirill
fd40888b0e
Cleanup warnings: CS0067, CS8509, CS8073 (#39770)
* Cleanup

* Bonus

---------

Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2025-09-23 15:11:29 +12:00
keronshb
f885075d2e
DoAfter support for Actions (#38253)
* Adds Action DoAfter Events

* Adds DoAfterArgs fields to DoAfterComp

* Adds a base doafter action

* Adds Attempt action doafter logic

* Adds doafter logic to actions

* Changes Action Attempt Doafter and action doafter to take in Performer and the original use delay. Use delay now triggers when a repeated action  is cancelled.

* Readds the TryPerformAction method and readds request perform action into the action doafter events

* Adds a force skip to DoAfter Cancel so we can skip the complete check

* Adds a Delay Reduction field to the comp and to the comp state

* Fixes doafter mispredict, changes doafter comp check to a guard clause, sets delay reduction if it exists.

* Cancels ActionDoAfter if charges is 0

* Serializes Attempt Frequency

* Comment for rework

* Changes todo into a comment

* Moves doafterargs to doafterargscomp

* Adds DoAfterArgs comp to BaseDoAfterAction

* Removes unused trycomp with actionDoAfter

* Replaces DoAfterRepateUseDelay const with timespan.zero

* Removes unused usings

* Makes SharedActionsSystem partial, adds DoAfter partial class to ActionSystem, moves ActionDoAfter logic to the SharedActionsSystem.DoAfter class

* Cleanup and prediction

* Renames OnActionDoAfterAttempt to OnActionDoAfter, moves both to Shared Action DoAfter

* Removes ActionAttemptDoAfterEvent and moves its summaries to ActionDoAfterEvent. Converts OnActionDoAfterAttempt into TryStartActionDoAfter

* Removes Extra check for charges and actiondoafters

* Sloptimization

* Cleanup

* Cleanup

* Adds param descs

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-09-08 12:55:13 +03:00
slarticodefast
d1916fa4d3
Revert "Fix: Untoggle removed actions" (#39776)
Revert "Fix: Untoggle removed actions (#39526)"

This reverts commit e90fac14eb.
2025-08-20 09:33:14 -07:00
Winkarst-cpu
e90fac14eb
Fix: Untoggle removed actions (#39526)
* Fix

* Update Content.Shared/Actions/SharedActionsSystem.cs

Co-authored-by: LaCumbiaDelCoronavirus <90893484+LaCumbiaDelCoronavirus@users.noreply.github.com>

---------

Co-authored-by: LaCumbiaDelCoronavirus <90893484+LaCumbiaDelCoronavirus@users.noreply.github.com>
2025-08-19 15:30:55 -07:00
DrSmugleaf
21eb662377
Fix ActionsSystem.IsCooldownActive always returning false if curTime is null (#39329) 2025-08-03 00:59:48 +02:00
Perry Fraser
1ee7dffe6d
fix: fix non-access checking EntityTargetActions (#38731) 2025-07-22 21:34:39 +02:00
Голубь
114ec579f5
JumpBoots Attempt №2 (#36862)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: unknown <wainzor1337@gmail.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
2025-07-07 21:19:28 +02:00
B_Kirill
7ea3120a07
Cleanup warnings: CS0414 (#38793)
Cleanup
2025-07-06 12:28:29 +02:00
Tayrtahn
75db49f9c0
Clean up all missing EntitySystem proxy method uses (#38353) 2025-06-26 16:50:49 -07:00
Tayrtahn
c1de936c4b
Forbid string literals for SharedActionsSystem methods (#38472)
Forbid string literals for SharedActionsSystem methods
2025-06-21 00:11:12 +02:00
slarticodefast
5a69b7e2fb
Merge stable into master (#38395) 2025-06-17 17:25:30 +02:00
slarticodefast
d25046461e
Fix SharedActionSystem spamming errors (#38358) 2025-06-17 15:18:13 +10:00
ScarKy0
4cc6cb95dc
Commands for adding and removing actions (#38317) 2025-06-16 13:25:44 +03:00
deltanedas
7aa1986209
fix dragon devour action (#37968)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-05-31 22:29:51 +02:00
DrSmugleaf
b86c1ea01d
Allow actions to specify if they want to rotate the user when targeting (#37958) 2025-05-30 08:56:16 -04:00
Princess Cheeseballs
f6c9ef344e
[Action Refactor Fix] Action blockers now work on Actions (#37948) 2025-05-30 00:30:26 -04:00
deltanedas
b3825dce97
action refactor proper ecs edition (#27422) 2025-05-28 15:52:11 -04:00
J
ded94ebc3d
Various sharedsystem spring cleaning (#36200)
* Various shared system warnings cleanup

* More shared system warnings cleanup

* Rearranging changes

* Using correct transform for unbuckle

* Small changes

* Revert buckle change

* Update Content.Shared/Ghost/SharedGhostSystem.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-04-21 20:40:31 +02:00
metalgearsloth
8ab0e59db6
Refactor disarms (#36546)
* Refactor disarms

- Move client stuff to shared
- Cleanup a bunch of stuff
- Ref events
- Fix the swing sound mispredict (I noticed it on target dummies).

* Revert this change

* minor review

* Rebiew

---------

Co-authored-by: Milon <milonpl.git@proton.me>
2025-04-19 11:38:22 +10:00
metalgearsloth
7d2ef2bd47
Action charges refactor (#33993)
* Action charges refactor

- Fixes the slight godmoding of baseactioncomponent.
- Gets back 1ms of server time.

* chorg

* Remove FrameUpdate

* Fixes

* More fixes

* Combine

* Fixes

* Updates

* weh

* Last fixes

* weh

* Fix naughty

* YAML fixes

* This one too

* Merge conflicts

* This thing

* Review

* Fix this as well

* Icon fix

* weh

* Review

* Review

* seamless

* Review
2025-04-18 13:45:48 +10:00
ActiveMammmoth
9fad86342f
Wizard Staff of Animation (#34649) 2025-02-12 23:46:02 -05:00
ScarKy0
bf6fd4d581
Wizard Item Recall Spell (#34411) 2025-02-08 16:56:08 -05:00
lzk
dc3a2f6d28
add StartDelay bool to actions (#33026)
* add StartDelay bool to actions

* forgot summary
2024-10-28 23:21:14 +01:00
keronshb
7168959929
Adds real-time charge & disabled action information to Actions (#31821) 2024-09-25 10:27:28 -04:00