Commit graph

11 commits

Author SHA1 Message Date
Morb0
92bd0148fe Merge remote-tracking branch 'upstream/master' into upstream-sync
# Conflicts:
#	Content.Server/Administration/Systems/AdminSystem.cs
#	Resources/Locale/en-US/chat/sanitizer-replacements.ftl
#	Resources/Prototypes/Entities/Structures/Power/Generation/Singularity/emitter.yml
#	Resources/Prototypes/StatusIcon/antag.yml
#	Resources/Textures/Clothing/Uniforms/Jumpskirt/security.rsi/equipped-INNERCLOTHING.png
#	Resources/Textures/Clothing/Uniforms/Jumpskirt/security.rsi/icon.png
#	Resources/Textures/Effects/speech.rsi/meta.json
#	Resources/Textures/Objects/Devices/nuke.rsi/nuclearbomb_deployed.png
#	Resources/Textures/Objects/Devices/nuke.rsi/nuclearbomb_exploding.png
#	Resources/Textures/Objects/Devices/nuke.rsi/nuclearbomb_timing.png
2024-02-17 12:43:04 +03:00
Pieter-Jan Briers
68ce53ae17
Random spontaneous cleanup PR (#25131)
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
2024-02-13 16:48:39 -05:00
Morb0
f5c44e5bd0 Merge remote-tracking branch 'upstream/master' into upstream-sync
# Conflicts:
#	Resources/Prototypes/Voice/speech_emotes.yml
#	Resources/Prototypes/typing_indicator.yml
#	Resources/ServerInfo/Guidebook/Science/Robotics.xml
#	Resources/Textures/Effects/speech.rsi/alien0.png
#	Resources/Textures/Effects/speech.rsi/alien1.png
#	Resources/Textures/Effects/speech.rsi/alien2.png
#	Resources/Textures/Effects/speech.rsi/alienroyal0.png
#	Resources/Textures/Effects/speech.rsi/alienroyal1.png
#	Resources/Textures/Effects/speech.rsi/alienroyal2.png
#	Resources/Textures/Effects/speech.rsi/blob0.png
#	Resources/Textures/Effects/speech.rsi/blob1.png
#	Resources/Textures/Effects/speech.rsi/blob2.png
#	Resources/Textures/Effects/speech.rsi/clock0.png
#	Resources/Textures/Effects/speech.rsi/clock1.png
#	Resources/Textures/Effects/speech.rsi/clock2.png
#	Resources/Textures/Effects/speech.rsi/default0.png
#	Resources/Textures/Effects/speech.rsi/default1.png
#	Resources/Textures/Effects/speech.rsi/default2.png
#	Resources/Textures/Effects/speech.rsi/guardian0.png
#	Resources/Textures/Effects/speech.rsi/guardian1.png
#	Resources/Textures/Effects/speech.rsi/guardian2.png
#	Resources/Textures/Effects/speech.rsi/holo0.png
#	Resources/Textures/Effects/speech.rsi/holo1.png
#	Resources/Textures/Effects/speech.rsi/holo2.png
#	Resources/Textures/Effects/speech.rsi/lawyer0.png
#	Resources/Textures/Effects/speech.rsi/lawyer1.png
#	Resources/Textures/Effects/speech.rsi/lawyer2.png
#	Resources/Textures/Effects/speech.rsi/machine0.png
#	Resources/Textures/Effects/speech.rsi/machine1.png
#	Resources/Textures/Effects/speech.rsi/machine2.png
#	Resources/Textures/Effects/speech.rsi/meta.json
#	Resources/Textures/Effects/speech.rsi/robot0.png
#	Resources/Textures/Effects/speech.rsi/robot1.png
#	Resources/Textures/Effects/speech.rsi/robot2.png
#	Resources/Textures/Effects/speech.rsi/slime0.png
#	Resources/Textures/Effects/speech.rsi/slime1.png
#	Resources/Textures/Effects/speech.rsi/slime2.png
#	Resources/Textures/Effects/speech.rsi/swarmer0.png
#	Resources/Textures/Effects/speech.rsi/swarmer1.png
#	Resources/Textures/Effects/speech.rsi/swarmer2.png
#	Resources/Textures/Effects/speech.rsi/syndibot0.png
#	Resources/Textures/Effects/speech.rsi/syndibot1.png
#	Resources/Textures/Effects/speech.rsi/syndibot2.png
#	Resources/Textures/Structures/Machines/microwave.rsi/meta.json
#	Resources/Textures/Structures/Machines/microwave.rsi/mw.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mw0.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mw_running_unlit.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mw_unlit.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mwb.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mwbloody.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mwbloody1.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mwbloodyo.png
#	Resources/Textures/Structures/Machines/microwave.rsi/mwo.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/chemcrate_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/command.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/command.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/electrical.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/engicrate_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/engineering.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/freezer.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/generic.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/hydro_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/hydroponics.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/medical.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/medicalcrate_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/o2.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/plasma.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/plastic.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/privatecrate_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/radiation.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/scicrate_secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/science.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/science.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/science.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/science.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/science.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/science.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/sec_gear.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/secure.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/surgery.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/syndicate.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/syndicate.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/syndicate.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/syndicate.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/syndicate.rsi/welded.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/base.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/closed.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/icon.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/locked.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/meta.json
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/open.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/unlocked.png
#	Resources/Textures/Structures/Storage/Crates/weapon.rsi/welded.png
2023-08-13 05:40:29 +03:00
Nemanja
be29cda183
make typing indicators 32x32 (#18976) 2023-08-10 23:10:29 -06:00
Morbo
f989de7af5 Merge remote-tracking branch 'upstream/master' into upstream-sync
# Conflicts:
#	Content.Client/Chat/TypingIndicator/TypingIndicatorVisualizerSystem.cs
#	Content.Server/Chat/TypingIndicator/TypingIndicatorSystem.cs
#	Resources/Prototypes/Roles/Jobs/Science/scientist.yml
2023-02-05 03:01:05 +03:00
Visne
5a5a3afbb1
Remove some obsolete AppearanceComponent method usages (#13726) 2023-02-02 12:34:53 -04:00
Morb
a8f7ad8187
Fix typing indicator state (#745) 2023-01-14 12:08:46 -08:00
Morb
f26bb97ac6
Idle animated speech bubbles (#730) 2023-01-13 17:10:15 -08:00
Morb
76f8a7e91e
Lawyer badge changes typing indicator (#13445) 2023-01-12 23:33:57 +11:00
Leon Friedrich
1e9e93a33c
Fix typing indicator input validation. (#10818) 2022-08-25 23:44:43 +10:00
Alex Evgrashin
af926c5279
Typing indicator (typing chat bubble) (#8215) 2022-05-17 02:55:19 -07:00