Commit graph

789 commits

Author SHA1 Message Date
Голубь
c86c92c5cf
update namespace for shared ghost folder (#45095)
a
2026-08-03 07:16:25 +00:00
metalgearsloth
f90d927c48
Add job prio commands (#45057)
Useful for debugging with headless clients.
2026-08-01 15:43:27 +00:00
Pok
7a8fab78e3
Move Accents to Shared v2 (#44772)
* move-accents-to-shared

* Update AccentSystem.cs

* Update ListeningSystem.cs

* aaaaaa

* Update AccentSystem.cs

* oh god

* aaooao

* //

* review

* fix

* Update VocalSystem.cs
2026-07-25 22:29:39 +00:00
Stanislav
b22d38f9c0
Yaml audio params are often ignored (#36259)
* Replace WithVolume() with AddVolume(),
Remove AudioHelpers.WithVariation(),
Use specifier options for audio params

* Undo switching to AudioParams.AddVariation()

* Replace AudioHelpers.WithVariation with AudioParams.AddVariation()

* Test AudioParams.AddVariation() and change input parameters to sound like previous AudioHelpers.WithVariation()

* Fix build error

* Fix build error v2

* Remove DoAfter

* fixes

---------

Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
2026-07-25 16:16:23 +00:00
ShadowCommander
2cfc6f1988
Replace usages of AttachToGridOrMap with TryGetGridOrMapCoordinates (#27951)
* Rename TryGetMapOrGridCoordinates to make it clearer it gets grid first

* Replace AttachToGridOrMap with spawning directly to map or grid

* Fix a typo

Signed-off-by: Connor Huffine <chuffine@gmail.com>

* Remove uneccessary attachment

Signed-off-by: Connor Huffine <chuffine@gmail.com>

* Force full test refresh

---------

Signed-off-by: Connor Huffine <chuffine@gmail.com>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
Co-authored-by: Connor Huffine <chuffine@gmail.com>
2026-07-19 22:18:50 +00:00
SlamBamActionman
414e64db25
Move all accents into being RelayAccentSystems, add InventoryRelayedEvent support (#43008)
* Refactor accents a little

* Fix Linter

* Make T happy

* Aaaand fix linter

* Add RelayAccentsComponent

* Update into RelayAccentSystem

* Fix unnecessary override and slurred

* Fix some spacing and formatting

* Update a comment

* Review changes

* cleaning

* partial

* aoao

* destruction

---------

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
2026-07-19 00:51:54 +00:00
sleepyyapril
2ab5af4052
Color.TryFromHex returns a bool and outputs a color (#44581) 2026-07-18 10:38:13 +10:00
Rouden
4d0c40f358
Predict StationRecords (#40240)
* Make StationRecords YAML savable

* Update SharedStationRecordsSystem.cs

* Predict Station Records

* Attribute subs, query Resolve & DirtyFields

* Cleanup, prediction fixes, locale fixes

* Update GeneralRecordsUi.cs

Remove GeneralStationRecordConsoleState and obsolete SelectStationRecord
2026-07-17 03:36:39 +00:00
Samuka
e020c43454
Event log tool (#44655)
* button to new ui

* text box and button

* change size

* get the current round

* turn into a command

* fix round id not updating

* button to send log send message to server

* send message to discord

* use another cvar

* general fixes

* update event webhook

* use a place holder

* fix placeholder

* update button name

Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com>

* move to a separate folder

* turn into a fancy window

* add margin

* center text in the button

* move reset button to the left

* update the window

* move send button to the left

* update color

* remove indentation

* set sawmill inside PostInject

* remove random newline

* move PostInject to start of the class

* use darkViolet

* summary

* remove whitespace

* comment

---------

Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com>
2026-07-14 23:45:40 +00:00
Crude Oil
812fbd03af
Add functionality to select players when opening admin log UI (#44604)
* add user id to adminlogs command, allow opening logs for specific player

* replace ban list with opening player logs in ahelp window

* add entity logs verb

* make it less obvious I blatantly copied stuff from admin notes

* player log verb now actually working as intended

* use logic, not call command

* implement TryGetLastMind and TryGetLastMindOwner

* replace double condition with TryGetLastMind

* oops

* Apply suggestion from @AJCM-git

---------

Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com>
2026-07-14 20:57:10 +00:00
ScarKy0
722e18efc3
Predict stinky smite examine (#44563)
* Update AdminVerbSystem.Smites.cs

* Update GasMinerComponent.cs
2026-07-08 10:41:02 +00:00
Doru991
252b5f9b09
Make quick info links in the ahelp window more robust (#44373)
* Store last player whose mind was in container

* Send last player who controlled the entity's session ID along with other quick info

* No more spam

* Display last player info if there is no active player on entity

* Better looking separator

* Better looking separator but I didnt forget to ctrl s this time

* newline

* Address reviews

* cleaning

* Tiny tweaks

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: Connor Huffine <chuffine@gmail.com>
2026-07-08 08:32:08 +00:00
Samuka
e16a77768d
Stinky Smite (#44394)
* needs to be anchored datafield

* add verb

* improve description

* Use Captalization

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* remove redudant thing

* remove redudant check

* update examine text

* make stinkt person not show examine text of a gas miner

* Update Content.Shared/Atmos/Components/GasMinerComponent.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-07-02 22:18:14 +00:00
Whatstone
9b29477f87
Cleanup: remove more redundantly defined EntitySystem members (#44470)
* redundant members

* catch IonLawSystem instances

* return the ion law sawmill, fix LogMan instances

* SalvageSystem LogManager inst

* IonLawSystem: public Sawmill

* what even is initialization order?
2026-07-02 19:12:23 +00:00
Whatstone
f42f8df6d1
Cleanup: ProtoMan Part 2 - remove Client and Server EntitySystem IPrototypeManager instances (#44416)
* Remove all IPrototypeManager instances

* Remove redundant IComponentFactory instances too

* Found some stragglers

* DestructibleSystem.PrototypeManager: no dependency

* not based
2026-06-29 21:33:56 +00:00
MendaxxDev
004639bcdd
Fix admin logs being silently dropped in case of failure (#33278)
re-enqueue logs if update failed
2026-06-29 20:50:31 +10:00
slarticodefast
1a950f2b5c Merge branch 'newmaster' into master-merge 2026-06-28 11:06:16 +02:00
metalgearsloth
093fc24dda
Add AFK kicks back in (#44353)
* Add AFK kicks back in

Fixes the previous issues and also makes it a big window so users can close it / manually mark themselves as not being AFK now.

* review

* scar but im too lazy to apply suggestions and mess with commits

* sane minimums

* asd

* review

* augh

* Fix afk minimum + requested admin bump

* airhorn
2026-06-28 04:15:18 +00:00
riccardi48
95a5f7c7de
Table top prediction (#44348)
* TabletopSystem-move-to-shared

* final refactor

* Update TabletopHologramComponent.cs

* Update AdminVerbSystem.Smites.cs

* merge

* line

* prediction fix

* Fix the scrunkly

* Also noticed this

---------

Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2026-06-27 11:17:13 +00:00
MetalSage
80b63accb9
Fixing a Permissions vulnerability (#44071)
fix

Co-authored-by: MetalSage <metalsage.official@gmail.com>
2026-06-26 02:25:17 +00:00
Pieter-Jan Briers
c4e89e007e
Clarify clone/respawn/spawn here admin actions (#44333)
Fixes https://github.com/space-wizards/space-station-14/issues/44304
2026-06-23 00:52:36 +00:00
Pieter-Jan Briers
5dcfa51cf4
Fix quick info links not checking destination properly (#44331)
oops
2026-06-22 14:23:53 +00:00
Pieter-Jan Briers
4e9baf4698
Fix search cancellation handling in AdminLogsEui (#44329)
Hopefully fixes https://github.com/space-wizards/space-station-14/issues/44175
2026-06-21 22:57:48 +00:00
Pieter-Jan Briers
2f9b9a43ce
Reduce bwoink name match spam (#44325)
Word must now be at least 4 letters.
2026-06-21 21:41:34 +00:00
Axionyx
bad5a2bda6
Add trust score and account creation date to the player panel (#44317)
* Track account creation date and trust score in ContentPlayerData

* Fix local connection check

I feel like I'm overlooking an obvious way to more easily determine this but whatever

* Add trust score & creation date to the player panel

* Adress reviews

* Use IsLocal instead of magic string

Requires engige update

* Change trust thing to be not silly

Maybe a bit more complicated though? I dunno, I personally think this is more sane

* Revert "Track account creation date and trust score in ContentPlayerData"

This reverts commit 26b8df56

I am incredibly stupid and apparently did not look hard enough
2026-06-21 20:04:24 +00:00
Pieter-Jan Briers
d0a71c2a7d
Fix global bwoinks (#44322)
fuck me
2026-06-21 16:56:01 +02:00
Pieter-Jan Briers
37998d89ab
Bwoink "quick info" system for names (#44319)
This implements the SS13 feature where ahelps display a link to get quick info when a character name is mentioned.

Also just some cleanup of bwoink code cuz it sucks.
2026-06-20 23:29:24 +00:00
Whatstone
f339f58945
Replace all uses of System.Random with IRobustRandom, resolve all System.Random warnings. (#32)
* Remove all uses of System.Random

* Use IRobustRandom in BinomialNumberSelector.Get

* Remove remaining ToolRefinableSystem S.Random inst
2026-06-16 23:38:37 +00:00
Pieter-Jan Briers
3292e7759c
Fix string escaping in admin log TP links (#44290)
Why are we handrolling this shit ???
2026-06-13 21:52:12 +00:00
Samuka
61d5f0ea39
Slown down super bonk smite (#44223)
* make it 1.5 seconds

* empty commit
2026-06-03 16:39:20 +00:00
chromiumboy
2ca5d9d81a
Disposals refactor (#40540)
* Initial commit

* Added pods

* Transit tubes should no longer connect with disposal pipes

* Updated the transit tube sprites

* Revisited how the transit tubes work

* Fixing merge conflict

* Updated sprites

* Simplified disposal component collections and updated yaml

* Moved the majority of the disposals code to Shared

* Move disposed ents via physics

* Disposal unit now use generic visualizers

* Followers of disposed entities have predicted movement

* Made BeingDisposedSystem shared

* Added documentation for some components

* Code clean up

* Removed unneeded container entries, tubes use directions instead of angles

* Many EntityUid/Comp -> Entity<Comp> changes

* Updated DisposableSystem

* Review of DisposalTubeSystem

* Review of DisposalUnitSystem

* Review of DisposalSignalRouterSystem

* Unit updates

* Fixing merge conflict

* Merge conflict resolved

* Re-organization of systems and components

* Allow trapped entities to escape endless loops

* Fix for item ejection

* UI updates

* Minor tweak

* Fixes for transit tubes

* Removed placeholder sprite

* Removed transit tubes (for now)

* Moved exit stun time to DisposalHolderComponent

* Added a limit on the amount of damage that can sustained from disposals travel

* Fix for PVS-related sound issues

* Added a limit on the number of entities that can be inserted into units

* Clean up

* Undid file scoping

* Fixed test fail

* Fixed test fail

* Increased min default capacity of disposal units

* Fixed audio spam occurring when dumping multiple items into a disposal unit

* Tile prying now occurs whenever exiting an open pipe

* Prevent attacking and interactions while traveling through disposals

* Added generic verbs for entering/exiting disposal units

* Fixed UI prediction bug

* Bug fixes

* Small improvements

* Moved the disposal holder prototype from the disposal entry to the unit

* Minor clean up

* Added support for a disposal holder despawn effect

* Added prediction guard

* Test fail fix

* Re-added new escape behavior

* Removed outdated PVS code

* Clean up

* More escape behavior changes

* More clean up

* Updated exit selection logic

* Bug fix

* More clean up

* Split up disposal unit code

* Cleaned up disposal units some more

* Adjusted exit throw distance

* Capitalized disposal and mailing unit window titles

* Bug fixes

* Taggers and routers show existing tags when the UI opens

* Fixed test fail

* test fail fix

* Minor performance improvement

* Minor improvement in pathing

* merge conflicts

* Fix heisentest

* Fixed mispredict

* Updated system referencing conventions

* Updated to account for changes made to the code

* Attempting to fix submodule issue

* Addressing test fails

* Additional fixes for tests

* Addressing reviewer comments

* Cleaned up exit randomization

* T-ray can see disposal pipes when in 'pipe' mode

* Fix for flush animation flickering

* mild thing

* fix both

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-05-27 04:38:03 +00:00
Pieter-Jan Briers
5168b5f3d4
IoC source gen compatibility (#43863)
* IoC source gen compatibility

Can be merged before or after https://github.com/space-wizards/RobustToolbox/pull/6549 doesn't really matter.

* Missed a spot
2026-05-09 03:29:58 +00:00
Princess Cheeseballs
086479313f
Completely Rewrite Antag Selection Code to fix 1 bug but this time without breaking the game. Add Test For All Game Presets. (#43191)
* "fixes" it but the logic just needs to be rewritten.

* init commit

* almost there

* commit

* Scrounger

* actually spawn the ghost roles, and better assertion behavior!

* update the warning because I know someone is gonna touch it

* hhng

* fix Traitor assignment

* Prune the list and ignore dummy antags

* game test

* skip dummy antag

* crisaskjfshj

* It's time, it's fucking time

* fixing the secret gamemode bug once and for all.

* docs

* burger

* dssdgdsgds

* so hungry for test fails

* job whitelist

* review

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-04-25 09:20:56 +00:00
Princess Cheeseballs
ef3a0ecc2a
Solutions Refactor Part 1 - Solution Prototypes (#43412)
* Everything except the YAML slop...

* She solution on my manager till I sajfslkahfsjakfhaskjfshajksafhfsakhfasjfas

* another 1000 lines

* fix chem dispenser size

* go my shnelf

* Implicit ass

* rider is being mean for some reason

* dasdas

* borger

* better formatting go!

* clothes/bloodstream

* Cartons

* cups and bottles

* mmm soder

* bar drinks

* Spray bottles and some size tweaks with hindsight

* 99 bottles of beer on the wall I hate YAML

* push that shit

* mmm burger

* Sneed

* sheets

* condiments

* mmm yummy

* fridge yummyfood

* meat...

* sub 300

* burger...

* bready

* let them eat cake

* does she know how to make a grilled cheese?

* pizza pie!

* misc shit

* soup or salad

* Food and drinks, vanquished

* the cubes!!!

* Almost free from YAML...

* fix test fails and some yaml issues

* fix prediction, almost done

* fix all test fails

* remove master merge artifacts and undo autonetworking

* review and compatibility

* graaah

* unfuck master merge I hate github

* merg conflicts

* sfsa

* ehoop

* sadas

* afsafsaasf

* merge conflicts

* fucked up the merge conflicts

* merge conflict is fucked I might need to completely redo this branch

* test fail

* no calcium????

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-04-25 02:00:34 +00:00
Pok
d74f891288
AllCaps accent and refactoring (#43666)
* AllCapsStatusEffects

* refactor

* review

* two minor changes

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-04-25 01:59:28 +00:00
slarticodefast
7c60ea97e4
Fix banana creampie visuals, allow station AI to be pied (#43388)
* refactor and fixes

* fix ling transformation

* small fix

* Update Content.Shared/Nutrition/EntitySystems/SharedCreamPieSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
2026-04-03 18:16:17 +00:00
Simon
ef1169a079
Minor fixes to server api ban endpoint (#43355)
minor fixes to server api ban endpoint
2026-03-27 22:45:52 +00:00
Kyle Tyo
b03a72d0e7
DeleteComponentCommand minor cleanup/rename. (#43289)
commit
2026-03-18 17:40:14 +00:00
Simon
012ffe5abd
Add banning to server api (#43205)
add banning to server api
2026-03-12 18:40:47 +00:00
pathetic meowmeow
b2b547b806
Initial decoupling pass on Damageable (#43103)
* Initial decoupling pass on Damageable

* ope

* e

* mroaw

* ok sure on the medibot thing

* no medibot bounds

* okidooks

* arcryox era

* cryox moment
2026-03-07 04:13:50 +00:00
pathetic meowmeow
e361944ef6
Make DamageSpecifier serializable (#43049)
* pt1 damageable refactor

* fixes

* thusd unused

* sparse damagespecifiers

* fix thongs

* aaaaaa

* fix tests

* de-crash
2026-02-27 06:20:13 +00:00
Moony
04b4b7d51c
Non-obsoletion warnings as errors in Release. (#42983)
* Non-obsoletion warnings as errors in Release.

* Add two other obsoletions related to collection expressions.
These are not present in the codebase, but may become so in the future.

* Exempt NU1903 so the project can't mysteriously stop building.

* Fix some FULL_RELEASE mistakes.

* diff fix

* Resharper caught this one. Note to self: Wire up resharper to CI in another PR.
2026-02-23 21:07:22 +00:00
B_Kirill
2977d89f3e
Cleanup warnings: CS0168, CS0414, CS8321 (#42623) 2026-01-24 20:35:41 +00:00
Samuka
7c03f61e31
Admin log now shows who called or recalled evac (#41557)
* admin log now shows who called or recalled evac

* ops

* named parameters

* show in player search

* ops, forgot 2

* when did this happen?
2026-01-24 19:00:37 +00:00
Pieter-Jan Briers
29b7fc4463
Stable to master (#42599)
Ban database refactor (#42495)

* Ban DB refactor seems to work at a basic level for PostgreSQL

* New ban creation API

Supports all the new functionality (multiple players/addresses/hwids/roles/rounds per ban).

* Make the migration irreversible

* Re-implement ban notifications

The server ID check is no longer done as admins may want to place bans spanning multiple rounds irrelevant of the source server.

* Fix some split query warnings

* Implement migration on SQLite

* More comments

* Remove required from ban reason

SS14.Admin changes would like this

* More missing AsSplitQuery() calls

* Fix missing ban type filter

* Fix old CreateServerBan API with permanent time

* Fix department and role ban commands with permanent time

* Re-add banhits navigation property

Dropped this on accident, SS14.Admin needs it.

* More ban API fixes.

* Don't fetch ban exemption info for role bans

Not relevant, reduces query performance

* Regenerate migrations

* Fix adminnotes command for players that never connected

Would blow up handling null player records. Not a new bug introduced by the refactor, but I ran into it.

* Great shame... I accidentally committed submodule update...

* Update GDPR scripts

* Fix sandbox violation

* Fix bans with duplicate info causing DB exceptions

Most notably happened with role bans, as multiple departments may include the same role.
2026-01-23 15:34:23 +01:00
pathetic meowmeow
8cf744ec55
Visual nubody (humanoid appearance refactor) (#42476)
* initial visual nubody

* oops overlay

* im so pheeming rn

* conversion...

* tests

* comeback of the underwear

* oops eyes

* blabbl

* zeds

* yaml linted

* search and visible count constraints

* reordering

* preserve previously selected markings colors

* fix test

* some ui niceties

* ordering

* make DB changes backwards-compatible/downgrade-friendly

* fix things again

* fix migration

* vulpkanin markings limit increase

* wrapping

* code cleanup and more code cleanup and more code cleanup and more code cleanup and

* fix slop ports

* better sampling API

* make filter work + use the method i made for its intended purpose

* fix test fails real quick

* magic mirror cleanup, remove TODO

* don't 0-init the organ profile data

* remove deltastates

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-01-20 07:07:53 +00:00
pathetic meowmeow
d0c2734dad
Nubody (#42419)
* Nubody

* fix test fails

* gibbing

* lung test returns

* doc comment

* hand organ test

* giblet test

* yaml formatting

* returning

* relocate

* trimming

* re-smite

* oops thusd tweak

* arachnids have slower metabolism i guess

* never mind the old behaviour is bad actually

* rider whyyy

* style changes and allat

* fix collision

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-01-17 00:39:35 +00:00
pathetic meowmeow
fb133494cc
Decouple gibbing from the body system (#42405)
* Decouple gibbing from the body system

* allow gibs that don't drop giblets

* pass through user

* prediction gon

* comment

* destructible

* playpvs

* very very very very very very very minor cleanup

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-01-14 05:57:08 +00:00
mq
4920c9e907
Update (MOST) instances of EntityUid, Component in GunSystem to Entity<T> (#41966)
* Entity<T>, skipping Magazine and ChamberMagazine

* missed some

* AUGH!!

* ballistic examine

* dotnet hates me

* WHY ARE YOU CALLED THAT!!!!

* cheers aada
2026-01-01 19:00:49 +00:00
YoungThug
951f13fd69
Add antag control for the space ninja (#42133)
* Add antag control for the space ninja

* Remove whitespace

---------

Co-authored-by: beck-thompson <beck314159@hotmail.com>
2025-12-29 00:01:35 +00:00