Commit graph

5174 commits

Author SHA1 Message Date
Thomas
e5c6c88350
Fix Context Menus Not Orphaning Correctly (#44085)
The change to remove DisposeAllChildren in favor of RemoveAllChildren
didn't account for the fact that some controls have custom Dispose
behavior that wasn't getting triggered correctly.

I fixed it by switching it to ExitedTree + Orphan, which made it
magically work again
2026-06-29 22:19:21 +10:00
Whatstone
a8453723d8
Cleanup: ProtoMan Part 1 - remove Shared EntitySystem IPrototypeManager instances (#44386)
* Remove Shared System IPrototypeManager instances

* Remove RecipeManager IPrototypeManager instance

* Fix ItemSystem IPrototypeManager refs, use TryComp

* SharedItemSystem changes, EntWhitelist CompName

* HasComponent->HasComp
2026-06-29 10:18:44 +00:00
Xeri Marai
fcc7f9e7f8
Sprite Fade Overlay Restricted to overlapping clickables (#37907)
* Sprite Fade Overlay Restricted to overlapping clickables

* Added an IgnoreClickableRestrict for larger objects, and put it on Anomaly Generator as an example

* Adjusting fade changes based on review

* double for avoid

* {

* fsnjhjasfhfsajkasfhj

---------

Co-authored-by: jessicamaybe <jessica@jessicamaybe.com>
Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
2026-06-29 05:54:09 +00:00
Whatstone
898e1abe4b
Fix shuttle console distance printouts (#44246)
* ShuttleNavControl: sensible map coordinates

* Coords->Pos, ToWorldPosition vs. ToMapCoords.Posn
2026-06-29 00:05:44 +00:00
slarticodefast
1a950f2b5c Merge branch 'newmaster' into master-merge 2026-06-28 11:06:16 +02:00
metalgearsloth
093fc24dda
Add AFK kicks back in (#44353)
* Add AFK kicks back in

Fixes the previous issues and also makes it a big window so users can close it / manually mark themselves as not being AFK now.

* review

* scar but im too lazy to apply suggestions and mess with commits

* sane minimums

* asd

* review

* augh

* Fix afk minimum + requested admin bump

* airhorn
2026-06-28 04:15:18 +00:00
riccardi48
de842aace4
Moved dropped event to raise after dropped item is moved (#44372)
* init

* .
2026-06-28 04:02:10 +00:00
riccardi48
95a5f7c7de
Table top prediction (#44348)
* TabletopSystem-move-to-shared

* final refactor

* Update TabletopHologramComponent.cs

* Update AdminVerbSystem.Smites.cs

* merge

* line

* prediction fix

* Fix the scrunkly

* Also noticed this

---------

Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2026-06-27 11:17:13 +00:00
JustinWinningham
e25f9167d8
implemented sorting fix for admin menu (#43897) 2026-06-26 02:43:43 +00:00
Pieter-Jan Briers
0fe7decde5
Fix bwoink options on popped-out UI (#44334) 2026-06-23 18:02:40 +00:00
Whatstone
e36660ce0b
Bugfix: Fix DrawDepth subfloor gap width, add gap for mapping subfloor layers (#70) 2026-06-22 15:57:34 -04:00
Vladislav Suchkov
4dd1941c54
Construction menu recipe history (#8) 2026-06-22 11:04:30 -04:00
Pieter-Jan Briers
44ec5d1c26
Display admin logs in local timezone (#44332)
Fixes https://github.com/space-wizards/space-station-14/issues/44327
2026-06-22 14:29:50 +00:00
Pieter-Jan Briers
603325b6d5
admin_overlay command to toggle admin overlay from scripts (#44326)
Fixes https://github.com/space-wizards/space-station-14/issues/44318
2026-06-21 21:58:43 +00:00
Axionyx
bad5a2bda6
Add trust score and account creation date to the player panel (#44317)
* Track account creation date and trust score in ContentPlayerData

* Fix local connection check

I feel like I'm overlooking an obvious way to more easily determine this but whatever

* Add trust score & creation date to the player panel

* Adress reviews

* Use IsLocal instead of magic string

Requires engige update

* Change trust thing to be not silly

Maybe a bit more complicated though? I dunno, I personally think this is more sane

* Revert "Track account creation date and trust score in ContentPlayerData"

This reverts commit 26b8df56

I am incredibly stupid and apparently did not look hard enough
2026-06-21 20:04:24 +00:00
Pieter-Jan Briers
37998d89ab
Bwoink "quick info" system for names (#44319)
This implements the SS13 feature where ahelps display a link to get quick info when a character name is mentioned.

Also just some cleanup of bwoink code cuz it sucks.
2026-06-20 23:29:24 +00:00
InsoPL
a79f85248b
Directional arrow (#118)
* arrow

* yoink orginal arrow rsi

* done

* fixes

* i just learnd about ignored components

* Update Content.Client/DirectionalArrowIndicator/DirectionalArrowIndicatorComponent.cs

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>

* customArrows

* docs

* more docs

* teg and blue arrow

* misc

* fixes

* remove color

* imma dummy

* meta

* soon to obsolete

* class not partial

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
2026-06-20 21:45:43 +00:00
metalgearsloth
0bbf402b3f
Fix ItemGridPiece using invalid sprite bounds (#102)
It inverted bottom and top.
2026-06-20 00:19:05 +02:00
Jessica M
53ae66b7ce
Ambient Music fixes and tweaks (#28)
* reorganize yml

* medical and engineering marker components and mass marking

* bed

* increase cooldown

* did i leave that in
2026-06-18 22:51:41 -04:00
portfiend
5a9fa1ef67
Document Client, Server, and Shared files in folders starting with "K". Except microwaves. (#91)
* document the entire owl

* Apply suggestions from code review

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-06-18 18:41:56 +00:00
riccardi48
751123e7fb
Bring cargo order menu to the front when selecting a new item 2026-06-16 23:04:20 -04:00
Whatstone
f339f58945
Replace all uses of System.Random with IRobustRandom, resolve all System.Random warnings. (#32)
* Remove all uses of System.Random

* Use IRobustRandom in BinomialNumberSelector.Get

* Remove remaining ToolRefinableSystem S.Random inst
2026-06-16 23:38:37 +00:00
Pieter-Jan Briers
d3cb88cd74
Ghosts have follow buttons in chat (#44284) 2026-06-12 16:01:39 +00:00
Zekins
d7d72c1db8
Construction Cache Reload (#44243)
ConstructionReload
2026-06-05 15:06:30 +00:00
Whatstone
043c1d6b60
Remove instances of the broken Caution style class (#44244) 2026-06-05 15:02:16 +00:00
ArtisticRoomba
faa9ead594
Migrate Atmospherics to TensorPrimitives (#44139) 2026-06-02 12:52:50 -07:00
Kyle Tyo
86e4a27ef6
Random Borg blindness/dark vision (#44030)
Update DamageOverlayUiController.cs
2026-05-30 18:14:23 +00:00
slarticodefast
0e898c5339
Fix lightning beam rotation (#42342)
* fix lightning rotation

* RT 272 fixed this

* yaml conventions
2026-05-29 19:16:36 +00:00
Pok
e7edf44ed3
Predict ImplantsSystem (#43993)
* Implants-System-Predicted

* popup

* review

* cleanup

* I

* ftl

* fix test

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-05-28 18:09:47 +00:00
Lilith Ashley Nyx Arson
e9ee47f74c
Fix DamageVisuals not working on walls (#44116)
Update DamageVisualsSystem.cs

Fixes bug where the damage overlay is always bottom in the sprite order
2026-05-27 08:46:30 +00:00
chromiumboy
2ca5d9d81a
Disposals refactor (#40540)
* Initial commit

* Added pods

* Transit tubes should no longer connect with disposal pipes

* Updated the transit tube sprites

* Revisited how the transit tubes work

* Fixing merge conflict

* Updated sprites

* Simplified disposal component collections and updated yaml

* Moved the majority of the disposals code to Shared

* Move disposed ents via physics

* Disposal unit now use generic visualizers

* Followers of disposed entities have predicted movement

* Made BeingDisposedSystem shared

* Added documentation for some components

* Code clean up

* Removed unneeded container entries, tubes use directions instead of angles

* Many EntityUid/Comp -> Entity<Comp> changes

* Updated DisposableSystem

* Review of DisposalTubeSystem

* Review of DisposalUnitSystem

* Review of DisposalSignalRouterSystem

* Unit updates

* Fixing merge conflict

* Merge conflict resolved

* Re-organization of systems and components

* Allow trapped entities to escape endless loops

* Fix for item ejection

* UI updates

* Minor tweak

* Fixes for transit tubes

* Removed placeholder sprite

* Removed transit tubes (for now)

* Moved exit stun time to DisposalHolderComponent

* Added a limit on the amount of damage that can sustained from disposals travel

* Fix for PVS-related sound issues

* Added a limit on the number of entities that can be inserted into units

* Clean up

* Undid file scoping

* Fixed test fail

* Fixed test fail

* Increased min default capacity of disposal units

* Fixed audio spam occurring when dumping multiple items into a disposal unit

* Tile prying now occurs whenever exiting an open pipe

* Prevent attacking and interactions while traveling through disposals

* Added generic verbs for entering/exiting disposal units

* Fixed UI prediction bug

* Bug fixes

* Small improvements

* Moved the disposal holder prototype from the disposal entry to the unit

* Minor clean up

* Added support for a disposal holder despawn effect

* Added prediction guard

* Test fail fix

* Re-added new escape behavior

* Removed outdated PVS code

* Clean up

* More escape behavior changes

* More clean up

* Updated exit selection logic

* Bug fix

* More clean up

* Split up disposal unit code

* Cleaned up disposal units some more

* Adjusted exit throw distance

* Capitalized disposal and mailing unit window titles

* Bug fixes

* Taggers and routers show existing tags when the UI opens

* Fixed test fail

* test fail fix

* Minor performance improvement

* Minor improvement in pathing

* merge conflicts

* Fix heisentest

* Fixed mispredict

* Updated system referencing conventions

* Updated to account for changes made to the code

* Attempting to fix submodule issue

* Addressing test fails

* Additional fixes for tests

* Addressing reviewer comments

* Cleaned up exit randomization

* T-ray can see disposal pipes when in 'pipe' mode

* Fix for flush animation flickering

* mild thing

* fix both

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-05-27 04:38:03 +00:00
Errant
3b800c0e11
Merge stable into master (#44076)
[Hotfix] Fix MenuButton Missing Negative Style (#44073)

Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
2026-05-25 12:01:22 +02:00
Thomas
01a925da68
[Hotfix] Fix MenuButton Missing Negative Style (#44073) 2026-05-25 11:36:13 +02:00
riccardi48
07efab3976
Remove background box from main menu (#43977)
* Menu Change

* Change v2

* final change

* Format code

---------

Co-authored-by: Thomas (Aeshus) <git@aeshus.com>
2026-05-24 21:18:57 +00:00
piskaczek
a9f1fbaeb0
fix off by 1 in tips (#44062)
fix the thing the uhhhh the thing the thing ynow....   fix uhh the thing. the thing that needs fixing
2026-05-24 20:35:54 +00:00
Rami
add0e20b8c
Fix Barber Scissors not playing audio (#43922)
* Fix Barber Scissors not playing audio

* Add code comment

* Requested changes

* More requested changes thanks Warock

* Requested changes
2026-05-23 20:29:19 +00:00
Perry Fraser
b6479b8b21
Fix error texture for harmpack hand solution visuals (#39442)
* fix: check for inhand sprite's existence

* refactor: simplify solution container visuals code

this made my brain hurt but I think I didn't break anything
2026-05-22 20:47:14 +00:00
Princess Cheeseballs
70d5292694
Smarter Entity Targeting (#39571)
* Smart targeting

* use swidge statement

* Undo

* merge conflicts

* works well

* Better logic

* GO TO SLEEP

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2026-05-22 20:33:50 +00:00
AndrewFenriz
ab9d7efc36
Vehicle system: Movement & Buckling (#43525)
* Part one of Vehicles

* Also we need this

* And we need this

* We REALLY need this

* Little fix

* fixes (i'm tired)

* Apply suggestions from code review

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>

* update

* fixed

* just for cleaner diff

* just in case

* I think this might be cleaner

* small fix

---------

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
2026-05-21 23:37:18 +00:00
mq
cbf1047c55
Reduced AI static overlay checkbox for photosensitivity (#44003)
* option to reduce ai static overlay

* wrong file path!

* requested change
2026-05-20 19:31:54 +00:00
Pok
95cb9ab60d
Fix chat with open radial menu (#40929)
* chat-with-open-radial-menu

* refactor: reuse checks in RadialMenuContextualCentralTextureButton.KeyBindUp in relevant codeparts of radial menu

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2026-05-19 11:40:54 +00:00
Atakku
590dfe7d0a
Fix pipe placement (and possibly other things) in mappingclientsidesetup (#43301)
This simple fix, fixes everything
2026-05-18 23:09:11 +00:00
chromiumboy
af2d5d401a
Minor improvements for holopads (#40444)
* Initial commit

* Fixing merge conflict

* Merge conflict fixed

* Additional fixes

* Reverted change

* Serialization fix

* Holopad UIs will update when one is deleted or changes map

* Minor clean up

* Removed obsolete variables

* Addressed review comments
2026-05-18 13:23:41 +00:00
riccardi48
c264ec0a60
Default requester text in cargo request console from ID (#43938)
* Request text from ID

* Requested Changes

* Removed TryGetIdentityShortInfoEvent()

* Removed unused using

* cleanup

* .

* Wrong if statement

* Revert "Merge branch 'identity-getname-cleanup' into cargo-console-requester-id"

This reverts commit 89245a4f6445dac723b417e2c19e176b96bbdef5, reversing
changes made to d6ce7e03aee7da7470f170a570f99c3b68e18565.

* missed one

* whitespace

* .

* updated to match other PR

* Moved to Dependency

* added partial class

* Update Content.Client/Cargo/BUI/CargoOrderConsoleBoundUserInterface.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-05-17 16:38:39 +00:00
Eveloop
22a547c7c8
Use dependency injection for EntityQuery<T>s in Content.Server (#43566)
* Replace usages of EntityQuery with dependency injected ones in Content.Server

* Remove unused EntityQuery dependencies

* Restore CheckPressureAndFire override method

* Revert EntityQuery refactor changes to DisposalTubeSystem.cs & DisposableSystem.cs

* Infer Transform/Metadata directly instead of passing (#43479)

* Resolve RA0049, RA0051 errors (#43479)

* Resolve RA0049, RA0051 errors (#43479)

* Apply suggestions from code review

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2026-05-17 15:59:37 +00:00
Thomas
ee172f4fd2
Improve Main Menu (#43891)
* Format code

* Fix Changelog button having incorrect size

* Reorder Changelog to no longer be the last one

* Switch changelog and quit colors

It doesn't make sense for Quit to be uncolored, yet for Changelog to be
red. I'm not sure if positive green is the right color, but there's not
really a better option to do quickly/easily

* Shape the buttons using Open{Left,Right,Both}

I wish we got the new XAMLX already as doing the <system:String> thing
is uh... not desirable

* Add background to MainMenu and change some margins and separations
2026-05-16 18:56:40 +00:00
Thomas
0fc0362113
Randomize Main Menu Parallax (#43893)
* Random parallax

* Switch from enumerate to allow list

* Use ProtoId

* Validate

It's really been too long since I've done this kind of this, and it
shows...

* Update Content.Client/MainMenu/UI/MainMenuControl.xaml.cs

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2026-05-16 17:35:36 +00:00
Thomas
ee261e04d5
Improve Escape Menu (#43895)
* Format xaml

* Use correct styleclass for red quit button

* Use style classes to make the buttons align/connect
2026-05-16 17:09:29 +00:00
riccardi48
37f68fca61
Cargo order computer order cap is able to change (#43953)
fixed order cap
2026-05-16 16:07:33 +00:00
beck-thompson
5f37c95e9f
Admins can now see what items are contraband and chameleon in the strip menu (#43658)
* Admins can now see what items are contraband and chameleon in the strip menu

* Fix the color, the default is now red

* better admin view comment

* Simplify logic, make new simple slot overlay to combine logic

* Make isadmin logic a little clearer

* Minor cleanup / spelling mistakes

* change  button shape

* change to res path

* opps

* Add option to change default behavior

* Fix spacing

* Remove unused

* Rename to default

* Take away the soul of the overlay

* Add tooltip

* Fix error
2026-05-10 10:45:58 +00:00