CatStation/Content.Server/Teleportation/TeleportLocationsSystem.cs
opl- 9b3daeaf93
Fix teleport scroll teleporting into walls (#40815)
* Move Ulam spiral generator to its own class

* Make UlamSpiral.Point return a zero vector for n<=0

* Add UlamSpiral.PointsForMaxDistance

* Fix TeleportLocationsSystem can teleport user into a wall

Uses an Ulam spiral pattern to check for valid locations around the target entity.

* Handle teleportation failures more gracefully

* Fix unconventional name for delay system field

* Fix client crashes when target entity is paused/in nullspace

* Show popup when teleportation destination is obstructed

---------

Co-authored-by: opl <4833621+opl@users.noreply.github.com>
2026-07-31 17:47:17 +00:00

87 lines
3 KiB
C#

using Content.Server.Chat.Systems;
using Content.Shared.Chat;
using Content.Shared.Popups;
using Content.Shared.Teleportation;
using Content.Shared.Teleportation.Components;
using Content.Shared.Teleportation.Systems;
using Content.Shared.UserInterface;
using Content.Shared.Warps;
using Content.Shared.Whitelist;
namespace Content.Server.Teleportation;
/// <summary>
/// <inheritdoc cref="SharedTeleportLocationsSystem"/>
/// </summary>
public sealed partial class TeleportLocationsSystem : SharedTeleportLocationsSystem
{
[Dependency] private ChatSystem _chat = default!;
[Dependency] private SharedPopupSystem _popup = default!;
[Dependency] private EntityWhitelistSystem _whitelist = default!;
public override void Initialize()
{
base.Initialize();
SubscribeLocalEvent<TeleportLocationsComponent, MapInitEvent>(OnMapInit);
SubscribeLocalEvent<TeleportLocationsComponent, BeforeActivatableUIOpenEvent>(OnBeforeUiOpen);
}
private void OnMapInit(Entity<TeleportLocationsComponent> ent, ref MapInitEvent args)
{
UpdateTeleportPoints(ent);
}
private void OnBeforeUiOpen(Entity<TeleportLocationsComponent> ent, ref BeforeActivatableUIOpenEvent args)
{
UpdateTeleportPoints(ent);
}
protected override void OnTeleportToLocationRequest(Entity<TeleportLocationsComponent> ent, ref TeleportLocationDestinationMessage args)
{
if (IsDelayed(ent))
return;
if (!string.IsNullOrWhiteSpace(ent.Comp.Speech))
{
var msg = Loc.GetString(ent.Comp.Speech, ("location", args.PointName));
_chat.TrySendInGameICMessage(args.Actor, msg, InGameICChatType.Speak, ChatTransmitRange.Normal);
}
base.OnTeleportToLocationRequest(ent, ref args);
}
protected override void HandleTeleportDestinationObstructed(EntityUid userUid)
{
// Client can't know if the destination is obstructed if it's not loaded.
var msg = Loc.GetString("teleportation-menu-destination-obstructed");
_popup.PopupEntity(msg, userUid, userUid, PopupType.MediumCaution);
}
// If it's in shared this doesn't populate the points on the UI
/// <summary>
/// Gets the teleport points to send to the BUI
/// </summary>
private void UpdateTeleportPoints(Entity<TeleportLocationsComponent> ent)
{
ent.Comp.AvailableWarps.Clear();
var allEnts = AllEntityQuery<WarpPointComponent>();
// Selecting suitable entities with the warpPoint component using whitelist
while (allEnts.MoveNext(out var warpEnt, out var warpPointComp))
{
if (string.IsNullOrWhiteSpace(warpPointComp.Location))
continue;
if (!_whitelist.CheckBoth(warpEnt, ent.Comp.Blacklist, ent.Comp.Whitelist))
continue;
ent.Comp.AvailableWarps.Add(new TeleportPoint(Loc.GetString(warpPointComp.Location), GetNetEntity(warpEnt)));
}
Dirty(ent);
}
}