rechka/fish-station
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove .ToArray() allocations from StepTriggerSystem Update (#8658)

Browse source
This commit is contained in:
Pieter-Jan Briers 2022-06-05 05:31:16 +02:00 • committed by GitHub
parent cb4d5f3e59
commit bdb6f7df1f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
Content.Shared/StepTrigger/StepTriggerSystem.cs
View file

@ -1,4 +1,4 @@
using System.Linq;
using Robust.Shared.Collections;
using Robust.Shared.GameStates;
using Robust.Shared.Physics.Dynamics;
@ -34,15 +34,27 @@ public sealed class StepTriggerSystem : EntitySystem
component.Colliding.Count == 0)
return true;
foreach (var otherUid in component.Colliding.ToArray())
var remQueue = new ValueList<EntityUid>();
foreach (var otherUid in component.Colliding)
{
var shouldRemoveFromColliding = UpdateColliding(component, transform, otherUid, query);
if (!shouldRemoveFromColliding) continue;
if (!shouldRemoveFromColliding)
continue;
remQueue.Add(otherUid);
}
if (remQueue.Count > 0)
{
foreach (var uid in remQueue)
{
component.Colliding.Remove(uid);
component.CurrentlySteppedOn.Remove(uid);
}
component.Colliding.Remove(otherUid);
component.CurrentlySteppedOn.Remove(otherUid);
Dirty(component);
}
return false;
}