rechka/fish-station
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
fish-station/Content.Server
History
Pieter-Jan Briers c7b0d5a27c
Fix some rounds failing to end due to mind roles (#32792) 
* Fix some rounds failing to end due to mind roles

Fixes #32791

This is caused by ShowRoundEndScoreboard running into a bug trying to display antags: some player is showing up as antag with MindIsAntagonist(), but has no antag roles listed in MindGetAllRoleInfo().

This was caused by one of the roles of the player having the Antag boolean set, but having no AntagPrototype set.

The responsible mind role appeared to be MindRoleSubvertedSilicon which is missing a set for the SubvertedSilicon antag prototype.

I also added resilience to the round-end code to make it so that an exception showing the scoreboard (and sending the Discord message) would not cause the round end logic to completely abort from an exception.

I am planning to add an integration test to cover this bug (no prototype in mind roles), but I'll leave that for not-the-immediate-hotfix.

* At least one maintainer approved this tiny PR without reading it, not naming names.
2024-10-13 22:55:15 +02:00
..
Abilities/Mime Remove double-iteration from the mime wall code (#31420) 2024-08-27 02:18:10 +02:00
Access Job title localization (#32338) 2024-10-09 17:05:36 +02:00
Actions Action stuff (#31305) 2024-08-25 22:43:31 +10:00
Acz
Administration Add interaction rate limits (#32527) 2024-09-29 22:19:00 +10:00
Advertise Convert advertisements to use localized datasets (#28400) 2024-05-30 12:08:42 -04:00
Afk
Alert Replace IClickAlert with events (#30728) 2024-08-07 15:15:35 +10:00
AlertLevel Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Ame Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Animals Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Announcements Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
Anomaly fix Tech anomaly loud sounds and superfast flickering (#32245) 2024-09-17 12:05:38 -04:00
Antag Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Arcade Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Armor
Atmos Use archived gas mixture in gas exchange comparison (#32088) 2024-09-29 22:14:07 -07:00
Audio Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Beam Resolve 'TransformComponent.MapPosition' is obsolete in content (#27939) 2024-05-12 10:31:54 -04:00
Bed Fix cryo locale again (#32654) 2024-10-08 11:50:54 +02:00
Bible Syndicate Reinforcement Specializations: Medic, Spy, Thief (#29853) 2024-07-21 20:32:25 +10:00
Body Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Botany Fix mutation system debug assert (#32530) 2024-09-29 13:37:31 -08:00
Buckle/Systems Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Camera
CardboardBox Decouple interactions from hands, cleanup old events, add new fears (#28393) 2024-05-31 13:26:19 -07:00
Cargo Fix bounties(and potentially other things) running out of ids (#32700) 2024-10-10 16:35:35 +02:00
CartridgeLoader MedTek Cartridge (#32450) 2024-10-01 23:17:57 -07:00
CharacterInfo Localization of the title of the job (#30353) 2024-07-26 14:47:07 -04:00
Charges item toggling giga rework + full ninja refactor (#28039) 2024-07-11 15:55:56 +10:00
Chat Add interaction rate limits (#32527) 2024-09-29 22:19:00 +10:00
Chemistry Clean up solution regen and drain comps (#29777) 2024-09-19 12:17:13 +10:00
Chunking
Clock Watches (#29550) 2024-07-13 16:09:19 +10:00
Cloning Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Clothing Move OnGhostAttempt to GhostSystem (#31445) 2024-08-26 14:15:33 +02:00
Cluwne Remove all Assigned Values that are Never Used (#30110) 2024-07-18 20:22:23 -04:00
CombatMode
Commands Replace xform.WorldPosition with xformSystem method for Setting/Getting (#30029) 2024-08-06 21:02:01 +10:00
Communications feat: now when research is unlocked in console, approver of reasearch is radio-ed too (#31170) 2024-09-03 23:01:38 +10:00
Configurable Welding tweaks (#27959) 2024-06-02 23:28:53 -04:00
Connection Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Construction Station AI ability to electricute doors (#32012) 2024-09-27 17:22:17 +10:00
Containers Remove unused variable from ThownInsertContainerSystem (#30611) 2024-08-04 15:36:25 +10:00
Coordinates
CPUJob/JobQueues/Queues
Crayon Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CrewManifest Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CriminalRecords/Systems Wanted list cartridge (#31223) 2024-09-19 12:22:02 +02:00
Cuffs
Damage Remove unused IoC dependency references. (#31704) 2024-09-01 23:22:50 +02:00
Database Fix cartesian explosion in pref loading (#32434) 2024-09-24 22:43:02 +02:00
Decals Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Defusable
Destructible Change minibomb to be explosion resistant and start timer on damage (#32429) 2024-10-08 00:42:42 +02:00
DetailExaminable Remove calls to FormattedMessage obsolete methods (#31706) 2024-09-01 13:00:53 +02:00
DeviceLinking Power stuff (#31314) 2024-08-25 22:18:42 +10:00
DeviceNetwork Devmap crew monitor fix (#31677) 2024-09-01 22:37:17 -06:00
Devour Dropping Corpses Devoured by Space Dragons on Gib/Butcher. (#28709) 2024-06-08 15:49:42 +10:00
Dice
Discord Add webhook for votekicks (#32513) 2024-09-29 15:23:53 +02:00
Disposal Fix disposal units flushing too soon after power-on (#32314) 2024-09-20 21:58:26 +10:00
DoAfter
Doors Station AI ability to electricute doors (#32012) 2024-09-27 17:22:17 +10:00
Dragon fix dragon spawn location and round end summary (#31890) 2024-09-09 13:22:41 -06:00
Drowsiness Add haloperidol, potassium iodide (#27454) 2024-08-03 03:12:08 +10:00
Drunk
Effects
Electrocution Station AI ability to electricute doors (#32012) 2024-09-27 17:22:17 +10:00
Emoting
Emp Resolve 'TransformComponent.MapPosition' is obsolete in content (#27939) 2024-05-12 10:31:54 -04:00
Engineering Use TurfSystem.IsTileBlocked instead of TurfHelpers (#32174) 2024-09-18 11:49:37 +10:00
Ensnaring Predict stripping (#32478) 2024-09-27 17:12:10 +10:00
EntityEffects Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
EntityList fix(Commands): Improve Localization of commands. Standardize some behaviors. (#30362) 2024-08-11 19:46:57 +10:00
Entry AstroNav GPS Cartridge (#32194) 2024-09-24 19:02:51 +02:00
EUI
Examine
Explosion Change the syndicate charge to start a timer on signal (#32423) 2024-10-04 11:34:48 +02:00
Fax Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Flash let FlashArea be called from shared (#30343) 2024-09-19 09:58:10 +10:00
Fluids Added Firebots - Real (#32482) 2024-09-30 20:13:16 -07:00
Forensics Change forensic pad to use label isntead of name changing (#31842) 2024-09-12 02:52:19 +02:00
GameTicking Fix some rounds failing to end due to mind roles (#32792) 2024-10-13 22:55:15 +02:00
Gateway Remove calls to FormattedMessage obsolete methods (#31706) 2024-09-01 13:00:53 +02:00
Gatherable fix Gatherable magic number (#31327) 2024-08-22 22:03:05 -04:00
Ghost Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
GhostKick Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
Glue Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Gravity Use Transform instead of TryComp<TransformComponent> (#32170) 2024-09-14 23:34:44 +02:00
GridPreloader LoadMapRule grid storage rework (#28210) 2024-06-03 20:04:19 -04:00
Guardian prevent using holo inside containers (#32068) 2024-09-15 21:04:31 +02:00
Guidebook Add guidebook protodata tag: embed prototype values in guidebook text (#27570) 2024-09-12 13:31:56 +03:00
GuideGenerator Turn ReagentEffects into generic EntityEffects (#28168) 2024-06-30 13:43:43 +10:00
Hands/Systems Replace xform.WorldPosition with xformSystem method for Setting/Getting (#30029) 2024-08-06 21:02:01 +10:00
Holiday Replace EntityPrototype.NoSpawn with EntityPrototype.HideSpawnMenu (#30082) 2024-07-17 00:29:31 +10:00
Holosign Remove CRLF, enforce with workflow (#26401) 2024-03-24 22:06:17 +01:00
HotPotato Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Humanoid Remove obsolete occurrences of IComponent.Owner being assigned just before AddComponent (#30724) 2024-08-08 13:03:41 +10:00
IconSmoothing randomize iconSmoothing (#28158) 2024-07-19 18:13:35 +10:00
IdentityManagement Job title localization (#32338) 2024-10-09 17:05:36 +02:00
IgnitionSource Move IgnitionEvent to shared (#30985) 2024-09-02 02:27:13 +02:00
ImmovableRod Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Implants Fix currency duplication bug (#32524) 2024-09-29 22:13:22 +10:00
Info Fixes the ShowRulesCommand and the client not syncing rules correctly (#28752) 2024-06-15 00:41:25 -04:00
Instruments Remove all Assigned Values that are Never Used (#30110) 2024-07-18 20:22:23 -04:00
Interaction Remove obsolete functions from tile commands. (#31112) 2024-08-23 03:10:13 +02:00
Inventory Move storage binds and slot click handling to shared (#27135) 2024-04-20 16:23:45 +10:00
IoC Add webhook for votekicks (#32513) 2024-09-29 15:23:53 +02:00
IP Fixed IP bans preventing non-banned players from connecting to SQLite-backed servers (#31154) 2024-08-18 13:53:09 +02:00
Item item toggling giga rework + full ninja refactor (#28039) 2024-07-11 15:55:56 +10:00
Jittering
Jobs improve job special (#30753) 2024-08-09 17:43:57 +10:00
KillTracking Try fix KeyNotFoundException in KillTrackingSystem (#28553) 2024-06-03 09:36:07 -04:00
Kitchen Plushies can now have pAIs stuffed into them (v2)! (#30805) 2024-10-09 20:01:32 +02:00
Labels/Label Move PaperSystem to Shared (#30592) 2024-08-05 14:23:23 +10:00
LandMines Landmine stepoff (#22962) 2024-03-24 16:33:45 +11:00
Lathe Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Light Move IgnitionEvent to shared (#30985) 2024-09-02 02:27:13 +02:00
Lightning Log enrichment: Explosion damage to players (#29762) 2024-08-09 16:24:05 +10:00
Lube Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Magic Magic Refactor + Wizard Grimoire (#22568) 2024-05-11 19:06:49 -04:00
MagicMirror Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361) 2024-08-08 13:39:46 +02:00
Mapping fix(Commands): Improve Localization of commands. Standardize some behaviors. (#30362) 2024-08-11 19:46:57 +10:00
Maps Change Resave Permission Requirement to Host (#31397) 2024-08-25 11:55:31 +10:00
MapText Implement map text (#28705) 2024-06-09 15:18:54 -04:00
MassMedia Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Materials Fix error log when recycling something with small material counts. (#32723) 2024-10-10 03:29:26 +02:00
Mech Fix AudioSystem nullability checks for engine PR (#32233) 2024-09-18 11:43:30 +10:00
Medical Job title localization (#32338) 2024-10-09 17:05:36 +02:00
Mind Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Mindshield
Mining Mineral Scanner (#31390) 2024-09-07 00:05:53 +10:00
Mobs
MoMMI
Morgue Morgue system refactor remove unused VVs and into Entity (#31835) 2024-09-04 17:30:21 +02:00
Motd Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
MouseRotator
Mousetrap
Movement Fully Revert Clown Waddling (#32652) 2024-10-06 15:33:02 +02:00
NameIdentifier Fix bounties(and potentially other things) running out of ids (#32700) 2024-10-10 16:35:35 +02:00
Ninja Ninja throwing star ability fix (#31684) 2024-09-02 18:50:34 -06:00
NodeContainer Prevent stacking pipes (#28308) 2024-05-27 16:37:27 -06:00
NPC Added Firebots - Real (#32482) 2024-09-30 20:13:16 -07:00
Nuke Nuke Now Requires the Disk to be Inserted to Toggle Anchor (#29565) 2024-09-09 13:30:26 -06:00
NukeOps Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Nutrition Plushies can now have pAIs stuffed into them (v2)! (#30805) 2024-10-09 20:01:32 +02:00
Objectives Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
PAI Use non-generic TryComp() for metadata & transform (#28133) 2024-05-20 22:40:35 -07:00
Paper Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Parallax Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
ParticleAccelerator Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Payload/EntitySystems Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
PDA Job title localization (#32338) 2024-10-09 17:05:36 +02:00
Physics Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Pinpointer remove UntrackedMapBoundUserInterface (#30752) 2024-08-09 15:24:49 +10:00
Placement
Players Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
PneumaticCannon Welding tweaks (#27959) 2024-06-02 23:28:53 -04:00
Pointing Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Points Remove calls to FormattedMessage obsolete methods (#31706) 2024-09-01 13:00:53 +02:00
Polymorph replace all uses of TryGetContainingContainer with non-obsolete overload (#30583) 2024-08-04 15:38:53 +10:00
Popups Add SharedPopupSystem.PopupClient for cursor and coordinates (#27231) 2024-04-22 13:57:13 +10:00
Power Make APC UI work correctly with multiple users (#32465) 2024-10-12 19:21:43 +11:00
PowerCell decouple ItemToggle from PowerCellDraw (#31392) 2024-08-25 22:17:03 +10:00
PowerSink Remove all obsolete BatteryComponent method calls (#25871) 2024-03-06 16:34:50 +11:00
Prayer Fix null ref exception in PrayerSystem (#28712) 2024-06-08 14:50:20 -04:00
Preferences/Managers Vanquish inaccurate docs (#30449) 2024-07-30 12:14:34 +10:00
Procedural Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Projectiles Only auto-enable internals when necessary (#28248) 2024-05-31 12:28:11 +10:00
Puppet
Radiation Add haloperidol, potassium iodide (#27454) 2024-08-03 03:12:08 +10:00
Radio Voice Mask refactor (#30798) 2024-09-26 18:55:59 +02:00
RandomAppearance
RandomMetadata Add support for LocalizedDatasets to RandomMetadata (#28601) 2024-06-06 02:37:49 -04:00
RatKing Reduced Warning Count By 130 For Full Rebuilds (#26518) 2024-03-29 16:28:16 +11:00
Remotes Station AI ability to electricute doors (#32012) 2024-09-27 17:22:17 +10:00
Repairable Recycler Overhaul (#30802) 2024-08-18 21:39:00 -06:00
RequiresGrid
Research feat: now when research is unlocked in console, approver of reasearch is radio-ed too (#31170) 2024-09-03 23:01:38 +10:00
Resist Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361) 2024-08-08 13:39:46 +02:00
Respawn Use TurfSystem.IsTileBlocked instead of TurfHelpers (#32174) 2024-09-18 11:49:37 +10:00
Revenant fix: Check revenant ability costs correctly (#32050) 2024-09-10 19:07:07 -04:00
Revolutionary Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Robotics/Systems malf killer 9000 (robotics console) (#24855) 2024-05-08 23:36:07 -07:00
Roles Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Rotatable Add keybinds for rotating and flipping objects (#30540) 2024-08-13 23:36:41 +10:00
Rotation
RoundEnd Localization of the shuttle call sender (#32286) 2024-09-18 21:16:47 +02:00
Salvage Fix AudioSystem nullability checks for engine PR (#32233) 2024-09-18 11:43:30 +10:00
Sandbox Fix colornetwork desc and help (#29856) 2024-07-10 09:24:38 +10:00
Screens cancelable brig timers (#26557) 2024-03-31 16:44:02 -04:00
SensorMonitoring Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Sericulture
ServerInfo
ServerUpdates
Shuttles Two additional checks to prevent FTLing stations (#32558) 2024-10-04 12:55:36 +10:00
Silicons Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Singularity Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Solar Replace xform.WorldPosition with xformSystem method for Setting/Getting (#30029) 2024-08-06 21:02:01 +10:00
Sound Station AI (#30944) 2024-08-28 10:57:12 +10:00
Spawners Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
Species/Systems Body code cleanup (#24946) 2024-03-27 17:48:37 -07:00
Speech Voice Mask refactor (#30798) 2024-09-26 18:55:59 +02:00
Spider
SprayPainter Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361) 2024-08-08 13:39:46 +02:00
Spreader metal foam grenades (#29428) 2024-07-08 00:26:58 +10:00
Sprite Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Stack Fix currency duplication bug (#32524) 2024-09-29 22:13:22 +10:00
Standing Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Station Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
StationEvents Moved hardcoded string "PEOPLE" to Loc.GetString() (#32164) 2024-09-14 22:37:41 +03:00
StationRecords Rename fix (#31654) 2024-09-15 11:55:03 +10:00
Stealth
Storage Log enrichment: Explosion damage to players (#29762) 2024-08-09 16:24:05 +10:00
Store Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
StoreDiscount/Systems feat: #26107 uplink discounts for traitors (no nukies for now) (#26297) 2024-09-05 22:12:39 +10:00
Strip Predict stripping (#32478) 2024-09-27 17:12:10 +10:00
Stunnable item toggling giga rework + full ninja refactor (#28039) 2024-07-11 15:55:56 +10:00
SubFloor Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
SurveillanceCamera Voice Mask refactor (#30798) 2024-09-26 18:55:59 +02:00
Tabletop Remove placing items on tabletop boards. (#29513) 2024-06-27 16:57:55 +02:00
Teleportation hand teleport portals now may start in the same grid. (#28556) 2024-06-04 12:34:07 -04:00
Temperature Don't error on missing component in ChangeHeat (#32451) 2024-10-12 11:52:05 -07:00
Tesla Use new ComponentPauseGenerator (#25183) 2024-02-26 14:36:19 +11:00
Thief Fixing Thief Beacon Role Check Logic (to use new mindrole system) (#32764) 2024-10-12 22:20:03 -07:00
Tiles Turn ReagentEffects into generic EntityEffects (#28168) 2024-06-30 13:43:43 +10:00
Tips Localize tips (#28285) 2024-05-30 07:39:07 -04:00
Toilet Toilet Upgrade (needs review) (#22133) 2024-03-31 14:21:18 +11:00
Tools THE RETURN OF ITEM STATUS (#22986) 2024-04-21 23:16:23 +10:00
Toolshed/Commands Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
Traitor feat: #26107 uplink discounts for traitors (no nukies for now) (#26297) 2024-09-05 22:12:39 +10:00
Traits don't apply traits for borg and ai (#31990) 2024-09-12 13:36:41 +03:00
UserInterface Predict IntrinsicUI (#31310) 2024-08-22 13:03:05 -04:00
VendingMachines Fix contraband never getting added to vend inventory (#32431) 2024-09-25 15:21:24 +10:00
Verbs Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
VoiceMask Voice Mask refactor (#30798) 2024-09-26 18:55:59 +02:00
Voting Add webhook for votekicks (#32513) 2024-09-29 15:23:53 +02:00
Wagging
Warps
Weapons Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Weather Weather fix (#30857) 2024-08-26 01:20:47 +10:00
Whitelist Implement a playerpanel (#30238) 2024-08-09 15:33:25 +10:00
Wires Remove always false checks (#31708) 2024-09-01 12:45:01 +02:00
Worldgen Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Xenoarchaeology fix infinite banana bug (#32167) 2024-09-15 11:54:18 +10:00
Zombies Mind Role Entities (#31318) 2024-10-10 10:48:56 +02:00
AssemblyInfo.cs
Content.Server.csproj Remove some wayward folder includes in the csproj (#31244) 2024-08-22 13:19:29 -04:00
Content.Server.csproj.DotSettings
GlobalUsings.cs
Program.cs