fish-station/Content.Server
ArtisticRoomba 44925b9be7
Fix spray nozzle not cleaning reagents properly (#35950)
* init, god help us all

* further refining

* final round of bugfixes

* whoopsies

* To file scoped namespace

* first review

* oopsie

* oopsie woopsie

* pie is on my face

* persistence

* datafieldn't

* make PreviousTileRef nullable

* change component to file scoped namespace

* Minor tweaks:

- We clamp the reaction amount to a minimum value because when working with percentages and dividing, we approach numbers like 0.01 and never actually properly delete the entity (because we check for zero). This allows us to react with a minimum amount and cleans things up nicely.
- Minor clarification to comments.
- Rebalancing of the spray nozzle projectile.

* the scug lies!!!!

* undo file scoped namespace in system

* kid named warning

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
2025-04-19 22:41:24 -04:00
..
Abilities/Mime Mime can no longer write on paper without breaking their vow (#35043) 2025-02-26 10:11:59 +01:00
Access Fix IDs without station records not being able to have nonstandard contents (#34921) 2025-04-14 17:02:27 +02:00
Actions Action stuff (#31305) 2024-08-25 22:43:31 +10:00
Acz
Administration Cleanup: Superbonk cleanup (#35104) 2025-04-19 10:26:56 -04:00
Advertise Predict vending machine UI (#33412) 2025-03-02 13:47:52 +11:00
Afk
Alert Fix alerts mispredict + log spam (#36004) 2025-03-22 12:41:16 +01:00
AlertLevel New component: change alert level on trigger (#36581) 2025-04-17 21:35:27 +10:00
Ame "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Animals Reduce network burden of the hunger system (#32986) 2024-12-18 14:06:02 +01:00
Announcements Cleanup: Remove redundant prototype name specifications (#35793) 2025-03-19 19:30:31 +01:00
Anomaly remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Antag remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Arcade Predict vending machine UI (#33412) 2025-03-02 13:47:52 +11:00
Armor
Atmos Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Audio Refactor audio system to send collection IDs over the network (#33610) 2025-02-23 23:14:56 +11:00
Beam remove usages of obsolete EntityUid method variants (#35106) 2025-02-16 03:06:23 +01:00
Bed Seperate EMAG into EMAG and Authentication Disruptor (#34337) 2025-01-29 23:05:47 -05:00
Bible Cleanup: Use `SoundCollectionSpecifier instead of string literals in BibleSystem` (#35448) 2025-02-25 08:23:50 +11:00
Body Fixed Attachbodypart Console Command (#34577) 2025-04-19 11:23:58 +10:00
Botany Predict Labels (#36406) 2025-04-10 22:19:48 -07:00
Buckle/Systems Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Camera
CardboardBox Decouple interactions from hands, cleanup old events, add new fears (#28393) 2024-05-31 13:26:19 -07:00
Cargo Fix inability to engage with economic Cargonia (#36668) 2025-04-18 12:06:29 +10:00
CartridgeLoader Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
CharacterInfo Localization of the title of the job (#30353) 2024-07-26 14:47:07 -04:00
Charges Action charges refactor (#33993) 2025-04-18 13:45:48 +10:00
Chat remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Chemistry Fix spray nozzle not cleaning reagents properly (#35950) 2025-04-19 22:41:24 -04:00
Chunking
Clock Watches (#29550) 2024-07-13 16:09:19 +10:00
Cloning remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Clothing "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Cluwne Clumsy system refactor (#31147) 2024-11-16 00:46:01 +01:00
CombatMode Refactor disarms (#36546) 2025-04-19 11:38:22 +10:00
Commands Remove unused helper. Use EmplaceCommand instead 2025-01-02 17:00:45 +13:00
Communications Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Configurable Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Connection IPIntel now rounds to 2 decimal points (#36298) 2025-04-04 20:42:13 +02:00
Construction Construction spring cleaning (#36163) 2025-04-16 13:02:41 +02:00
Containers Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Coordinates
CPUJob/JobQueues/Queues
Crayon Improve crayon UI to not be stuck in 1996 (#33101) 2024-11-15 21:25:06 -06:00
CrewManifest
CriminalRecords/Systems Fix ninjas not being able to hack criminal records (#36299) 2025-04-04 19:46:59 +02:00
Cuffs
Damage Predict DamagePopup (#36547) 2025-04-14 21:10:09 +02:00
Database Add loadout names (#31303) 2025-02-11 18:30:24 +01:00
Decals Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Defusable Revert "Purge uses of TransformComponent.Anchored.set. Also adds parentheses." (#35332) 2025-02-21 00:12:12 +11:00
Delivery Fix inability to engage with economic Cargonia (#36668) 2025-04-18 12:06:29 +10:00
Destructible Fix entities burning to ash not using identity, and bad formatting (#36268) 2025-04-03 04:02:09 +02:00
DeviceLinking Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
DeviceNetwork Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Devour Dropping Corpses Devoured by Space Dragons on Gib/Butcher. (#28709) 2024-06-08 15:49:42 +10:00
Dice Predicted dice rolls (#34863) 2025-02-14 16:46:25 +01:00
Discord Fix 38 non-obsolete warnings (#33794) 2025-02-11 20:59:50 +11:00
Disposal Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
DoAfter
Doors move DeviceLinking events to shared (#36307) 2025-04-05 14:20:14 +02:00
Dragon add: Dragon rift color changes based on charge (#36216) 2025-04-02 14:37:34 -04:00
Drowsiness Add haloperidol, potassium iodide (#27454) 2024-08-03 03:12:08 +10:00
Drunk
Effects
Electrocution Fix powered lights electrocuting you despite having insulated gloves V2 (#36686) 2025-04-18 22:26:47 +10:00
Emoting
Emp 3mo xeno archeology (first phase) (#33370) 2025-04-15 10:34:53 +10:00
Engineering Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Ensnaring Predict stripping (#32478) 2024-09-27 17:12:10 +10:00
EntityEffects Fix Long Produce Time After De-aging A Plant with cryoxadone. (#34668) 2025-04-19 09:43:05 -04:00
EntityList fix(Commands): Improve Localization of commands. Standardize some behaviors. (#30362) 2024-08-11 19:46:57 +10:00
Entry Add ability for admins to change certain cvars via command. (#35105) 2025-02-16 10:06:13 +01:00
EUI
Examine
Explosion DetGadget hat fixes (#35658) 2025-04-19 16:11:55 +02:00
Fax Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Flash Action charges refactor (#33993) 2025-04-18 13:45:48 +10:00
Fluids [#30096 Fix] Dumping a RefillableSolution into a DumpableSolution now requires CanComplexInteract (#33350) 2025-04-19 16:32:17 -04:00
Forensics Predict Labels (#36406) 2025-04-10 22:19:48 -07:00
GameTicking Predict and cleanup RingerComponent (#35907) 2025-04-19 15:55:05 +02:00
Gateway Localize planet dataset names (#33398) 2024-11-20 11:57:43 +11:00
Gatherable fix Gatherable magic number (#31327) 2024-08-22 22:03:05 -04:00
Ghost remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
GhostKick Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
Gibbing/Systems Paradox Clone (#35794) 2025-03-13 10:09:07 -07:00
Glue Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Gravity Use Transform instead of TryComp<TransformComponent> (#32170) 2024-09-14 23:34:44 +02:00
GridPreloader Refactor map loading & saving 2024-12-23 02:42:17 +13:00
Guardian Holoparasite injector fix (#36109) 2025-03-31 17:18:21 -04:00
Guidebook Add guidebook protodata tag: embed prototype values in guidebook text (#27570) 2024-09-12 13:31:56 +03:00
GuideGenerator Turn ReagentEffects into generic EntityEffects (#28168) 2024-06-30 13:43:43 +10:00
Hands/Systems Refactor disarms (#36546) 2025-04-19 11:38:22 +10:00
Holiday Cleanup: Remove redundant prototype name specifications (#35793) 2025-03-19 19:30:31 +01:00
Holopad Minor station AI code cleanup (#34476) 2025-02-18 16:26:02 +11:00
Holosign Revert "Purge uses of TransformComponent.Anchored.set. Also adds parentheses." (#35332) 2025-02-21 00:12:12 +11:00
HotPotato
Humanoid Move CloneAppearance to Shared (#35017) 2025-02-10 04:13:27 +01:00
IconSmoothing randomize iconSmoothing (#28158) 2024-07-19 18:13:35 +10:00
IdentityManagement Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
IgnitionSource predict IgnitionSourceComponent (#36310) 2025-04-06 17:54:47 -07:00
ImmovableRod Replace obsolete Tile Access methods (#32508) 2024-09-29 01:27:47 +02:00
Implants Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Info After getting banned, you now have to re-read the rules! (#33270) 2025-01-30 13:09:31 +01:00
Instruments Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Interaction Remove obsolete functions from tile commands. (#31112) 2024-08-23 03:10:13 +02:00
Inventory Fix forensics not being applied to held items (#30609) 2025-04-18 21:02:41 -04:00
IoC Add ability for admins to change certain cvars via command. (#35105) 2025-02-16 10:06:13 +01:00
IP Fixed IP bans preventing non-banned players from connecting to SQLite-backed servers (#31154) 2024-08-18 13:53:09 +02:00
Item Predicted multihanded component (#36712) 2025-04-19 18:05:20 +10:00
ItemRecall Wizard Item Recall Spell (#34411) 2025-02-08 16:56:08 -05:00
Jittering
Jobs improve job special (#30753) 2024-08-09 17:43:57 +10:00
KillTracking Try fix KeyNotFoundException in KillTrackingSystem (#28553) 2024-06-03 09:36:07 -04:00
Kitchen move DeviceLinking events to shared (#36307) 2025-04-05 14:20:14 +02:00
Labels/Label Predict Labels (#36406) 2025-04-10 22:19:48 -07:00
LandMines
Lathe Fix lathe arbitrage test (#34449) 2025-04-17 21:07:51 +10:00
Light Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Lightning Log enrichment: Explosion damage to players (#29762) 2024-08-09 16:24:05 +10:00
Lube Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084) 2024-09-02 13:26:04 +02:00
Magic Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
MagicMirror Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
Mapping Fix autosave path (#36352) 2025-04-14 13:41:41 +03:00
Maps Make MappingDataNode use string keys (#36111) 2025-04-18 19:28:22 +10:00
MapText Implement map text (#28705) 2024-06-09 15:18:54 -04:00
MassMedia Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Materials Fix ore silo clients showing up when out of range (#36741) 2025-04-20 11:00:23 +10:00
Mech Fix AudioSystem nullability checks for engine PR (#32233) 2024-09-18 11:43:30 +10:00
Medical Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Mind remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Mindshield minor MindShieldSystem cleanup (#35905) 2025-04-17 21:38:53 +10:00
Mining "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Mobs
MoMMI
Morgue "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Motd Clean up command perms (#28451) 2024-06-01 01:14:43 -07:00
MouseRotator
Mousetrap UseInHandEvent cleanup (#35231) 2025-02-18 23:27:30 +11:00
Movement Mob collision tweaks (#36296) 2025-04-04 17:14:04 +02:00
NameIdentifier Fix 38 non-obsolete warnings (#33794) 2025-02-11 20:59:50 +11:00
Ninja Fix ninja battery drain debug assertion (#36461) 2025-04-11 19:42:54 +02:00
NodeContainer Fix gas pipe leaking when unanchoring or breaking them (#33774) 2024-12-09 00:20:04 +01:00
NPC Make MappingDataNode use string keys (#36111) 2025-04-18 19:28:22 +10:00
Nuke Refactor audio system to send collection IDs over the network (#33610) 2025-02-23 23:14:56 +11:00
NukeOps
Nutrition ciggie sounds (#32426) 2025-04-19 00:01:52 +02:00
Objectives remove mind roles from EntityWhitelist (#36089) 2025-04-10 20:45:12 +10:00
PAI 3mo xeno archeology (first phase) (#33370) 2025-04-15 10:34:53 +10:00
Paper Power stuff (#31314) 2024-08-25 22:18:42 +10:00
Parallax Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
ParticleAccelerator Fix RA0032 (#32514) 2024-09-29 02:25:21 +02:00
Payload/EntitySystems Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
PDA Predict and cleanup RingerComponent (#35907) 2025-04-19 15:55:05 +02:00
Physics move DeviceLinking events to shared (#36307) 2025-04-05 14:20:14 +02:00
Pinpointer Local Material Silo (#36492) 2025-04-19 09:43:17 +10:00
Placement "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Players remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
PneumaticCannon Welding tweaks (#27959) 2024-06-02 23:28:53 -04:00
Pointing Improve messages for pointing at items in inventories (#36252) 2025-04-18 08:09:49 -04:00
Points Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Polymorph New Experimental Science T3: Desynchronizer (#35752) 2025-04-16 11:33:39 +10:00
Popups Add PopupPredictedCursor and fix doubled popups on vending machines (#36655) 2025-04-18 14:01:46 +10:00
Power Fix a minor warning in BatterySystem.cs (#36726) 2025-04-19 14:37:10 +02:00
PowerCell decouple ItemToggle from PowerCellDraw (#31392) 2024-08-25 22:17:03 +10:00
PowerSink Various Locale Typo Fixes (and spaces) (#34483) 2025-01-17 23:37:37 -08:00
Prayer Fix null ref exception in PrayerSystem (#28712) 2024-06-08 14:50:20 -04:00
Preferences/Managers Vanquish inaccurate docs (#30449) 2024-07-30 12:14:34 +10:00
Procedural Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
Projectiles "New player" admin logging improvements (#35961) 2025-03-20 20:56:51 +01:00
Puppet
Radiation Geiger counters can now be heard by everyone nearby (#30463) 2025-04-17 21:24:47 +10:00
Radio Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
RandomAppearance
RandomMetadata Make RandomMetadata properly support localization (#36343) 2025-04-06 11:12:39 -07:00
RatKing Localize rat king commands datasets (#35780) 2025-03-11 22:49:32 -07:00
Remotes CentComm Map Updates (#34475) 2025-01-18 22:32:33 -07:00
Repairable Recycler Overhaul (#30802) 2024-08-18 21:39:00 -06:00
RequiresGrid
Research Add chatty lathes (#34959) 2025-04-16 21:29:25 +02:00
Resist Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361) 2024-08-08 13:39:46 +02:00
Respawn Cleanup SpecialRespawnSystem (#36087) 2025-03-25 23:16:48 +01:00
Revenant Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
Revolutionary Fix warden being and qm being not considered head for tot kill head objective (#32721) 2024-10-18 11:43:05 +02:00
Robotics/Systems Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Roles remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Rotatable Rotation warnings cleanup (#36197) 2025-04-01 23:56:37 +02:00
Rotation
RoundEnd Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Salvage add some error logging to exped generation (#32867) 2025-04-13 18:03:13 +02:00
Sandbox Fix colornetwork command not checking for correct permissions (#35180) 2025-02-15 10:01:46 +01:00
Screens Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
SensorMonitoring Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Sericulture
ServerInfo Add telegram to the server info-links (#33459) 2024-11-22 16:38:41 +01:00
ServerUpdates System to automatically restart server after certain uptime. (#32814) 2024-10-20 16:46:22 +02:00
Shuttles Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Silicons Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Singularity Various system spring cleaning (#36206) 2025-04-16 13:08:22 +02:00
Solar Engineering guidebook improvements (#34695) 2025-02-14 19:59:19 -08:00
Sound Station AI (#30944) 2024-08-28 10:57:12 +10:00
Spawners Fix artifact spawns parenting to players (#36745) 2025-04-20 11:00:49 +10:00
Species/Systems
Speech Correct mobster suffix (#33240) 2025-04-18 20:33:14 -04:00
Spider
SprayPainter Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361) 2024-08-08 13:39:46 +02:00
Spreader metal foam grenades (#29428) 2024-07-08 00:26:58 +10:00
Sprite
Stack Departmental Economy (#36445) 2025-04-13 15:22:36 +02:00
Station Minor dependency and variable cleanup. (#36730) 2025-04-19 18:11:34 +02:00
StationEvents StationEvent Toolshed Command fixes. (#32200) 2025-04-18 17:44:29 +10:00
StationRecords Fix Chameleon PDAs renaming the user in station records (#35782) 2025-03-11 14:52:38 +01:00
Stealth
Storage Storage warnings cleanup (#36196) 2025-04-18 13:47:17 +10:00
Store Predict and cleanup RingerComponent (#35907) 2025-04-19 15:55:05 +02:00
StoreDiscount/Systems Increase syndicate uplink discount amount to 6. (#33950) 2024-12-20 20:14:08 -06:00
Strip Fix forensics not being applied to held items (#30609) 2025-04-18 21:02:41 -04:00
Stunnable Item HeldPrefix and Clothing EquippedPrefix toggler (#33054) 2025-04-14 15:50:21 -07:00
SubFloor Predict pipe anchoring and unanchroing (#35977) 2025-03-21 12:43:35 +03:00
SurveillanceCamera Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
Tabletop Cleanup TabletopSystem.Map (#36097) 2025-03-26 15:17:28 +01:00
Telephone Speech is relayed by holopad holograms (#33978) 2025-01-02 12:41:12 +01:00
Teleportation Fix admeme hand teleproter. (#36147) 2025-03-29 17:51:46 +03:00
Temperature Add prediction to electric grills (#36241) 2025-04-01 09:43:19 -07:00
Tesla
Thief Undetermined thieving satchel (#36201) 2025-03-31 15:32:31 -07:00
Tiles Make Ignite tryget flammablecomp (#34970) 2025-02-08 11:56:44 +01:00
Tips Fix tippy speech time (#36616) 2025-04-16 08:23:40 -04:00
Toilet
Tools Extracts magic strings from Tag calls (#36305) 2025-04-04 20:20:19 -04:00
Toolshed/Commands Change visualize command perms to VarEdit instead of Admin (#35221) 2025-02-16 20:06:53 +01:00
Traitor remove Session from MindComponent (#34753) 2025-04-19 00:23:01 +02:00
Traits Cloning Refactor and bugfixes (#35555) 2025-03-02 16:50:12 +01:00
Turrets Predict dumping (#32394) 2025-04-19 16:20:40 +10:00
UserInterface Predict IntrinsicUI (#31310) 2024-08-22 13:03:05 -04:00
VendingMachines Add self message variants for starting/finishing vending machine restocking (#36633) 2025-04-16 23:33:02 +02:00
Verbs Hover examine buttons (#35206) 2025-03-22 13:22:01 +11:00
VoiceMask Voice Mask refactor (#30798) 2024-09-26 18:55:59 +02:00
VoiceTrigger DetGadget hat fixes (#35658) 2025-04-19 16:11:55 +02:00
Voting New Feature: Votekick bans distinguish themselves as votekicks (#35258) 2025-02-17 21:39:12 +01:00
Wagging
Warps
Weapons Refactor disarms (#36546) 2025-04-19 11:38:22 +10:00
Weather tweak: weather command tooltip (#33130) 2024-11-09 22:26:51 -06:00
Whitelist Implement a playerpanel (#30238) 2024-08-09 15:33:25 +10:00
Wieldable Add conditional camera offset based on cursor - Hristov Rework, Part 1 (#31626) 2025-01-28 00:20:45 +01:00
Wires Cleanup: Remove redundant prototype name specifications (#35793) 2025-03-19 19:30:31 +01:00
Worldgen Worldgen spring cleaning (#36199) 2025-04-14 13:36:54 +10:00
Xenoarchaeology fixing spessman getting teleported inside artifact (#36719) 2025-04-19 13:07:23 -04:00
Zombies Fix two zombie bugs (#34472) 2025-04-18 20:38:33 -04:00
AssemblyInfo.cs
Content.Server.csproj Remove some wayward folder includes in the csproj (#31244) 2024-08-22 13:19:29 -04:00
Content.Server.csproj.DotSettings
GlobalUsings.cs
Program.cs