rechka/fish-station
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
fish-station/Content.Server
History
Pieter-Jan Briers 7a38b22ddb
Fix preference loading bugs (#27742) 
First bug: if an error occured during pref loading code, it would fail. If the person then readied up, it would likely cause the round to fail to start.

Why could they ready up? The code only checks that the prefs finished loading, not that they finished loading *successfully*. Whoops.

Anyways, now people get kicked if their prefs fail to load. And I improved the error handling.

Second bug: if a user disconnected while their prefs were loading, it would cause an exception. This exception would go unobserved on lobby servers or raise through gameticker on non-lobby servers.

This happened even on a live server once and then triggered the first bug, but idk how.

Fixed this by properly plumbing through cancellation into the preferences loading code. The stuff is now cancelled properly.

Third bug: if somebody has a loadout item with a playtime requirement active, load-time sanitization of player prefs could run into a race condition because the sanitization can happen *before* play time was loaded.

Fixed by moving pref sanitizations to a later stage in the load process.
2024-05-07 14:21:03 +10:00
..
Abilities/Mime Moves muted to shared (#25374) 2024-02-21 15:53:46 -05:00
Access Scattershot antag fixes (#27429) 2024-05-05 19:23:43 +10:00
Actions Add events for custom action target validation (#27230) 2024-04-22 01:39:50 -07:00
Acz Port python packaging to Content.Packaging (#21458) 2023-11-07 09:53:59 +11:00
Administration Fix antag verb incorrectly giving role to admin player instead of target (#27584) 2024-05-01 11:18:32 -04:00
Advertise Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Afk Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
Alert Pulling rework v2 (#24936) 2024-03-19 14:30:56 +11:00
AlertLevel Add syndicate sleeper agents random event (#27501) 2024-05-03 10:13:35 +10:00
Ame Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Animals Simplify DoAfterArgs behavior for movement and distance checks (#25226) 2024-03-19 21:09:00 +11:00
Announcements Make all prototype types partial (#21374) 2023-11-01 19:56:23 -07:00
Anomaly Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Antag Event frequency balance pass (#27721) 2024-05-06 03:10:12 -07:00
Arcade Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Armor Add price multiplier for armor component (#24561) 2024-01-25 17:04:01 -05:00
Atmos Space Ninjas auto-toggle internals after spawning (#25083) 2024-05-03 11:24:21 +10:00
Audio Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
BarSign/Systems Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Beam Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Bed Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Bible UseDelay + ItemCooldown merge (#22502) 2024-01-03 21:33:09 -04:00
Body Space Ninjas auto-toggle internals after spawning (#25083) 2024-05-03 11:24:21 +10:00
Botany Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Buckle/Systems Powered stasis bed prevents body decay (#23520) 2024-01-09 01:40:52 -05:00
Cabinet
Camera
CardboardBox the boxening (#22643) 2023-12-17 02:55:40 -07:00
Cargo Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CartridgeLoader Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CharacterInfo
Charges Use new ComponentPauseGenerator (#25183) 2024-02-26 14:36:19 +11:00
Chat Emotes Menu (#26702) 2024-04-28 21:38:23 -07:00
Chemistry Moved Serverside solution container code to shared (yes that includes ensureSolution!) (#27478) 2024-05-06 17:27:36 -07:00
Chunking Optimise DecalOverlay (#25266) 2024-02-23 18:12:23 +11:00
Cloning Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Clothing Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Cluwne Unrevert audio (#21330) 2023-11-27 22:12:34 +11:00
CombatMode Fix hostile simplemob rotation (#20900) 2023-10-14 00:15:20 -07:00
Commands Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Communications Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Configurable Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Connection Add new "grant_connect_bypass" admin command (#26771) 2024-04-09 17:25:21 +02:00
Construction Actual fix for lockers and deconstruction (#27431) 2024-04-28 15:26:55 +10:00
Containers Disposal aftermerg fix (#27488) 2024-04-29 23:26:28 +10:00
Coordinates Kill SharedEntityExtensions and all popup extensions (#20909) 2023-10-16 16:56:09 +11:00
CPUJob/JobQueues/Queues
Crayon Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CrewManifest Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
CriminalRecords/Systems Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Cuffs
Damage add fuel costs back to finishing welding (#27030) 2024-04-19 19:20:30 -04:00
Database Fix preference loading bugs (#27742) 2024-05-07 14:21:03 +10:00
Decals Reduced Warning Count By 130 For Full Rebuilds (#26518) 2024-03-29 16:28:16 +11:00
Defusable Move grenade components to shared (#22691) 2024-02-02 00:29:01 +11:00
Destructible Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
DetailExaminable
DeviceLinking Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
DeviceNetwork Fix network configurator memory leaking (#27346) 2024-04-26 20:36:57 +10:00
Devour Content ecs containers (#22484) 2023-12-28 01:30:03 -04:00
Dice Unrevert audio (#21330) 2023-11-27 22:12:34 +11:00
Discord Relay custom votes to a webhook (#18561) 2023-12-14 20:03:32 -08:00
Disposal Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
DoAfter
Doors Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Dragon Use nav beacon locations for announcements (#26437) 2024-03-28 16:53:18 +11:00
Drunk
Effects
Electrocution Chances of triggering effects (#27056) 2024-04-18 10:08:42 +10:00
Emoting
Emp Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Engineering Code Cleanup: Purge obsolete MapManager methods (#26279) 2024-03-22 18:08:40 +11:00
Ensnaring Landmine stepoff (#22962) 2024-03-24 16:33:45 +11:00
EntityList Un-revert IPlayerManager refactor (#21244) 2023-10-28 09:59:53 +11:00
Entry THE RETURN OF ITEM STATUS (#22986) 2024-04-21 23:16:23 +10:00
EUI Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
Examine Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
Explosion Add explosion.can_create_vacuum cvar (#27548) 2024-05-01 13:11:27 +10:00
Extinguisher Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Eye/Blinding Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Fax feat(fax): Fax machines print, copy, and send paper labels (#25979) 2024-04-28 16:12:45 +10:00
Flash Flash buff (#25730) 2024-04-18 16:30:01 +10:00
Fluids Make UseDelay SetLength do EnsureComp (#27601) 2024-05-02 22:16:16 +10:00
Forensics Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
GameTicking Fix preference loading bugs (#27742) 2024-05-07 14:21:03 +10:00
Gateway Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Gatherable Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
GenericAntag Store ninja objectives in conditions 2 (#20894) 2024-01-29 15:06:32 +11:00
Geras Geras bug fixes (#27308) 2024-05-03 19:26:09 +02:00
Ghost Add ghost role raffles (#26629) 2024-05-06 18:48:16 -07:00
GhostKick Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
Glue scoopable ash and foam, solution transfer prediction (#25832) 2024-04-01 17:27:39 +11:00
Gravity Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Guardian Fix guardian damage transfer (#26541) 2024-03-29 21:25:42 -04:00
GuideGenerator Make some prototypes use frozen collections (#22576) 2023-12-25 15:12:22 +11:00
Hands/Systems Disarm throws item in random direction (#27589) 2024-05-02 15:32:47 +03:00
HealthExaminable
Holiday Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
Holosign Remove CRLF, enforce with workflow (#26401) 2024-03-24 22:06:17 +01:00
HotPotato Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Humanoid Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
IdentityManagement Give names to solution & identity entities (#26993) 2024-04-16 14:26:47 +10:00
IgnitionSource Makes the e-sword light plasma fires, as intended. (#25665) 2024-02-28 16:59:35 -05:00
ImmovableRod Optimise immovable rod mapinit (#27149) 2024-04-20 13:07:25 +10:00
Implants Replace the teleportation logic on the SCRAM implant! (#26429) 2024-04-01 17:31:36 +11:00
Info Obsolete Logger cleanup for EntitySystems (#25941) 2024-03-10 01:15:13 +01:00
Instruments Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Interaction Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Inventory Move storage binds and slot click handling to shared (#27135) 2024-04-20 16:23:45 +10:00
IoC Loadouts redux (#25715) 2024-04-16 22:57:43 +10:00
IP Dependency update / fixes / skrungle bungle (#23745) 2024-01-12 23:22:01 +01:00
Item Misc ItemToggleSystem changes (#26489) 2024-03-28 15:05:04 +11:00
Jittering
Jobs Replace EntityUid parsing with NetEntity (#23474) 2024-01-04 11:04:31 +11:00
KillTracking DamageSpecifier Total => GetTotal (#24160) 2024-01-21 18:59:14 -07:00
Kitchen Fix microwave construction (#27500) 2024-04-29 20:19:07 -04:00
Labels/Label Fix handlabeler/utility belt misprediction (#26660) 2024-04-28 14:19:30 +10:00
LandMines Landmine stepoff (#22962) 2024-03-24 16:33:45 +11:00
Lathe Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Light Move UnpoweredFlashlight to shared (#27449) 2024-04-29 13:22:11 +10:00
Lightning Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Lock Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Lube scoopable ash and foam, solution transfer prediction (#25832) 2024-04-01 17:27:39 +11:00
Magic Code Cleanup: Purge obsolete MapManager methods (#26279) 2024-03-22 18:08:40 +11:00
MagicMirror Fix magic mirror prediction (#27356) 2024-04-26 22:37:09 +10:00
Mapping Add NukeOps Test (#27207) 2024-04-24 15:38:43 +10:00
Maps Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
MassMedia Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Materials scoopable ash and foam, solution transfer prediction (#25832) 2024-04-01 17:27:39 +11:00
Mech Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Medical Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Mind Fix some TryGetMind overrides relying on player data (#26992) 2024-04-16 14:26:32 +10:00
Mindshield Fix not removing RevolutionaryRoleComponent from minds on mindshield application (#20832) 2023-10-11 18:14:00 -04:00
Mining
Mobs Moves muted to shared (#25374) 2024-02-21 15:53:46 -05:00
MoMMI
Morgue Examine prediction (#23565) 2024-01-06 17:53:13 +11:00
Motd Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
MouseRotator
Mousetrap Fix clientside storage Whitelists (#24063) 2024-02-02 00:33:57 +11:00
Movement Unify Content's EntitySystem logging (#26216) 2024-03-18 07:30:27 +11:00
NameIdentifier Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Ninja Reduced Warning Count By 130 For Full Rebuilds (#26518) 2024-03-29 16:28:16 +11:00
NodeContainer Fix GasMixers/Filters not working (#26568) 2024-03-30 14:11:44 -04:00
NPC Revert "npc can no longer attack you through a locker" (#27680) 2024-05-05 19:22:33 +10:00
Nuke feat(fax): Fax machines print, copy, and send paper labels (#25979) 2024-04-28 16:12:45 +10:00
NukeOps Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Nutrition Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Objectives Revert Exterminator pending newmed/redesign (#26978) 2024-04-28 15:45:54 +10:00
PAI Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Paper Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Parallax Night on Europa (#27731) 2024-05-06 20:02:22 -07:00
ParticleAccelerator Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Payload/EntitySystems Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
PDA Move UnpoweredFlashlight to shared (#27449) 2024-04-29 13:22:11 +10:00
Physics Code cleanup: Purge obsoleted SharedPhysicsSystem methods (#26287) 2024-03-25 17:37:25 +11:00
Pinpointer Replace NavMap dictionaries with int[] (#27602) 2024-05-02 12:51:21 +10:00
Placement Merge ActorSystem and IPlayerManager (#21314) 2023-11-11 13:08:10 +11:00
Players Fix preference loading bugs (#27742) 2024-05-07 14:21:03 +10:00
PneumaticCannon Atmos device performance improvements (#26493) 2024-03-30 15:17:53 +11:00
Pointing Code cleanup: Purge calls to obsolete EntityCoordinates methods (#26292) 2024-03-21 12:59:56 +11:00
Points Unrevert audio (#21330) 2023-11-27 22:12:34 +11:00
Polymorph Polymorphs spawn using the parents world rotation (#27223) 2024-04-22 01:39:07 -07:00
Popups Add SharedPopupSystem.PopupClient for cursor and coordinates (#27231) 2024-04-22 13:57:13 +10:00
Power Replace NavMap dictionaries with int[] (#27602) 2024-05-02 12:51:21 +10:00
PowerCell Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
PowerSink Remove all obsolete BatteryComponent method calls (#25871) 2024-03-06 16:34:50 +11:00
Prayer Fix ghost prayer interaction (#27199) 2024-04-21 19:01:00 +10:00
Preferences/Managers Fix preference loading bugs (#27742) 2024-05-07 14:21:03 +10:00
Procedural Haunted dungeon template (#23768) 2024-03-24 14:37:18 +11:00
Projectiles Fix projectiles (#25636) 2024-02-28 00:04:32 +11:00
Puppet Moves muted to shared (#25374) 2024-02-21 15:53:46 -05:00
Radiation Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
Radio Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
RandomAppearance Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
RandomMetadata fix: localisation keys in random content books (#27390) 2024-04-27 20:23:55 +10:00
RatKing Reduced Warning Count By 130 For Full Rebuilds (#26518) 2024-03-29 16:28:16 +11:00
Remotes Restrict door remotes to only being able to manipulate doors relevant to their type (#26371) 2024-03-24 01:48:16 +01:00
Repairable add fuel costs back to finishing welding (#27030) 2024-04-19 19:20:30 -04:00
RequiresGrid Add RequiresGrid component (#23394) 2024-02-22 22:26:02 +11:00
Research Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Resist Toilet Upgrade (needs review) (#22133) 2024-03-31 14:21:18 +11:00
Respawn Code Cleanup: Purge obsolete MapManager methods (#26279) 2024-03-22 18:08:40 +11:00
Revenant Buff revenant structural damage (#27309) 2024-04-25 21:02:25 +10:00
Revolutionary better deconversion (#23315) 2024-01-14 14:20:35 +11:00
Roles Revert Exterminator pending newmed/redesign (#26978) 2024-04-28 15:45:54 +10:00
Rotatable Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Rotation Fix rotation visuals desync & appearance state spam (#23016) 2023-12-26 16:32:25 -07:00
RoundEnd Add evac shuttle test. (#27152) 2024-04-20 15:57:55 +10:00
Salvage Expeditions audio tweaks (#27524) 2024-05-06 10:19:43 +10:00
Sandbox Add door electronics access configuration menu (#17778) 2024-04-01 17:06:13 +11:00
Screens cancelable brig timers (#26557) 2024-03-31 16:44:02 -04:00
SensorMonitoring Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Sericulture
ServerInfo
ServerUpdates Un-revert IPlayerManager refactor (#21244) 2023-10-28 09:59:53 +11:00
Shuttles Dock device link port (#27646) 2024-05-06 13:59:01 +10:00
Silicons Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Singularity Show volume on the gas analyzer (#25720) 2024-04-17 09:42:24 -08:00
Solar Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Sound Add Ability to stop sound when MobState is Dead (#26905) 2024-04-14 13:12:38 +10:00
Spawners Mega Antag Refactor (#25786) 2024-04-25 11:31:45 +10:00
Species/Systems Body code cleanup (#24946) 2024-03-27 17:48:37 -07:00
Speech Cache regex instances in most cases (#27699) 2024-05-06 08:57:32 +10:00
Spider
SprayPainter Simplify DoAfterArgs behavior for movement and distance checks (#25226) 2024-03-19 21:09:00 +11:00
Spreader Atmos device performance improvements (#26493) 2024-03-30 15:17:53 +11:00
Sprite Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
Stack Storage CanInsert() tweaks (#21623) 2023-11-13 23:43:03 +11:00
Standing Revert "Fix chat bubbles (#25643)" (#25645) 2024-02-28 00:51:20 +11:00
Station Night on Europa (#27731) 2024-05-06 20:02:22 -07:00
StationEvents Round event frequency simulation command (#27718) 2024-05-06 00:33:30 -07:00
StationRecords Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Stealth
Sticky Simplify DoAfterArgs behavior for movement and distance checks (#25226) 2024-03-19 21:09:00 +11:00
Storage Fix SpawnItemsOnUse not playing sound (#27621) 2024-05-02 13:10:20 -04:00
Store Make insert telecrystal message only show to player (#27585) 2024-05-01 11:17:47 -04:00
Strip Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Stunnable Misc ItemToggleSystem changes (#26489) 2024-03-28 15:05:04 +11:00
SubFloor Code Cleanup: Purge obsolete MapManager methods (#26279) 2024-03-22 18:08:40 +11:00
SurveillanceCamera Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Tabletop Obsolete Logger cleanup for EntitySystems part 2 (#26159) 2024-03-17 18:31:09 +11:00
Teleportation Simplify DoAfterArgs behavior for movement and distance checks (#25226) 2024-03-19 21:09:00 +11:00
Temperature Reduced Warning Count By 130 For Full Rebuilds (#26518) 2024-03-29 16:28:16 +11:00
Tesla Use new ComponentPauseGenerator (#25183) 2024-02-26 14:36:19 +11:00
Thief Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Tiles Landmine stepoff (#22962) 2024-03-24 16:33:45 +11:00
Tips Tippy fixes (#27475) 2024-04-29 18:41:58 +10:00
Toilet Toilet Upgrade (needs review) (#22133) 2024-03-31 14:21:18 +11:00
Tools THE RETURN OF ITEM STATUS (#22986) 2024-04-21 23:16:23 +10:00
Toolshed/Commands Un-revert IPlayerManager refactor (#21244) 2023-10-28 09:59:53 +11:00
Traitor Mega Antag Refactor (#25786) 2024-04-25 11:31:45 +10:00
Traits Code cleanup: Dirty(Comp) (#26238) 2024-03-19 23:27:02 -04:00
UserInterface Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
VendingMachines Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Verbs Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
VoiceMask Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Voting Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
Wagging Stop wagging tails on crit (#25323) 2024-02-17 16:33:10 -05:00
Warps Default warp point names (#21017) 2023-10-16 16:39:39 +11:00
Weapons Fix effects (#27533) 2024-05-02 12:40:07 +10:00
Weather
Whitelist Obsolete refactor - ConnectedClient to Channel (#24409) 2024-01-23 09:14:13 +11:00
Wires Content update for UI prediction (#27214) 2024-04-26 18:16:24 +10:00
Worldgen Make remaining IPrototypes partial (#27157) 2024-04-20 17:48:38 +10:00
Xenoarchaeology Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Zombies Mega Antag Refactor (#25786) 2024-04-25 11:31:45 +10:00
AssemblyInfo.cs Add test to load all config presets (#20705) 2023-10-06 19:31:08 -07:00
Content.Server.csproj THE RETURN OF ITEM STATUS (#22986) 2024-04-21 23:16:23 +10:00
Content.Server.csproj.DotSettings
GlobalUsings.cs
Program.cs