* fix vent critters spawning off station
* I polish the code
* add utility to get entities ONLY on the station. use in vent critters rule.
* fix station events affecting outside grids
* better argument names for GetEntitiesWithComponentOnStation
* BreakerFlipRule
* \n
* fix doc in GetEntitiesWithComponentOnStation
* keep the comments
* remove BreakerFlipRuleComponent Blacklist
* minor cleanup
* review
* format
---------
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
* SpaceSpawnRule: generate around grid center, N try
* handle non-positive MaxAttempts
it'll just spawn on the arc at a random position, like it does now!
* comment
* fix use of indices in spawn point index list
you absolute boob
* MaxAttempts, clear before FindGridsIntersecting
Co-authored-by: Pok27 <113675512+Pok27@users.noreply.github.com>
* formattt
---------
Co-authored-by: Pok27 <113675512+Pok27@users.noreply.github.com>
* would you rather have infinite traitors but no game or infinite game but no game
* whitespace of doom
* also don't need that anymore!
* I'm fucking stupid actually :P
* fix that bug before someone else has to dive it in 2030
* pish
* merge my fixes!!!
* Scope creep my ass
* why was this shit not pushed????
* gone...
* fix that
* review plus buildd
* asfsafsafsafsafas
* grug
* burber
* I'll fix this later
* shrimply die
* also this
* it's snerf or snuthin
* assaads
* round snend
* aaaa
* fix this shit for real
* actually, don't start GameRules until MapInit now that I think aboot it.
* forgot u
* don't actually need this part nullable
* Deffer comp removal
* one liner
* do that too
* chungus
* Honestly makes more sense here, plus WHY are we doing all that shit on "GameRuleAdded" rather than GameRuleStarted(?)
* deferred removal :V
* aaaaaaaaaaaaaaa
* whhop
* Whoop
* better
* landmine that I placed for myself then forgot about lmao
* cleanup
* FUCKING `!`
* gotovo
* amogus
* please don't check by metadata I beg
* waawsasfdfsasfa
* sfafsasfafsas
* fdsaasffsasfa
* code
* fix
* fasasffasfasfsad
* chungaas
* I may be stupid
* gra
* graaaaaaaaaaaaaaaaa
* comment
* gra
* clearing is not predicted and would require major refactors, so don't cache on client.
* lame shit :P
* last holes
* nukeopsfsafsasafsfafsa
* why was that shit public bruh
* bubrbgwahrghfaka
* dynamic
* revert change that did nothing lmao
* Make every EntitySystem partial
* Oobs thats for a diff PR
* Also oops on that one
* Test systems
* git are we fr
* Update file templates
* cleanup empty classes while we are here
* forgor
---------
Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
* Logging fixed + minor clean-up of ApcToggleBreaker method
* ATS is no longer targeted by BreakFlipRule
* Fixed typo
* Now uses Uid
* Now uses Uid
* Fixed look-up
* Added blacklist to BreakerFlipComponent to specify which entities shouldn't trigger the game rule
* small fix
* Cancel if APC is in unpowered list
* Also prevent re-power via re-construction
* Revert useless dependency
* Reduced event time by 10-20 seconds
* Move to ApcSystem
* Also verify game rule is active
* Empty commit
* Move station and affected checking
* Check for main station grid
* Fix format warnings
* Somehow this got duplicated
* Make GetRuleAffectingEntity() also check for BecomesStationComponent
* Make APCSystem also check for ActivegameRuleComponent
* Removed redundant checks and duplicate logic
* Add GridEventEligibleComponent with flag for PowerGridChecks
* Propagate GridEventEligibleComponent.
* Revert GridEventEligible
* Use GetLargestGrid
* radiosystem is funny
* review
Co-authored-by: slarticodefast <slarticodefast@users.noreply.github.com>
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
* dont forget your tests
* dont forget your loc
* networking
Co-authored-by: Tayrtahn <Tayrtahn@users.noreply.github.com>
* dont return because its breaks
* uh
* review
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
* more predictions and cleanup
* refactor: just me, being picky about whitespaces and commetns formatting
---------
Co-authored-by: slarticodefast <slarticodefast@users.noreply.github.com>
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
Co-authored-by: Tayrtahn <Tayrtahn@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
Co-authored-by: Fildrance <fildrance@gmail.com>
* redundant members
* catch IonLawSystem instances
* return the ion law sawmill, fix LogMan instances
* SalvageSystem LogManager inst
* IonLawSystem: public Sawmill
* what even is initialization order?
* Remove all IPrototypeManager instances
* Remove redundant IComponentFactory instances too
* Found some stragglers
* DestructibleSystem.PrototypeManager: no dependency
* not based
* - rework a bunch of cargo orders to not send a crate with just one thing
- instead sends the item, wrapped
- add ability for cargo orders to wrap the item ordered in parcel wrap
- cargo order name and descriptions are now localization strings, but still 99.99% of the time just get that info from the entity they're spawning
- small refactor to how cargo orders move around in cargo code so that the actual order proto is kept around longer
- small rework to certain restock cargo orders to halve the cost and number of items received in one order
* oop
* Suffering
* Arbitrary containers for cargo products
* I ran the tests locally and they passed, github please rerun :)
* massage Slarti's work into this.
Mainly by taking the API wrapping ability out back with the rifle q-q
* testfail fake
* wow `_applyingState` is useful, I wonder where I should've been using that in other PRs before :^)
* pr comments
* tfw the hook doesn't update the submodule
* Update Content.Client/Cargo/UI/CargoConsoleMenu.xaml.cs
Co-authored-by: āda <ss.adasts@gmail.com>
* PR comments
* fixies
* Update Content.Client/Cargo/UI/CargoConsoleMenu.xaml.cs
* Update Content.Shared/ParcelWrap/Systems/ParcelWrappingSystem.WrappedParcel.cs
* fix wrapped parcel entity name + audio
* Actually read PR comments
* Apply suggestions from code review
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
---------
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
* init
* port hostiles to hordes, fakeout horde
* cleaning, docs
* i may be blind sometimes
* i may be even blinder
* remove friendly announcements
* fuck it
* i love microbalancing
* review
* review
* review p2
* Update Resources/Prototypes/GameRules/pests.yml
Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>
* review + powercreep
* lower the times to account for the gamerule delay
* review
* review
* fuck this return actually
* fial
---------
Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>
* push
* fix
* push
* abstract and more accurate
* new abstract method I guess
* that table does not explode
* webedit major
* Update Content.Shared/EntityTable/ValueSelector/BinomialNumberSelector.cs
Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>
* big ass merge conflicts
* sadas
* review
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>
* shelve
* halfway there
* borgar
* just pass TimeSpan.Zero????
* better API
* no more TODO
* comment
* some fixes
* Gonna make a new PR for this I guess shrug
* add quark back, cleanup some stuff
* add syndie pod back
* one final change
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* initial visual nubody
* oops overlay
* im so pheeming rn
* conversion...
* tests
* comeback of the underwear
* oops eyes
* blabbl
* zeds
* yaml linted
* search and visible count constraints
* reordering
* preserve previously selected markings colors
* fix test
* some ui niceties
* ordering
* make DB changes backwards-compatible/downgrade-friendly
* fix things again
* fix migration
* vulpkanin markings limit increase
* wrapping
* code cleanup and more code cleanup and more code cleanup and more code cleanup and
* fix slop ports
* better sampling API
* make filter work + use the method i made for its intended purpose
* fix test fails real quick
* magic mirror cleanup, remove TODO
* don't 0-init the organ profile data
* remove deltastates
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Replace usages of customTypeSerializer PrototypeIdListSerializer with something that doesn't take 20 separate words to type out
* Missed one
* Missed another
* Fix data field ids
* toolshed makes me want to take a long walk off a short pier.
* fuck it everything is in seconds.
* catch rounding error
* reviews
* lsprobtheoretical to mins
* Git please.
* Git Please.
* GIT PLEASE.
* unchange file
* take2
* empty line?
* new new lines?
* idk 1000 commits I guess
* spacius maximus
