* Make every EntitySystem partial
* Oobs thats for a diff PR
* Also oops on that one
* Test systems
* git are we fr
* Update file templates
* cleanup empty classes while we are here
* forgor
---------
Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
* Resolve obsolete TransformComponent warnings
* all gas no lerp, a few unused imports
* Resolve TransformSystem via IEntityManager.System
* Revert to set anchored in ConstructionSystem.Graph
* pragma, no FIXME, redundant TransformSystems
* Remove unused variable
* Address sloth's suggestions
* oneliner rotation assignment
* Use spawn commands with rotation
* yet more spawnattachedto changes & cleanup
* Remove unused transform import
* more transform system cleanup, dump restock warn
* Add table of contents to the guidebook
* It takes way too much reading space adding another panel, so lets do
this instead
* unused
---------
Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
* Make guidebook not reset when re-opened to same guide
* Make guidebook only expand tree when guides are changed
* Update to match master
Make guidebook not reset when re-opened to same guide
Make guidebook only expand tree when guides are changed
* Reviews
* oop
---------
Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
* Admins can now see what items are contraband and chameleon in the strip menu
* Fix the color, the default is now red
* better admin view comment
* Simplify logic, make new simple slot overlay to combine logic
* Make isadmin logic a little clearer
* Minor cleanup / spelling mistakes
* change button shape
* change to res path
* opps
* Add option to change default behavior
* Fix spacing
* Remove unused
* Rename to default
* Take away the soul of the overlay
* Add tooltip
* Fix error
* Commit
* add the form post
* dv
* fixes
* Change wording
* Address review
* wording change
* Added some stuff
* New format
* bruh
* thanks perry!
* yes
* More fixes!
* typo
* Add a command to show the list, improve the UI slightly, split up command names
* Fix UI controller
* Add better comment
* Get rid of weird recursive thing
* Cleanup
* Work on moving feedback popups out of simulation
* Move round end screen subscription to feedback ui controller
* Finish moving feedback popups out of simulation
* Fix _ as parameter
* Clean up FeedbackPopupUIController
* Clean up commands
* Fix prototype yaml
* Fix openfeedbackpopup command description
* Update Resources/Locale/en-US/feedbackpopup/feedbackpopup.ftl
Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>
* Address reviews
* Address reviews
* Fix FeedbackPopupPrototype.cs using empty string instead of string.empty
* Address some more of the reviews, style nano is still trolling sadly
* Fix feedback popup styling
* Fix PopupPrototype ID field not having a setter
* Address reviews
* Add label when no feedback entries are present
Change link button to not show when no link is set
---------
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>
* skeleton
* ok I think I understand this now
* xaml more like xam L
* good enough individual law control
* Works
* Final checks
* Final_Final.exe.docx
* removed unecessary usings
* locstrings
* doc comments
* requested changeds except var
* visual stuff
* I could write a manifesto about how much I dislike var
* color tweak + other thing
* request changed minus the inheritance
* sans Boxcontainer
* :/
* cache find
* requested changed
* removed usings
* Moved margin and removed unecessary BoxContainer
* Add log statement for missing guidebook proto
Also removed an unused parameter.
* Update Content.Client/Guidebook/DocumentParsingManager.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Switched obsolete logger usages to use Sawmill
Fix the majority of obsolete logger usages outside the engine code.
* Fix injection in ChatManager and revert BuildMech changes
* Removed extra manual injection
* Reduced extra static injection and reverted changes to CommandButton as it needs engine changes.
* Removed two more cases of double injection and an extra using
* Reverted changes for Inventory Display
* Moved sawmill setup outside constructor in Table to resolve test failure
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Add in-page links for guidebook reagent recipes
* Add links to microwave recipes
* This function is too specific to be in Control extensions
* Better naming
* Wrap RichTextLabel instead of subclassing
* "Activate" is ambiguous
* fixed all yml and cs
* Subjective Rearranging
* fixed my accidentally removed xml endline
* Accidentally included for a different PR
* Added .ThenBy and cleaned up newplayer.yml
* First clumsy implementation of guidebook protodata
* Support for Properties, format strings
* Better null
* Rename file
* Documentation and some cleanup
* Handle errors better
* Added note about client-side components
* A couple of examples
* DataFields
* Use attributes like a sane person
* Outdated doc
* string.Empty
* No IComponent?
* No casting
* Use EntityManager.ComponentFactory
* Use FrozenDictionary
* Cache tagged component fields
* Iterate components and check if they're tagged
* Open the guidebook when people with less than an hour playing join the round
* Filter for gameplayState
* Fix tests
* tweaks
* saltern update (#28773)
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Fix admin menu objects list (#28787)
* Make `MakeAntag()` log errors instead of throwing exceptions (#28771)
Make `MakeAntag()` log errors instead of throw
* add default page support for the guidebook (#28772)
* Probably a better way to handle this
---------
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Give jobs & antags prototypes a guide field
* A
* space
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
* Add todo
* Fix merge errors
---------
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
