Commit graph

7068 commits

Author SHA1 Message Date
Whatstone
cdd526ee0a
Fix killer tomato visual bug after mutation, cleanup Plant*System IComponentFactory instances. (#46201)
* MutationSystem: take GrowthStages from new plant

* get the rest of the IComponentFactory instances

might as well

* todo bem
2026-09-27 17:05:57 +00:00
Rachel
28ad6ceaea
minor tweak to TryForcePickup (#45903)
only calls TryDrop if selected hand isn't empty, returns false if TryDrop fails (no need to TryPickup if there's no space in hand).
2026-09-27 17:00:32 +00:00
Rachel
cc0111e46d
Simplified HandIsEmpty implementation (#45902)
* Simplified HandIsEmpty implementation

previous implementation called GetHeldItem, which itself calls TryGetHeldItem. Refactored to just call TryGetHeldItem directly.

also added doc comment

* whoops
2026-09-27 16:32:28 +00:00
SeungWon Kim 김승원
b3c493ffb3
Fix mobs without hands like zombie or mouse being able to switch settings on the kitchen electric grill (#46161)
* fix: 🐛 Fix eletric grill's switch setting condition

* fix: 🐛 Use `ActionBlocker.CanComplexInteract` for eletric grill's switch setting condition

Check out https://github.com/space-wizards/space-station-14/pull/46161#discussion_r4094888577
2026-09-27 16:11:13 +00:00
metalgearsloth
a3cbf7ea68
Avoid assigning tool autonetworkedfield (#46071)
Sitting there for 4 years.
2026-09-27 13:24:58 +00:00
TheShuEd
6a93e3150b
ActionContainer null exception fix (#46195)
Update ActionContainerSystem.cs
2026-09-27 03:04:24 +00:00
Princess Cheeseballs
015a1a44d0
Fix Dynamic Rule (Real) (#46197)
fixe
2026-09-26 22:11:51 +00:00
Princess Cheeseballs
083f3aaacb
Staging -> MASTER (#46196)
* fix-PlantTraitLigneous

* HarvestToolQuality

* Update PlantHolderSystem.Relay.cs

* cache default storage size

* write a little test, also unused dep

* const string it is

* why no, I don't know how to write tests

how did you know?

* HandledHandledHandled

* TestPrototypes are overrated.  Apply Pok's sugg.

Co-authored-by: Pok27 <113675512+Pok27@users.noreply.github.com>

* BRACES

* bullied by a pizza

Co-authored-by: SnappingOpossum
<181905634+SnappingOpossum@users.noreply.github.com>

* scamboni also pizza credit

Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>

---------

Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
Co-authored-by: Whatstone <whatston3@gmail.com>
Co-authored-by: SnappingOpossum <snappingopossum@outlook.com>
2026-09-26 14:59:21 -07:00
Princess Cheeseballs
632b261a8b
Fix Ligneous Plant Trait (#46072) 2026-09-26 13:13:26 -07:00
Cabin-keeper
32a357397b
Bloodstream multiplier is 1.2 instead of 2x (#46193)
change bloodstream multi to 1.2 instead of 2
2026-09-26 12:54:22 +00:00
Princess Cheeseballs
f6fd7de6ec
Mild Cryopod changes before stable (#45452)
* mild cryopod change

* boergere

* lower it again

* asdsdaasddsa

* they call me flip mcflop
2026-09-25 14:44:40 +00:00
Whatstone
df0490c151 BRACES 2026-09-24 18:52:17 -04:00
Whatstone
780728237a TestPrototypes are overrated. Apply Pok's sugg.
Co-authored-by: Pok27 <113675512+Pok27@users.noreply.github.com>
2026-09-24 18:50:28 -04:00
Pok245
0e6932a56f HandledHandledHandled 2026-09-25 01:01:54 +03:00
Whatstone
d05fce077c write a little test, also unused dep 2026-09-24 17:14:34 -04:00
Whatstone
e20b8403f6 cache default storage size 2026-09-24 16:30:09 -04:00
Pok245
8d3da51cbb Update PlantHolderSystem.Relay.cs 2026-09-24 21:50:46 +03:00
Fildrance
fca3302e3f
Fix error spamming in update loop of artifact scanner (#46149)
* refactor: make relations etween node scanner and artifact more clear, remove errors on crushing artifact while scanner is attached, add generic `attached entities` collection for artifact to be used for other purposes

* Apply xml-doc suggestion from @Tayrtahn

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

* fix: attaching scanner to other artifact now detaches it from original one

* refactor: fix whitespaces in SharedXenoArtifactSystem

* refactor: fix detaching artifact when scanning same artifact twice

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2026-09-24 18:19:44 +00:00
SlamBamActionman
19bc31aef7
Add "new player label" over the head of players joining the game for the first time (#44709)
* Initial commit

* RMC? I 'ardly know 'er

* Sprout

* Rework it to use job icons

* Revert the one change

* Always the one yaml

* Easy review changes

* We do a little salami

* Review changes

* NIGHTMARE NIGHTMARE NIGHTMARE

* Update to use StatusIconPrototype only

* Remove async

* Aaaand remove the comment, bah

* Review fixes

* Update master

* Add the ability for ghosts to see

* Byte backing

* Review fix + comment

* Update to 90 min

* Add todo message
2026-09-24 15:34:37 +00:00
mycobiota
13f96f0de2
Use permissive markup parsing for paper labels (#46165)
use permissive parsing for paper label examines so square brackets in paper labels don't risk crashing clients
2026-09-24 14:01:18 +00:00
Samuka
75239a2402
Fix matryoshka cake slice trick (#44969)
* yml changes

* recursive code

* use the recursive stuff

* fix

* use enum

* remove blank line

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>

* remove code

* datafield removed

* add size proto

* rename to Plushie

* rename to cake

* cake size protos

* remove size protos

* ensure size smaller

* use map init and log error

* this is automatic now

* this is automatic now

* send to the client

* upgrade to error again

* update proto to avoid tiny items with secret stash

* ops

* add size to toilet

* update plushie protos to remove secret stash from ian

* ops, forgot to remove these lines

* remove datafield tag

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

* use WasModified

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

* review

* Update SecretStashComponent.cs

---------

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
2026-09-24 12:39:43 +00:00
Pok245
401ffe4377 Merge remote-tracking branch 'upstream/master' into fix-PlantTraitLigneous 2026-09-24 15:38:03 +03:00
ScarKy0
eefa7073c7
Changeling Fleshtomb (#45851)
* init

* make it proper

* listing, random humanoid appearance to shared

* oops

* moar

* pre-pr cleanup

* examine change

* partial review

* ye

* comment

* examinable

* sounds

* TrapInContainer >>>>>

* textures

* ambience

* fix

* Change collection to use leftclicking

* last minute balance change fuck everything

---------

Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2026-09-24 12:31:06 +00:00
roryflowers
86e491312a
increase scram implant radius to useful range (#45029)
* increase scram implant radius to useful range

* code review

---------

Co-authored-by: Rory Flowers <roryflowers@github>
Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
2026-09-23 15:09:02 +00:00
ScarKy0
040d28fb9d
Start slug stasis after taking a corpse (#46138)
yay
2026-09-23 13:19:14 +00:00
eoineoineoin
74b926888d
Fix error when pressing movement keys in an MMI (#46135)
Missing component is OK. No error logging, please
2026-09-22 22:07:43 +00:00
SlamBamActionman
64319b3719
Fix smelters deleting unintended non-physics entities (#46131)
Initial commit
2026-09-22 21:43:10 +00:00
AndrewFenriz
17ff8effa0
Separate announcement signatures from message text (#46111)
* upd chat

* update

* fix logs

* better?

* fix doc

* IsNullOrWhiteSpace
2026-09-22 19:27:50 +00:00
Princess Cheeseballs
f8a29e834b
Fix Infinite Sleeper Agents + Tests (#46065)
* would you rather have infinite traitors but no game or infinite game but no game

* whitespace of doom

* also don't need that anymore!

* I'm fucking stupid actually :P

* fix that bug before someone else has to dive it in 2030

* pish

* merge my fixes!!!
2026-09-22 18:30:24 +00:00
SlamBamActionman
0cd76c7bac
Add industrial smelters (admin only) (#43651)
* Initial commit with shredder base functionality

* Fix items being deleted and make items continue moving after a grid tile gets deleted

* Make a bunch of previously unpullable/unrecyclable things work

* temp commit

* Fix the recycling hitbox to actually be good code

* Fix material spawning via tiles

* Finish up the prototype visuals for the shredder

* SHRED EVERYTHING

* Add reduced efficiency for recycling with shreder

* Fix miss in conflict merge

* Make more things pullable

* Update shredder textures to look different to recyclers

* Remove unused

* "fix" repairability and sprites

* Update sprites, set up TODO-s

* Fix switches, description

* Fix up some comments

* Add "Do Not Map" to the smelter

* Add to meta.json

* Review fixes

* Review changes

* Review changes

* Remove readonly in new system

* Aaaand partial class

* Fix the final test issues

* Update and resolve merge conflicts

* Update the impulse strength to match new mass values

* Fix issues after merge conflict

* Update size, fix physics resolve errors, prevent computers/circuitboards from being deleted

* Review comments

* Fix tiles giving steel

* Add a todo about tilestacking
2026-09-22 09:04:21 +00:00
āda
86e633be6e
Disposal Units tag their contents + UI comp state (#45613)
* commit

* also flipped

* oops

* fuck it added to the UI

* fix micro annoyance

* Unify components also doesn't work yet

* reuse the existing UI also clean up the UI also applying state headache

* cheat code

* flippy

* More interface changes

* yaml ;p

* private tagger

* betterer tagger

* private unit window

* limit tagger window

* access blocked

* typo

* validate

---------

Co-authored-by: iaada <iaada@users.noreply.github.com>
2026-09-22 08:55:54 +00:00
AftrLite
3d022fff3d
Move RuleGridSystem to Shared (#46116)
* wow i wonder if this works

* fix my own stupidity
2026-09-22 04:18:31 +00:00
AftrLite
42729fe109
Add support for dialogue variation for SpeakOnActionSystem (#46106)
* add support for dialogue variation for SpeakOnAction

* Requested Changes - replace random with PredictedRandom

* Requested Changes - use ProtoMan instead of dependency on IprototypeManager

* adjust field name, un-nullify speakchance, add the system's functionality to Fireball

* Update Content.Shared/Speech/EntitySystems/SpeakOnActionSystem.cs

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>

---------

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
2026-09-22 01:35:19 +00:00
Whatstone
ad593c8396
LatheMenu: cache where possible in PopulateRecipes (#46110)
* LatheMenu: cache where possible in PopulateRecipes

* Princess Cheeseballs' review + protected HasRecipe

Co-authored-by: Princess-Cheeseballs <66055347+Princess-Cheeseballs@users.noreply@github.com>

* private HasMaterials with comment

---------

Co-authored-by: Princess-Cheeseballs <66055347+Princess-Cheeseballs@users.noreply@github.com>
2026-09-21 23:18:14 +00:00
Acts1631
d8eb229a1f
Validate direct activatable UI opens (#46045)
Validate direct BUI open requests
2026-09-21 13:57:36 +00:00
eoineoineoin
f905f62250
Fix ejecting dead people from cryotube (#45730)
Handle deferred remove comp
2026-09-21 12:29:18 +00:00
JiyuSoftware
e2b66e0318
Slime inventory bugfix (#46014) 2026-09-21 10:17:21 +00:00
Whatstone
27ca7ebbc6
Cleanup: Resolve GameRule warnings. (#46094)
* Resolve StationEvent warnings

* fix misuses of ent after rename, paracusia flip

* oh god more rules

* comments, whitespace, unnecessary precision

* comments, NotNull->IsNull

oops

* more consistent ent vs. ent.Owner, whitespace

* Greytide: "with accress from... access groups"
2026-09-20 17:55:24 +00:00
phönix
d6a8071e81
Predict SpawnAfterInteractSystem (#45955)
* init

* hmmmm

* huh

* final

* hmmm

* test

* test2

* huhhuh

* minor cleanup

---------

Co-authored-by: Pok245 <113675512+Pok27@users.noreply.github.com>
2026-09-20 00:30:58 +00:00
Mehnix
e6dc98de4c
Energy Gates make a swoosh sound when you walk through them (#45843)
swoosh
2026-09-19 20:56:03 +00:00
Centronias
9b31c2a929
Parcel wrap bugfix + multihandedness enhancement (#43956)
* parcel wrap enhancements:
- bugfix: can't wrap stuff that can't be picked up because it's static (ie. usually anchored, maybe other cases, idk)
- enhancement: multi-handedness is inherited by the parcel from its contents
- technical: migrate to `EntityQuery` dependencies for all component lookups.

* Apply suggestion from @Centronias

* Update Content.Shared/ParcelWrap/Systems/ParcelWrappingSystem.cs

* Update ParcelWrappingSystem.cs

---------

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
2026-09-19 19:58:53 +00:00
Tayrtahn
8126120a2e
Fix typo: AdjustAlertEntityEffectSysten -> AdjustAlertEntityEffectSystem (#46086) 2026-09-19 18:46:24 +00:00
_Svist_
a4341832aa
Fix space racism (#46083)
pr
2026-09-19 14:33:27 +00:00
Whatstone
b062b7305d
Small lights flicker on ghost boo, make a quiet noise when turning on, and light flickering is now quieter. (#46077)
* Add SpookyPoweredLight to PoweredSmallLightEmpty

* small light makes the flicker noise >:)

* SHUT UP

* reduce light_tube_on.ogg by 4 dB, no small tonk

small light no longer makes the flicker noise <:(

* hang on a minute

* fix the other instance of AnimationTrackPlaySound

* there is... another...
2026-09-19 14:15:43 +00:00
AndrewFenriz
375904e2f4
Fix vehicle camera tracking while driving (#45969)
* eyes!

* small tweak

* cleaner

* upd!
2026-09-19 14:07:24 +00:00
AndrewFenriz
07a90a5a63
Fix camera rotation while movement is blocked (#45953)
FIX
2026-09-19 12:13:20 +00:00
AndrewFenriz
c48d77c0d2
Predict SpriteMovement visuals (#45930)
* small cleanup

* predict
2026-09-19 07:21:57 +00:00
Princess Cheeseballs
10ff4fe159
Fix Arrivals Spawn Point Priority (#46068)
An IQ too high?
2026-09-19 03:10:46 +00:00
Whatstone
f8b96b3b17
Add unshaded positronic brain & MMI layers (#45655)
* unshaded positronic brain/mmi lights

* posibrain-occupied: partial alpha on trail

* Use var, not specific types

* peaceful-joules' comments + MMIVisuals comments

* slightly more accurate copyright

* return the slab

* Apply suggestion from @Pok27

0 reading

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>

* hate

---------

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
2026-09-19 02:55:23 +00:00
Jessica M
355dda8f9d
You can now water plants directly (#45931)
* plant holder relay

* did i fuck up merge conflicts? lets find out

* relay also handle
2026-09-19 02:44:07 +00:00