* Make every EntitySystem partial
* Oobs thats for a diff PR
* Also oops on that one
* Test systems
* git are we fr
* Update file templates
* cleanup empty classes while we are here
* forgor
---------
Co-authored-by: AJCM-git <ajcm_mail@disroot.org>
* Make IsWeightless event based
* Extremely stupid bugfix how did I not catch this
* Ancient forbidden bugfix
* Merge conflicts?
* Fix merge conflicts
* Push
* fix
* AAAAAAAAAAAAA
* AAAAAAAAAAAAAAAA 2
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Explosiv nerf
* Minor changes
* Whoops
* whoopsie doodles.
* Address half of the review.
* forgot this too (flat reductions are applied before the modifier so we need to account for that :P)
* fix merge conflicts
* it's time
* whoops
* me when I logmissing true
* they call me the forgor cause I forgor
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* part 1
* second pass
* final fix
* last fix i swear
* an even bigger genius
* regex missed this
* should be all of em?
* oops
* yeah
* Revert "should be all of em?"
This reverts commit 4dd54d1b9a76977b4cf8d6008358e4dacdee6eb1.
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Empty commit
* yeah thingi
* added a GetHighestDamageTypes thingi to the DamageableSystem
* no idea why those files names are different only in github so just in case readding them
* yeah doing that
* first steps of moving the logic somewhere nicer
* still plenty to do
* gosh such a mess but getting progress done
* small fixie push
* big mess of bunch of stuff
* dealing with a conflict and fixing the random numbers
* testing if github will update now
* dealing with the other conflict
* github please update i beg you
* dealing with more conflicts
* hopefully this fixes it
* fixing conflicts again
* cleaning up stuffies
* sprite fixie
* general cleanup
* doing the small fixies first
* getting rid of the new event, gotta handle ashing next
* adding spaces to comments before i forget
* handling ashing
* think that did it?
* small fixies
* more small fixies
* last batch of quickie fixies before i gotta handle the bigger stuff
* last bunch of fixies i do understand
* small bit of progress yknow may as well yeah
* renaming and moving stuff to shared
* comment fixiees
* saving damage in a new component instead of in MindComponent
* protoid's and dict usage instead of the previously ickier methods
* small fixie before biggie fixie
* more fixies im slepy gosh
* thinkie that should fixie it
* smoothed the damage storage systeem so its less repetitive and icki and now itss cooler and i can go eepy
* lots of stuffies x3
* first step of getting git to detect my file name changes
* thinkie that should fixie it
* fixies
* just getting rid of the merge conflict, will check damageable later
* small thingies first
* more small stuffiees
* now all of the sprites have at leeast a 0
* dirtying the lastbody comp
* more fixies
* small thingi first
* another small fixie and a minor sprite fixie
* rng fixie
* moving the damage storage system to shared
* smoothing out code thats likely to be replaced soon but its good to do for now
* just showing progress bcus yis
* general progress stuffies mhm
* pushie
* small cleanup
* general progress :3
* in progress push for helpie
* proper pushie with progress and workies
* removed unnecessary usage of the storedamage component
* minor fixiees
* extra comments
* replaced a couple strings for ProtoId's
* gibbing related fixies :3
* Add origin member to class
* whitespace
* Add comments
Added some doc polish while I was here.
* Update comments
Clarification and accuracy
* Apply suggestions from code review
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Does not build do not PR
* using blah blah blah rider hates me
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* add two methods
* move stuff to damage system api
* use TryIndex
* simplify
* minor fix
* add helper functions
* fix
* remove random new line
* simplify
* remove unnecessary lines
* rename to GetDamage
* Got it working
* make more clear
* why backwards
* value should be the amount to heal
* fix
* fix all dumb fixedpoint2 edge cases I hope
* One more thing
* fix
* make it more simple
* ops it was backwards
* valueHeal can't be more than remaining
* add all keys beforehand and no need to check and add them inside the loop
* break for loop in case remaining is zero
* comment was wrong
* optimized, works
* remove random spaces
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Update DamageableSystem to modern standards
* DamageContainerId -> DamageContainerID with lint flag
* Replace strings with protoids
* Make CVar subscription declarations all consistently whitespaced
* ChangeDamage -> TryChangeDamage, cope with C# jank
* Revert event signature changes
* Restore a comment
* Re-add two queries
* Init the queries
* Use appearanceQuery in DamageChanged
* Use damageableQuery in TryChangeDamage
* Use damageableQuery in SetDamageModifierSetId
* Final cleanup, fix sandboxing
* Rectify ExplosionSystem:::ProcessEntity's call to TryChangeDamage
* Re-organize DamageableSystem
* first big fuck you breaking change.
* THATS A LOT OF DAMAGE!!!
* Fix test fails
* test fixes 2
* push it
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Clean up some parts of ExplosionSystem
* Update Content.Shared/Damage/DamageSpecifier.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Review
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* alert cleanup and API
* I expect update loops to be at the top.
* Address review
* Address review x 2
* Merg my PR
* Fix
* Update Content.Shared/Alert/AlertsSystem.cs
webedit
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* FIX THAT TEST FAIL!!!!
* Me when I forget to actually give you alerts
* Hammedborgar
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* Shelve
* 22 file diff
* What if it was just better
* Hold that thought
* Near final Commit, then YAML hell
* 95% done with cs
* Working Commit
* Final Commit (Before reviews tear it apart and kill me)
* Add a really stupid comment.
* KILL
* EXPLODE TEST FAILS WITH MY MIND
* I hate it here
* TACTICAL NUCLEAR STRIKE
* Wait what the fuck was I doing?
* Comments
* Me when I'm stupid
* Food doesn't need solutions
* API improvements with some API weirdness
* Move non-API out of API
* Better comment
* Fixes and spelling mistakes
* Final fixes
* Final fixes for real...
* Kill food and drink localization files because I hate them.
* Water droplet fix
* Utensil fixes
* Fix verb priority (It should've been 2)
* A few minor localization fixes
* merge conflict and stuff
* MERGE CONFLICT NUCLEAR WAR!!!
* Cleanup
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* feat: add a component for rejuvenateable effects
* feat: let god mode'd entities get buffs
* fix: handle old status effect system
Didn't realize BeforeStatusEffectAddedEvent was called by both systems,
oops.
* refactor: rename to RejuvenateRemovedStatusEffect
* fix: make forced sleeping a debuff again
Missed in rebase.
* refactor: make BeforeStatusEffectAdded two events
* Stun animation
* Commit 2
* Almost working commit
* Best commit
* Minor cleanup and value adjustments
* Fix animation data getting wasted and cleaned up some stuff
* Don't animate if dead
* AppearanceSystem is for chumps
* Cleanup
* More cleanup
* More cleanup
* Half working commit
* Documentation
* Works
* ComponentHandleState my beloved
* AppearanceComp compatibility
* Address review
* Borgar
* AND NOW THE END IS NEAR
* AppearanceSystem compliance (Real)
* Don't need to log missing there
* I actually hate mob prototypes so much you don't even know
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* spectra
* documentation
* added into liquid anomaly
* Update TemporaryStealthComponent.cs
* Update TemporaryStealthComponent.cs
* integrated
* new system
* mark old status effect system as obsolete
* ForcedSleeping new status effect
* work with reagents
* networking???
* Revert "integrated"
This reverts commit bca02b82bae18ae131af593d7eb86e6de2745157.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit 4a5be8c4b704a0d1ff9544b2e245d8b2701ec580.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit a4875bcb41347638854bd723d96a51c3e6d38034.
* Revert "added into liquid anomaly"
This reverts commit df5086b14bb35f1467158a36807c0f2163a16d99.
* Revert "documentation"
This reverts commit 3629b9466758cbdfa4dd5e67ece122fa2f181138.
* Revert "spectra"
This reverts commit 2d03d88c16d16ad6831c19a7921b84600daeb284.
* drowsiness status effect remove
* reagents work
* polish, remove test changes
* first Fildrance review part
* Update misc.yml
* more fildrance review
* final part
* fix trailing spaces
* sleeping status effect
* drowsiness status effect
* Create ModifyStatusEffect.cs
* some tweak
* Yay!!! Manual networking
* minor nitpick
* oopsie
* refactor: xml-docs, notnullwhen attributes, whitespaces
* fildrance and emo review
* refactor: simplify check in SharedStatusEffectsSystem by using pattern matching, TryEffectsWithComp now returns set of Entity<T, StatusEffectComponent>
---------
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
