rechka/fish-station
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
fish-station/Content.Shared
History
Leon Friedrich dbc90f202a
Bug fixes for metabolisable reagents (#4385) 
* HealthChangeMetabolism now scales with ticktime and metabolism rate

Both Food and Drink metabolisms scale with ticktime, Now HealthChangeMetabolism also does so.

Additionally, 'healthChange' now correctly scales with the metabolism rate, so it's description is now correct.

* LiverBehaviour now uses correct frameTime

Previously, the liver only metabolised reagants once every second, but incorrectly passes the current frameTime to the metabilism function, not 1 second.

* Stomach now only transfers non-empty solutions.

Makes debugging bloodstream bugs easier if the stomach is not constantly adding empty solution to it.

* Fixed StomachBehaviour using wrong SolutionContainerComponent

Stomach was using the first SolutionContainerComponent in the owner of the body, instead of the container in the owner of the mechanism (stomach). As a result, it used to use the BloodStreamComponent.Solution as a "Stomach".

* Update StomachBehavior.cs

Somach now checks if it still contains a reagant, before transferring it.

* Added argument to IMetabolizable.Metabolize()

Added availableReagent argument to IMetabolizable.Metabolize(), This ensures that this function does not over-metabolize a reagant, which can happen if tickTime*metabolismRate is larger than the available reagant

* Revert "Stomach now only transfers non-empty solutions."

This reverts commit 2a51e2d87e6e17ab76b48e5316ce501ec05ac061.

* Renamed _updateInterval to _updateIntervalSeconds

Also modified doc comment specifying units

* Fix spelling of healthChangeAmount

Changed from healthChangeAmmount to healthChangeAmount

* Fixed comment

comment used to mention _updateInterval, which has been renamed  _updateIntervalSeconds

* Fixed typo in comment

* fixed typos: reagant -> reagent

Most typos were just in comments.

* Make metabolizable classes inherit from DefaultMetabolizable

Also involved changing around IMetabolizable

* Renamed variables

metabolismAmount -> amountMetabolized

* Updated Comments in DefaultMetabolizable

Makes it clearer why DefaultMetabolizable works as it does, and that other classes depend on it.
2021-07-30 21:11:02 -07:00
..
Access Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
ActionBlocker Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Actions Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Acts Slight trigger refactor (#4320) 2021-07-25 12:09:08 +02:00
Administration Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
AI Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Alert Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
AME Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
APC Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Arcade Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Atmos Remove EntityNetworkUtils, move extension methods to AtmosDirection class. 2021-07-25 15:05:05 +02:00
Audio Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Body Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Botany Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Buckle Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Cabinet Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Camera Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Cargo Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
CCVar Add CVar for disabling/enabling excited groups. 2021-07-26 11:16:34 +02:00
CharacterAppearance Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
CharacterInfo Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Chat Chat improvements. (#4283) 2021-07-20 10:29:09 +02:00
Chemistry Bug fixes for metabolisable reagents (#4385) 2021-07-30 21:11:02 -07:00
Climbing Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Cloning Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Clothing Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Collections Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
CombatMode Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Communications Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Computer Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Configurable Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Construction Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Conveyor Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Cooldown Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Coordinates Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Crayon Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Cuffs Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Damage Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Dataset Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Directions Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Disposal Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
DoAfter Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Doors Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
DragDrop Improve hands & pulling (#4389) 2021-07-31 03:14:00 +02:00
DrawDepth Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
EffectBlocker Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Emoting Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
EntityList Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00
Entry Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Eui Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Examine Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Explosion Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Flash Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Fluids Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Foam Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Friction Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
GameTicking Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
GameWindow Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Ghost Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Gravity Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Hands Improve hands & pulling (#4389) 2021-07-31 03:14:00 +02:00
HUD Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00
Input Chat improvements. (#4283) 2021-07-20 10:29:09 +02:00
Instruments Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Interaction Improve hands & pulling (#4389) 2021-07-31 03:14:00 +02:00
Inventory Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
IoC Move some files out of Content.Shared root because I forgot (#4182) 2021-06-13 22:52:40 +10:00
Item Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Kitchen reagentgrinder ecs & xamlui (#4347) 2021-07-28 21:58:38 -07:00
Lathe Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Light Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Localizations Removed old Loc.GetString() use instances (#4155) 2021-06-21 02:13:54 +02:00
MachineLinking Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Maps Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Markers Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Materials Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Maths Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
MedicalScanner Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Metabolism/Events Deprecate IActionBlocker in favour of cancellable events (#4193) 2021-06-19 10:03:24 +02:00
Mining Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00
MobState Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Module Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Morgue Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Movement Grid-relative movement (#4327) 2021-07-25 17:48:22 +02:00
NodeContainer Pow3r: stage 1 (#4208) 2021-07-04 18:11:52 +02:00
Notification/Managers Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Nutrition/Components Remove FoodContainer, add whitelists, replace with SpawnItemsOnUse (#4358) 2021-07-25 17:41:50 +02:00
Objectives Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Paper Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
PDA Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Physics Improve hands & pulling (#4389) 2021-07-31 03:14:00 +02:00
Placeable Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Pointing/Components Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Power Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
PowerCell Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Preferences Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Projectiles Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Prototypes Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Pulling Improve hands & pulling (#4389) 2021-07-31 03:14:00 +02:00
Radiation Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Random/Helpers Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Recycling Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Research Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Roles Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Rotatable Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Rotation Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Rounding Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Sandbox Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Shuttles Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Singularity Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Slippery Slipping, now with 20% more ecs (#4310) 2021-07-21 22:13:58 +10:00
SMES Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Smoking Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Solar Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Sound Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Spawning Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Speech Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Stacks Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Standing Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
StationEvents Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Storage Added mapped storage for things like crayon belts and tools (#4201) 2021-07-22 02:56:55 -07:00
Strip/Components Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Stunnable Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
SubFloor SubFloorHide requires entities to be anchored by default. 2021-07-30 12:26:18 +02:00
Suspicion Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Tag Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Targeting Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Temperature Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Throwing Make Saltern driveable (#4257) 2021-07-21 21:15:12 +10:00
Toilet Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Tool Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Transform Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Trigger Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Vapor Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
VendingMachines Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Verbs Add UI for setting solution transfer amount (#4074) 2021-07-25 00:53:53 -07:00
Voting Vote type delay, code comments. 2021-07-21 19:03:10 +02:00
Wall Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Weapons Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Whitelist Fix EntityWhitelist not taking into account ignored components 2021-07-24 15:46:44 -07:00
Window Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
Wires Remove redundant #nullable enable (#4275) 2021-07-16 17:37:09 -07:00
app.config Updates submodule (#56) 2018-04-12 23:56:43 +02:00
Content.Shared.csproj Re-organize all projects (#4166) 2021-06-09 22:19:39 +02:00
Content.Shared.csproj.DotSettings Moved interaction interfaces from Server to Shared. 2020-07-18 22:51:56 -07:00